From nobody Tue Nov 4 23:53:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531730563842274.95290355429086; Mon, 16 Jul 2018 01:42:43 -0700 (PDT) Received: from localhost ([::1]:49779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fez5e-00049w-LN for importer@patchew.org; Mon, 16 Jul 2018 04:42:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fez1S-0001Dk-60 for qemu-devel@nongnu.org; Mon, 16 Jul 2018 04:38:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fez1Q-00051L-05 for qemu-devel@nongnu.org; Mon, 16 Jul 2018 04:38:22 -0400 Received: from ozlabs.org ([203.11.71.1]:41453) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fez1P-0004yu-EV; Mon, 16 Jul 2018 04:38:19 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 41TcHn0gCgz9s2g; Mon, 16 Jul 2018 18:38:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1531730293; bh=zXnUpfU39XzizE4+1f1+mn6F28jZP2H2aiFFNg4CxHo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fhG8umfkVxPmf63jtFajqeiZieho1oXFJB1nSmHvRsjWiak8h6OeMY2TaqVMZMuV/ kt5b+9+qsDrKvdPuAiyAkj0Zx9HC5b0p7GMkoI0WGg0E+A6NKymCCJxf5amHJy5QkV 8kXzvK1HpGLiNeiU9xk6OrCj5wEKXd1FIYaMqyS0= From: David Gibson To: peter.maydell@linaro.org Date: Mon, 16 Jul 2018 18:38:09 +1000 Message-Id: <20180716083809.17115-7-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716083809.17115-1-david@gibson.dropbear.id.au> References: <20180716083809.17115-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 6/6] sm501: Fix warning about unreachable code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, groug@kaod.org, David Gibson , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: BALATON Zoltan Coverity warned that the false arm of conditional expression is unreachable when it is inside an if with the same condition. Remove the unreachable code to avoid the warning. Fixes: CID 1394215 Reported-by: Paolo Bonzini Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: David Gibson --- hw/display/sm501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 9ab29d35dd..874260a143 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1024,7 +1024,7 @@ static void sm501_i2c_write(void *opaque, hwaddr addr= , uint64_t value, if (res) { SM501_DPRINTF("sm501 i2c : transfer failed" " i=3D%d, res=3D%d\n", i, res); - s->i2c_status |=3D (res ? SM501_I2C_STATUS_ERR= OR : 0); + s->i2c_status |=3D SM501_I2C_STATUS_ERROR; return; } } --=20 2.17.1