From nobody Tue Nov 4 23:53:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531730668147853.9592789995324; Mon, 16 Jul 2018 01:44:28 -0700 (PDT) Received: from localhost ([::1]:49789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fez7L-0005gX-7B for importer@patchew.org; Mon, 16 Jul 2018 04:44:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fez1P-0001B8-Ei for qemu-devel@nongnu.org; Mon, 16 Jul 2018 04:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fez1N-0004yS-6s for qemu-devel@nongnu.org; Mon, 16 Jul 2018 04:38:19 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:57179) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fez1M-0004si-3V; Mon, 16 Jul 2018 04:38:17 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 41TcHm3Rmkz9rvt; Mon, 16 Jul 2018 18:38:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1531730292; bh=Jg5eoVdvB4+Y0k3gddvFYo9Vmvh25BlWuGDlNd415tI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=poWDHxbTudsBn+4xrD0BP4RcyGLhin/UJTzEiaif6dCiVuqLXz/egKnVzRW7UAk4V ETxk1cgqBsvfiPxPCje98xdQo0ibDkEdHhlj4+jMO6KrJOdjTtsUDj6KlecGIrVNMV NB4wh6WBTZXNxHk96bH2M4KGlT8fZh4f0+c+uojE= From: David Gibson To: peter.maydell@linaro.org Date: Mon, 16 Jul 2018 18:38:05 +1000 Message-Id: <20180716083809.17115-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180716083809.17115-1-david@gibson.dropbear.id.au> References: <20180716083809.17115-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 2/6] spapr: Correct inverted test in spapr_pc_dimm_node() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Gibson , qemu-ppc@nongnu.org, groug@kaod.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This function was introduced between v2.11 and v2.12 to replace obsolete ways of specifying the NUMA nodes for DIMMs. It's used to find the correct node for an LMB, by locating which DIMM object it lies within. Unfortunately, one of the checks is inverted, so we check whether the address is less than two different things, rather than actually checking a range. This introduced a regression, meaning that after a reboot qemu will advertise incorrect node information for memory to the guest. Signed-off-by: David Gibson Reviewed-by: Greg Kurz Reviewed-by: Igor Mammedov --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 3f5e1d3ec2..421b2dd09b 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -665,7 +665,7 @@ static uint32_t spapr_pc_dimm_node(MemoryDeviceInfoList= *list, ram_addr_t addr) if (value && value->type =3D=3D MEMORY_DEVICE_INFO_KIND_DIMM) { PCDIMMDeviceInfo *pcdimm_info =3D value->u.dimm.data; =20 - if (pcdimm_info->addr >=3D addr && + if (addr >=3D pcdimm_info->addr && addr < (pcdimm_info->addr + pcdimm_info->size)) { return pcdimm_info->node; } --=20 2.17.1