From nobody Tue Nov 4 21:40:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531689602712516.2666856523991; Sun, 15 Jul 2018 14:20:02 -0700 (PDT) Received: from localhost ([::1]:47566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1feoQz-0008F0-M0 for importer@patchew.org; Sun, 15 Jul 2018 17:20:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1feoOe-0007H9-GH for qemu-devel@nongnu.org; Sun, 15 Jul 2018 17:17:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1feoOb-0004sC-Hs for qemu-devel@nongnu.org; Sun, 15 Jul 2018 17:17:36 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:25834) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1feoOb-0004qb-Ad for qemu-devel@nongnu.org; Sun, 15 Jul 2018 17:17:33 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id A394B7456B9; Sun, 15 Jul 2018 23:17:31 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 311B67456B5; Sun, 15 Jul 2018 23:17:31 +0200 (CEST) From: BALATON Zoltan Date: Sun, 15 Jul 2018 22:59:21 +0200 To: qemu-devel@nongnu.org Message-Id: <20180715211731.311B67456B5@zero.eik.bme.hu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:738:2001:2001::2001 Subject: [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Coverity warned that the false arm of conditional expression is unreachable when it is inside an if with the same condition. Remove the unreachable code to avoid the warning. Fixes: CID 1394215 Reported-by: Paolo Bonzini Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/sm501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 9ab29d3..874260a 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1024,7 +1024,7 @@ static void sm501_i2c_write(void *opaque, hwaddr addr= , uint64_t value, if (res) { SM501_DPRINTF("sm501 i2c : transfer failed" " i=3D%d, res=3D%d\n", i, res); - s->i2c_status |=3D (res ? SM501_I2C_STATUS_ERR= OR : 0); + s->i2c_status |=3D SM501_I2C_STATUS_ERROR; return; } } --=20 2.7.6