From nobody Tue Nov 4 21:59:33 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531484379997872.1302017787791; Fri, 13 Jul 2018 05:19:39 -0700 (PDT) Received: from localhost ([::1]:36966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdx2w-0005i3-8F for importer@patchew.org; Fri, 13 Jul 2018 08:19:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdx1A-0004lp-Bi for qemu-devel@nongnu.org; Fri, 13 Jul 2018 08:17:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdx19-0003eT-C0 for qemu-devel@nongnu.org; Fri, 13 Jul 2018 08:17:48 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:37426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdx19-0003co-4L for qemu-devel@nongnu.org; Fri, 13 Jul 2018 08:17:47 -0400 Received: by mail-wr1-x42e.google.com with SMTP id q10-v6so24910895wrd.4 for ; Fri, 13 Jul 2018 05:17:47 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id y14-v6sm4982246wrq.45.2018.07.13.05.17.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Jul 2018 05:17:43 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 3D41B3E06C8; Fri, 13 Jul 2018 13:17:42 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iuLXyrPnRE4rW5eg+qwTCiglTBSrKh3Lyhji9XKfoz0=; b=Ap1mJgE2DGjZA2w33s5SjQHtf5Xpl/W38N3xJJPVDxwSPSytV4B1hHNN90qKilQVwA CmOmP4v3OtHv0Vx08hH/2Xou5ctNFcvK1vustXIMW8odoR4OHtqfE87M0GCSiOeS/zP/ DOEf2Swz0lZCtMrwOh2H2J4DjvJhe4S1ruPQQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iuLXyrPnRE4rW5eg+qwTCiglTBSrKh3Lyhji9XKfoz0=; b=j6TpCTS4uQwcOg4cSSqEpgpYHl0vFQXAhEBtrIYtqeavBh7MLJFPZdn0v9f6UI/f9K 3rzrpeoY8CunRaQa6dlSo95TtMiThz2Rw2HVSjg0KDW7HPRZfCT/mzksfwvaDQAl3geW ioRFbESI0cyH9UvqeIgi9cVO6eQFsj8lTJSYGjYZP/MrhIkhnBA8SGhFPuAC1vnRah8K S4E3P5miEWL16SiQ2YRJ8rVSsWvEN/L9WZiLEi4mi6maOef51Cc+TyX/uK5lHg52RHGx XmTAzULkqEt7Xsb99vnGshyBJOFMeCVyKNvteRhwMrtHMz9ft05Lt2e3iiDWYXHI2+Fi tdjA== X-Gm-Message-State: AOUpUlFLw/Ta4b5VYyJGygQKvp8EzxUrKKxYlz3tKmHtRJZE8IWjoblJ 5NlmRGcEmBVnULDfYFL9+lMTZA== X-Google-Smtp-Source: AAOMgpfD5zEgvk0Fg/lbI1wKNquB7cOpixx9VKZTqdmnQb9relxYOivDyD/N55QZs2mM97VTecoTFQ== X-Received: by 2002:adf:c00b:: with SMTP id z11-v6mr4541757wre.268.1531484266161; Fri, 13 Jul 2018 05:17:46 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Fri, 13 Jul 2018 13:17:29 +0100 Message-Id: <20180713121741.19262-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180713121741.19262-1-alex.bennee@linaro.org> References: <20180713121741.19262-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e Subject: [Qemu-devel] [PATCH v2 for 3.0 04/16] docker: fail more gracefully on docker.py check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 As this is called directly from the Makefile while determining dependencies and it is possible the user was configured in one window but not have credentials in the other. Let's catch the Exceptions and deal with it quietly. Signed-off-by: Alex Benn=C3=A9e Reported-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/docker/docker.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 69e7130db7..2f81c6b13b 100755 --- a/tests/docker/docker.py +++ b/tests/docker/docker.py @@ -479,7 +479,12 @@ class CheckCommand(SubCommand): def run(self, args, argv): tag =3D args.tag =20 - dkr =3D Docker() + try: + dkr =3D Docker() + except: + print("Docker not set up") + return 1 + info =3D dkr.inspect_tag(tag) if info is None: print("Image does not exist") --=20 2.17.1