From nobody Tue Nov 4 22:03:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15314846353800.12645732353712447; Fri, 13 Jul 2018 05:23:55 -0700 (PDT) Received: from localhost ([::1]:36989 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdx74-0000gx-8K for importer@patchew.org; Fri, 13 Jul 2018 08:23:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdx1F-0004n3-D5 for qemu-devel@nongnu.org; Fri, 13 Jul 2018 08:17:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdx1E-0003nn-CV for qemu-devel@nongnu.org; Fri, 13 Jul 2018 08:17:53 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:40948) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fdx1E-0003mj-5f for qemu-devel@nongnu.org; Fri, 13 Jul 2018 08:17:52 -0400 Received: by mail-wr1-x434.google.com with SMTP id t6-v6so24912507wrn.7 for ; Fri, 13 Jul 2018 05:17:52 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id l6-v6sm5253739wmh.41.2018.07.13.05.17.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Jul 2018 05:17:48 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id EDD793E08B3; Fri, 13 Jul 2018 13:17:42 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WltgY+ioPBVaA4MSIqyW/3VPytavaaSl8us8SORoE0o=; b=X6v5/fzWMpS7NnOYpBma38LouI2O9/EjUarMo28PauEGNpBxGW7xZ2Wyd7bsM6Bjp1 cZv5wGOYVjI+ijS6g5ylGH+zxdIEdiyxNN8tapCPYTwlOqFAT5mEjOtZgUY8Kx7NP4pW YxJO/+ViQk52Eaq+l4zYUHGVbl5YyOJvpESUw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WltgY+ioPBVaA4MSIqyW/3VPytavaaSl8us8SORoE0o=; b=Y81ZFiFlcItr4tjMxAxv2KBS9V31fOB5h94riQ9nBovoYcPILjh6sB+COTaBjKjt/F BjPK6eU8M0GPES9Y/1Jn0QhUXsb5MshmDpXTPrO0fBLv0ed59XdCxQO9SOgwNy/YBcFt QjpKqtYKV+EB3/Bd8+lZle5MVw3cFNIEyUPVMuA8sAgp9imiLoNOHgnS5I3jjpqMuAsf rU5aYUjc2bEJSpPV5tmXEnXx9f/WBphUiwYjTek/pCcDd4w8r6BXr6wjZrJZm8KRm3cx J+bd0NWQLZjgWryHZwxttN9gZ16JlZfptgLb3P5XVElpMWHjTUieFn4hOHKgtD3IU7HL +aiw== X-Gm-Message-State: AOUpUlE0A11nzdSWWYNSCeH65xwUAyvK7fQlctrEWZ49pdZiXviOTRpm 2AEpIwjaD/KrtUdvsvAQnRZEqQ== X-Google-Smtp-Source: AAOMgpdGKQuEQapGdMpG+cKn2/78cQiinGZQV0O5HuDCojIdOrQnRhI1LKx11ix7k2n1bnoav8xa2g== X-Received: by 2002:adf:91e5:: with SMTP id 92-v6mr4252064wri.124.1531484271189; Fri, 13 Jul 2018 05:17:51 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Fri, 13 Jul 2018 13:17:38 +0100 Message-Id: <20180713121741.19262-14-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180713121741.19262-1-alex.bennee@linaro.org> References: <20180713121741.19262-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::434 Subject: [Qemu-devel] [PATCH v2 for 3.0 13/16] docker: add --hint to docker.py check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 When a check fails we currently just report why we failed. This is not totally helpful to people who want to boot-strap a new image. Add a --hint option which we can pass down to give a bit more information. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- tests/docker/Makefile.include | 3 ++- tests/docker/docker.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index ec23620153..c9e412f9d0 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -73,7 +73,8 @@ docker-binfmt-image-debian-%: $(DOCKER_FILES_DIR)/debian-= bootstrap.docker $(if $(EXECUTABLE),--include-executable=3D$(EXECUTABLE)), \ "BUILD","binfmt debian-$* (debootstrapped)"), \ $(call quiet-command, \ - $(DOCKER_SCRIPT) check --quiet qemu:debian-$* $<, \ + $(DOCKER_SCRIPT) check --quiet qemu:debian-$* $< \ + --hint "you will need to build $(EXECUTABLE)", \ "CHECK", "debian-$* exists")) =20 endif diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 2f81c6b13b..523f4b95a2 100755 --- a/tests/docker/docker.py +++ b/tests/docker/docker.py @@ -475,6 +475,7 @@ class CheckCommand(SubCommand): default=3D"checksum", help=3D"check type") parser.add_argument("--olderthan", default=3D60, type=3Dint, help=3D"number of minutes") + parser.add_argument("--hint", default=3D"", help=3D"hint to user") =20 def run(self, args, argv): tag =3D args.tag @@ -487,7 +488,7 @@ class CheckCommand(SubCommand): =20 info =3D dkr.inspect_tag(tag) if info is None: - print("Image does not exist") + print("Image does not exist %s" % (args.hint)) return 1 =20 if args.checktype =3D=3D "checksum": --=20 2.17.1