From nobody Fri Mar 29 11:53:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531336559147786.9403729924915; Wed, 11 Jul 2018 12:15:59 -0700 (PDT) Received: from localhost ([::1]:55137 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdKaa-00033o-3T for importer@patchew.org; Wed, 11 Jul 2018 15:15:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdKZ3-0001x6-QI for qemu-devel@nongnu.org; Wed, 11 Jul 2018 15:14:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdKZ3-0003YC-02 for qemu-devel@nongnu.org; Wed, 11 Jul 2018 15:14:13 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:39400 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fdKZ2-0003XP-RJ for qemu-devel@nongnu.org; Wed, 11 Jul 2018 15:14:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 778D57C6CA for ; Wed, 11 Jul 2018 19:14:12 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-125.ams2.redhat.com [10.36.116.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D713E10FFE4C; Wed, 11 Jul 2018 19:14:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 8B4C31138529; Wed, 11 Jul 2018 21:14:08 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 11 Jul 2018 21:14:08 +0200 Message-Id: <20180711191408.2438-2-armbru@redhat.com> In-Reply-To: <20180711191408.2438-1-armbru@redhat.com> References: <20180711191408.2438-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 11 Jul 2018 19:14:12 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 11 Jul 2018 19:14:12 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'armbru@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PULL 1/1] monitor: fix double-free of request error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau qmp_error_response() will free the given error. Fix double-free in later qmp_request_free(). Signed-off-by: Marc-Andr=C3=A9 Lureau Message-Id: <20180705164201.9853-1-marcandre.lureau@redhat.com> Reviewed-by: Markus Armbruster Fixes: 1cc37471525d03f963bc71d724f0dc9eab888fc1 Signed-off-by: Markus Armbruster --- monitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/monitor.c b/monitor.c index 3c9c97b73f..7af1f18d13 100644 --- a/monitor.c +++ b/monitor.c @@ -4186,6 +4186,7 @@ static void monitor_qmp_bh_dispatcher(void *data) } else { assert(req_obj->err); rsp =3D qmp_error_response(req_obj->err); + req_obj->err =3D NULL; monitor_qmp_respond(req_obj->mon, rsp, NULL); qobject_unref(rsp); } --=20 2.17.1