From nobody Tue Nov 4 22:04:04 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531150102425672.4628130035434; Mon, 9 Jul 2018 08:28:22 -0700 (PDT) Received: from localhost ([::1]:42778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcY5J-00066k-Cp for importer@patchew.org; Mon, 09 Jul 2018 11:28:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcXye-0000lZ-Jd for qemu-devel@nongnu.org; Mon, 09 Jul 2018 11:21:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcXyc-0005VE-Vj for qemu-devel@nongnu.org; Mon, 09 Jul 2018 11:21:24 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:36056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fcXyc-0005Uw-OO for qemu-devel@nongnu.org; Mon, 09 Jul 2018 11:21:22 -0400 Received: by mail-wr1-x42f.google.com with SMTP id h9-v6so11417103wro.3 for ; Mon, 09 Jul 2018 08:21:22 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id j43-v6sm31513211wrj.1.2018.07.09.08.21.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Jul 2018 08:21:20 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 1D3C73E0719; Mon, 9 Jul 2018 16:21:18 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b9dwgQE+jSaWHFqJ6A4rb3x0Ow71/8K1IvfxEN0HeeM=; b=ctIM3vqpc7cHgoM2DpDbnFZpRo+YyP9eeaUPiwfNQ4RGwlRFiHJgoi9EY5uDKXwMPj QJO168SxVRpBy7y74TvDqvj+HPSVau8U04AN0/0Mh2uLJ9Ku2yxYu8UDWu7/7ammjHTI MVUA2EmtdFB1TrnhJmGBuZX7j2wu3dyTPKV2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b9dwgQE+jSaWHFqJ6A4rb3x0Ow71/8K1IvfxEN0HeeM=; b=Jd3Vn9NtfAYKxKWM3HImT2AuYuGEn86ULo7DoIfyb89twqPpsCQ6yTzWysrfYpyNED H9meb2WaTppUQdJeZAyTYdl/AJbtubKCrbNJrmI21wuzzdsMLCDmRdEx/6EnbmHvnFzP f+nTMVPjGm0B3qNXMTl7O9CODeY9LwGrAAst9Qe51g20YtgMTMKnd7g56PPa/Qi9f+tX oZdvcLk3jmkFDuVMe0kKY5BNIbOjPU/dTmOT6pWOZLYFSQAMnDfIKDfU/HV5VtqJgUul aXJ4wyTV0e8XyPvLpxfgSUfvrDgR54KDdr/xAxaqF68oxXmVVY21yd6XawhhdXmKjMDv 3zBw== X-Gm-Message-State: APt69E0wajfCAgZatGhx6DCFIMTcYGx+0g4i0+Bmp/H/TbKzWGGBWUvO fTNML3DLoxca2x6tyg8aqzFX3g== X-Google-Smtp-Source: AAOMgpeW+R7nyuhEw0+wX+DTJPkAaJMmdzww/oibDAhmNb570bgtnwA4ZqS2IsxzQEoA4c2o25oS0w== X-Received: by 2002:adf:ad38:: with SMTP id p53-v6mr15881384wrc.10.1531149681703; Mon, 09 Jul 2018 08:21:21 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Mon, 9 Jul 2018 16:21:10 +0100 Message-Id: <20180709152117.21585-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180709152117.21585-1-alex.bennee@linaro.org> References: <20180709152117.21585-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42f Subject: [Qemu-devel] [PATCH for 3.0 03/10] docker: fail more gracefully on docker.py check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 As this is called directly from the Makefile while determining dependencies and it is possible the user was configured in one window but not have credentials in the other. Let's catch the Exceptions and deal with it quietly. Signed-off-by: Alex Benn=C3=A9e Reported-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/docker/docker.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index 69e7130db7..2f81c6b13b 100755 --- a/tests/docker/docker.py +++ b/tests/docker/docker.py @@ -479,7 +479,12 @@ class CheckCommand(SubCommand): def run(self, args, argv): tag =3D args.tag =20 - dkr =3D Docker() + try: + dkr =3D Docker() + except: + print("Docker not set up") + return 1 + info =3D dkr.inspect_tag(tag) if info is None: print("Image does not exist") --=20 2.17.1