From nobody Tue Nov 4 18:45:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531143784119566.117554241548; Mon, 9 Jul 2018 06:43:04 -0700 (PDT) Received: from localhost ([::1]:42040 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcWRS-0002mX-Iv for importer@patchew.org; Mon, 09 Jul 2018 09:43:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcVhB-0003xw-Bm for qemu-devel@nongnu.org; Mon, 09 Jul 2018 08:55:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcVh6-00021b-GG for qemu-devel@nongnu.org; Mon, 09 Jul 2018 08:55:13 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:34146) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fcVh6-00021J-9F for qemu-devel@nongnu.org; Mon, 09 Jul 2018 08:55:08 -0400 Received: by mail-wr1-x441.google.com with SMTP id c13-v6so10839659wrt.1 for ; Mon, 09 Jul 2018 05:55:07 -0700 (PDT) Received: from vm.localdomain (71.208.159.77.rev.sfr.net. [77.159.208.71]) by smtp.gmail.com with ESMTPSA id x6-v6sm17986569wrd.57.2018.07.09.05.55.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Jul 2018 05:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=688YuX2lutmYYWafUrmPciFoBQCSSVkTIA2fwuCPKcI=; b=O3y4H47F9YIJ7bRQ5R3ZrpEXxImqOM2pHw9rK06hN0qLsuwXLHoXfRgCEk5E2wUpnX /jKW9OMrzlaOK3mmR5l6nw43VWzfDUKWs7+u6n8TLXmN88wsMoMRRH6T2VIGXzXlPBVc LmYS8/mo2Z8vvnV3ZJXCVYTd68R791lLFfnYD5pjqbyJG/zf4kFpz/pldUTTheaFKYto V/c5MaWs0hOmGvjmV5vGnKdAoB6xTsCAl4Vk58pa4RYoRYxIDEbxFnOayU2+Ux25+dXX pa1IBPW51u4qjY69Ek/b6yBuYAQlVHQ/b8FY/035Hak1+BW69jlWcINW2ip4cx10U44Y OgMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=688YuX2lutmYYWafUrmPciFoBQCSSVkTIA2fwuCPKcI=; b=P1UmORhjiSongOogjdukUi1VI3tFHTREHsNrumWvgC88vJjKGDpX+PkX+26WWZhtMH 811IPJNyHZC7bLb3d334gkNZGUDIyTxFTktwCIDsxgOl364itaUXOwr6fxw26nlPtyN0 rxXWW1Q0XMn0X2Yg9sUCyqkSAQG48LOKgYPED1adV1/N+slbanN6ucX7Wq7zblBCq6Bm Wx94SUe30gMT+90vyX+VGUCBTx9fxiECWYLKIRUk9wfLoNkpyAGxWNUP/ECqYost8OPs puokWdS6m1xsh4ytbzH4bcQqh3N1aTk+UCz+vboMJFkMnCKxEiUdptITp2VjC2/qwRN3 rICQ== X-Gm-Message-State: APt69E0wAx8V9Xru4T9qA/RcPIQT7625IyFbvoM+V0kuiXT+pnwb7k1P 0rFkjW8LACqzIaKLMdTken7vZQ== X-Google-Smtp-Source: AAOMgpczQ7Ls/PQHcIX0EV6pR/f1KJi0WRiO/2oZa+iLh5zjpx8NZ/5LCRq9YZyo9oRJbykYgRik7w== X-Received: by 2002:adf:ce04:: with SMTP id p4-v6mr13717547wrn.275.1531140906791; Mon, 09 Jul 2018 05:55:06 -0700 (PDT) Date: Mon, 9 Jul 2018 14:54:59 +0200 From: stephane duverger To: qemu-devel@nongnu.org Message-ID: <20180709125452.7utyomtsxr6xaxdi@vm.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170609 (1.8.3) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-Mailman-Approved-At: Mon, 09 Jul 2018 09:40:40 -0400 Subject: [Qemu-devel] [PATCH] fix gdbserver_state pointer validation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi, This is a small patch to gdbstub rather insignificant at first sight: fix null pointer dereference. It actually allows to take benefit of gdb features (breakpoints/sstep) internally (ie. special purpose board) without connecting a gdb client to the Qemu instance gdbserver stub. Regards, Signed-off-by: Stephane Duverger --- gdbstub.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index d6ab95006c..788fd625ab 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1412,6 +1412,9 @@ static int gdb_handle_packet(GDBState *s, const char = *line_buf) =20 void gdb_set_stop_cpu(CPUState *cpu) { + if (!gdbserver_state) { + return; + } gdbserver_state->c_cpu =3D cpu; gdbserver_state->g_cpu =3D cpu; } --=20 2.14.1