From nobody Tue Nov 4 21:44:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531122394542158.7398662570714; Mon, 9 Jul 2018 00:46:34 -0700 (PDT) Received: from localhost ([::1]:39713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcQsI-0006YU-Mj for importer@patchew.org; Mon, 09 Jul 2018 03:46:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcQq5-00052e-7X for qemu-devel@nongnu.org; Mon, 09 Jul 2018 03:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcQq4-0002AX-DM for qemu-devel@nongnu.org; Mon, 09 Jul 2018 03:44:05 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:49569) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fcQq4-00028n-0N; Mon, 09 Jul 2018 03:44:04 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 41PHQR5Prqz9s00; Mon, 9 Jul 2018 17:43:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1531122239; bh=uh61IcssZAtaT35JH6XKvywolvTWRBwEW2Awv4ov8x0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bLA6fZ78WpMJPlikJpJ/x0PMF/sBXmqsRw4T+BVJDNIU1/TJdtPXBQvfRwqdoHXP5 YXxUfbJnVcQeoqfGFGuo3JVL+E+DV1voqaS5p0EZD8Sl+tuvgljugWSR5Ze7HlDJUr gG/9wERKk8wCo/yVn6e4GkK5/ik6SutwA2mv3ovo= From: David Gibson To: peter.maydell@linaro.org Date: Mon, 9 Jul 2018 17:43:36 +1000 Message-Id: <20180709074350.27086-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180709074350.27086-1-david@gibson.dropbear.id.au> References: <20180709074350.27086-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: [Qemu-devel] [PULL 02/16] spapr/vio: quiet down the "irq" property accessors X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: C=C3=A9dric Le Goater commit efe2add7cb7f ("spapr/vio: deprecate the "irq" property") introduced get/set accessors for the "irq" property to warn of its usage, but the warning in the get pollutes the monitor 'info qtree'. Signed-off-by: C=C3=A9dric Le Goater Signed-off-by: David Gibson --- hw/ppc/spapr_vio.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_vio.c index daf85130b5..be9af71437 100644 --- a/hw/ppc/spapr_vio.c +++ b/hw/ppc/spapr_vio.c @@ -43,7 +43,16 @@ =20 #include =20 -static void spapr_vio_getset_irq(Object *obj, Visitor *v, const char *name, +static void spapr_vio_get_irq(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) +{ + Property *prop =3D opaque; + uint32_t *ptr =3D qdev_get_prop_ptr(DEVICE(obj), prop); + + visit_type_uint32(v, name, ptr, errp); +} + +static void spapr_vio_set_irq(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { Property *prop =3D opaque; @@ -57,8 +66,8 @@ static void spapr_vio_getset_irq(Object *obj, Visitor *v,= const char *name, =20 static const PropertyInfo spapr_vio_irq_propinfo =3D { .name =3D "irq", - .get =3D spapr_vio_getset_irq, - .set =3D spapr_vio_getset_irq, + .get =3D spapr_vio_get_irq, + .set =3D spapr_vio_set_irq, }; =20 static Property spapr_vio_props[] =3D { --=20 2.17.1