From nobody Tue Nov 4 19:03:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531101062735138.5779524752195; Sun, 8 Jul 2018 18:51:02 -0700 (PDT) Received: from localhost ([::1]:38879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcLKP-00084k-7n for importer@patchew.org; Sun, 08 Jul 2018 21:51:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcLJR-0007gU-Oi for qemu-devel@nongnu.org; Sun, 08 Jul 2018 21:50:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcLJN-0005Az-HX for qemu-devel@nongnu.org; Sun, 08 Jul 2018 21:50:01 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:37379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fcLJN-00059H-A0 for qemu-devel@nongnu.org; Sun, 08 Jul 2018 21:49:57 -0400 Received: by mail-pg1-x544.google.com with SMTP id n15-v6so924719pgv.4 for ; Sun, 08 Jul 2018 18:49:56 -0700 (PDT) Received: from cloudburst.twiddle.net (97-126-112-211.tukw.qwest.net. [97.126.112.211]) by smtp.gmail.com with ESMTPSA id i17-v6sm26399965pfj.95.2018.07.08.18.49.54 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 08 Jul 2018 18:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id; bh=szYqaav/NNMceNmIIJTLRwm7YWtwQ4ia65RQK6EI7m4=; b=Z6NI76zzMlJ7ypWhaRjyfWQjvt3HOQcFDOSKNjojLQCjUOxlTvDeuHphKY2AtDRqHu F9q1Qmo7AwteHl/6UiIlUEPc3TMNmXmuBJaQI+FCUwZO/tU6EcKCPNDCnWMNKQ647KbN MV6XibPqMjIhaRpYlckDT/bnMmeqAIpyFWV+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=szYqaav/NNMceNmIIJTLRwm7YWtwQ4ia65RQK6EI7m4=; b=Hx/yg6I63fn6O9qB9zdr+Ah6E+YWJMiIxAQ7K+J89SKUboA/2IV9YeqnIhttmM3lJm scps3ck+F5wnIfAORwweEllMSXXYHchsji5HA6hJXpkxoVo3bP9VR5XFJJ6gf50YmFhS +yPHrh7VYGgiA5Ql/+ofwoA3IwBkImmzF96J+xNQ7kUpMdRMzJe+FabBDQj1dB+9/85n zAdBpXC2lY+Ub8cYYjPt2CJ24zyfUx6cmKgL7eA92uYxSrA5A1tpiVvZw3Oqxbvyg4zN f47AwWc/4tTTO89P+Vd66ErJSdQiWKTyONL//A+29fVqMCRrpq+tzSLvoibqZ7BWhtOc EGcg== X-Gm-Message-State: APt69E1VVKmRJeOvyezTuIY52PqXVSKN2Ji5Gq+Kg3qrkKYTJe2D1MH9 HU3uywBX6pkg13c9PZigkqj4RleaweU= X-Google-Smtp-Source: AAOMgpeCxsKQzh5OlJRixliYYGsR37ERKmb3DRw+OfnoVkKcWgTuAjVoVD1KItqsyvRhii9xzo2gaA== X-Received: by 2002:a63:5c7:: with SMTP id 190-v6mr16793719pgf.385.1531100995403; Sun, 08 Jul 2018 18:49:55 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 8 Jul 2018 18:49:53 -0700 Message-Id: <20180709014953.26230-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 Subject: [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The error indicator for this syscall is -1, not 0. Signed-off-by: Richard Henderson Reviewed-by: Emilio G. Cota --- tests/tcg/multiarch/linux-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-t= est.c index e80eccc0ce..6d2c02c5c0 100644 --- a/tests/tcg/multiarch/linux-test.c +++ b/tests/tcg/multiarch/linux-test.c @@ -503,8 +503,9 @@ static void test_shm(void) =20 shmid =3D chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777)); ptr =3D shmat(shmid, NULL, 0); - if (!ptr) + if (ptr =3D=3D (void *)-1) { error("shmat"); + } =20 memset(ptr, 0, SHM_SIZE); =20 --=20 2.17.1