From nobody Tue Nov 4 21:38:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 153082150930452.06831461748118; Thu, 5 Jul 2018 13:11:49 -0700 (PDT) Received: from localhost ([::1]:54669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbAbU-0006Ib-H7 for importer@patchew.org; Thu, 05 Jul 2018 16:11:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbAYO-0004DT-CX for qemu-devel@nongnu.org; Thu, 05 Jul 2018 16:08:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbAYN-0002h6-Ek for qemu-devel@nongnu.org; Thu, 05 Jul 2018 16:08:36 -0400 Received: from mail-qt0-x235.google.com ([2607:f8b0:400d:c0d::235]:35422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fbAYN-0002gE-AH for qemu-devel@nongnu.org; Thu, 05 Jul 2018 16:08:35 -0400 Received: by mail-qt0-x235.google.com with SMTP id z6-v6so8191658qti.2 for ; Thu, 05 Jul 2018 13:08:35 -0700 (PDT) Received: from localhost.localdomain ([2804:431:f701:af73:9fee:2075:22ee:3d6b]) by smtp.gmail.com with ESMTPSA id 32-v6sm4418264qtf.13.2018.07.05.13.08.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Jul 2018 13:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xfm13l8uX9GZj8lMZ14pHe9rPLZ5LbrruxUtbqd2Hfg=; b=YpuPjrTAuQ2Tl+M7ZCtwxMXeUegavDx5IWC5IYNQCbof/GuMTTw/Ay+bRjFagJ7yA/ 89ya2FVc07soF4RK0koc9oDYSQqfCHlo4eE4gsRY6rB9/kLOjjGU7xNPRaB7D8nrxpPQ HjC8Uu/FudGxs/Ir/tLP683D0mW/aYhTYXVEaltu4dt++hJiz8WWLa8geDMfsOiR9HqJ 4h2JpErIqVCC2MbeTVu1/G/oDVaTS8K+zAKxYC2X/ruAXovRum4XzBg7n3ql304ZOH34 Gi0ic5PtftOxCbpslc18UQHznC1AEI0dquevqayBKWZ0/31ECct7Knszc5LPpP2D8aWF m9DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xfm13l8uX9GZj8lMZ14pHe9rPLZ5LbrruxUtbqd2Hfg=; b=e5fh9B0sLve2ek/n4bpGxnST5zwTKjOXk8mvucSnL18J2hlPapHBo+T/l9FrdzQMcA YYvYkp1eoj9ucTOhC2XN5//7ARNCpxboUvnHWxlAgfH7xyYsJvLfyiYBFMmb5GEnoBdN +TghQRpoq6MHSllWsYV6uPoLf/dxAbOV6I3fjVUpFE9wMC/eG1JRFzebn/Ym0GXNiFcf ztj846+EYkmARQdvd/UeG6ZF4eovE7+G01K09BobpQfGJMaqrDblYZz1n4tEM4kSRbll MP4xBASGp/h6V5SNpld1kIT4r3gem12Tr9Y39PJNZJq2J5N6eU+k0UAi7Tywd/3HFtxo EHqg== X-Gm-Message-State: APt69E1Q87cetavfug3K7PN9g73FsBx8Tco2Z/ONvjYNo5ecr7K+73I2 yujeuBFt1Xup7btoLu3OtsRcrBWU X-Google-Smtp-Source: AAOMgpcGGQYKWqRTbmVXuXtwC2OdFIQehwCjc2Uulvm0K6vHQsrKr6ClKkPYYegXF/49ecVuiFlXng== X-Received: by 2002:ac8:3477:: with SMTP id v52-v6mr6478507qtb.316.1530821314810; Thu, 05 Jul 2018 13:08:34 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Date: Thu, 5 Jul 2018 17:08:12 -0300 Message-Id: <20180705200813.2033-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180705200813.2033-1-danielhb413@gmail.com> References: <20180705200813.2033-1-danielhb413@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::235 Subject: [Qemu-devel] [PATCH v8 2/3] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, Daniel Henrique Barboza , ehabkost@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-current-machine' QMP command. Reported-by: Balamuruhan S Signed-off-by: Daniel Henrique Barboza Reviewed-by: Michael Roth --- qga/qapi-schema.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 17884c7c70..912e7505bd 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -565,9 +565,9 @@ # For the best results it's strongly recommended to have the pm-utils # package installed in the guest. # -# IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-ram. +# IMPORTANT: guest-suspend-ram requires working wakeup support in +# QEMU. You *must* check QMP command query-current-machine returns +# wakeup-suspend-support: true before issuing this command. # # This command does NOT return a response on success. There are two options # to check for success: @@ -592,9 +592,9 @@ # # This command requires the pm-utils package to be installed in the guest. # -# IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wak= eup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-hybrid. +# IMPORTANT: guest-suspend-hybrid requires working wakeup support in +# QEMU. You *must* check QMP command query-current-machine returns +# wakeup-suspend-support: true before issuing this command. # # This command does NOT return a response on success. There are two options # to check for success: --=20 2.17.1