From nobody Tue Nov 4 18:51:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530633042407279.9246201518331; Tue, 3 Jul 2018 08:50:42 -0700 (PDT) Received: from localhost ([::1]:41225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faNZV-0004l6-TE for importer@patchew.org; Tue, 03 Jul 2018 11:50:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faNMz-0002Mn-7I for qemu-devel@nongnu.org; Tue, 03 Jul 2018 11:37:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faNMw-0005GB-41 for qemu-devel@nongnu.org; Tue, 03 Jul 2018 11:37:33 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36014 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1faNMv-0005Ei-UZ for qemu-devel@nongnu.org; Tue, 03 Jul 2018 11:37:30 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 81AAADFDF for ; Tue, 3 Jul 2018 15:37:29 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-126.ams2.redhat.com [10.36.116.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41CF220180EB for ; Tue, 3 Jul 2018 15:37:29 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 23FA11132F3C; Tue, 3 Jul 2018 17:37:28 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 3 Jul 2018 17:36:58 +0200 Message-Id: <20180703153728.2175-3-armbru@redhat.com> In-Reply-To: <20180703153728.2175-1-armbru@redhat.com> References: <20180703153728.2175-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 03 Jul 2018 15:37:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 03 Jul 2018 15:37:29 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'armbru@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PULL 02/32] monitor: Spell "I/O thread" consistently in comments X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <20180703085358.13941-3-armbru@redhat.com> --- monitor.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/monitor.c b/monitor.c index 208d7c7cfd..4f4f309d45 100644 --- a/monitor.c +++ b/monitor.c @@ -243,7 +243,7 @@ struct Monitor { /* Let's add monitor global variables to this struct. */ static struct { IOThread *mon_iothread; - /* Bottom half to dispatch the requests received from IO thread */ + /* Bottom half to dispatch the requests received from I/O thread */ QEMUBH *qmp_dispatcher_bh; /* Bottom half to deliver the responses back to clients */ QEMUBH *qmp_respond_bh; @@ -518,7 +518,7 @@ static void monitor_json_emitter(Monitor *mon, QObject = *data) { if (mon->use_io_thr) { /* - * If using IO thread, we need to queue the item so that IO + * If using I/O thread, we need to queue the item so that I/O * thread will do the rest for us. Take refcount so that * caller won't free the data (which will be finally freed in * responder thread). @@ -529,7 +529,7 @@ static void monitor_json_emitter(Monitor *mon, QObject = *data) qemu_bh_schedule(mon_global.qmp_respond_bh); } else { /* - * If not using monitor IO thread, then we are in main thread. + * If not using monitor I/O thread, then we are in main thread. * Do the emission right away. */ monitor_json_emitter_raw(mon, data); @@ -1269,7 +1269,7 @@ static void qmp_caps_check(Monitor *mon, QMPCapabilit= yList *list, if (!mon->use_io_thr) { /* * Out-of-band only works with monitors that are - * running on dedicated IOThread. + * running on dedicated I/O thread. */ error_setg(errp, "This monitor does not support " "out-of-band (OOB)"); @@ -4403,7 +4403,7 @@ int monitor_suspend(Monitor *mon) =20 if (monitor_is_qmp(mon)) { /* - * Kick iothread to make sure this takes effect. It'll be + * Kick I/O thread to make sure this takes effect. It'll be * evaluated again in prepare() of the watch object. */ aio_notify(iothread_get_aio_context(mon_global.mon_iothread)); @@ -4422,7 +4422,7 @@ void monitor_resume(Monitor *mon) if (atomic_dec_fetch(&mon->suspend_cnt) =3D=3D 0) { if (monitor_is_qmp(mon)) { /* - * For QMP monitors that are running in IOThread, let's + * For QMP monitors that are running in I/O thread, let's * kick the thread in case it's sleeping. */ if (mon->use_io_thr) { @@ -4446,7 +4446,7 @@ static QObject *get_qmp_greeting(Monitor *mon) =20 for (cap =3D 0; cap < QMP_CAPABILITY__MAX; cap++) { if (!mon->use_io_thr && cap =3D=3D QMP_CAPABILITY_OOB) { - /* Monitors that are not using IOThread won't support OOB */ + /* Monitors that are not using I/O thread won't support OOB */ continue; } qlist_append_str(cap_list, QMPCapability_str(cap)); @@ -4587,9 +4587,9 @@ static void monitor_iothread_init(void) NULL); =20 /* - * Unlike the dispatcher BH, this must be run on the monitor IO - * thread, so that monitors that are using IO thread will make - * sure read/write operations are all done on the IO thread. + * Unlike the dispatcher BH, this must be run on the monitor I/O + * thread, so that monitors that are using I/O thread will make + * sure read/write operations are all done on the I/O thread. */ mon_global.qmp_respond_bh =3D aio_bh_new(monitor_get_aio_context(), monitor_qmp_bh_responder, @@ -4661,7 +4661,7 @@ static void monitor_qmp_setup_handlers_bh(void *opaqu= e) if (mon->use_io_thr) { /* * When use_io_thr is set, we use the global shared dedicated - * IO thread for this monitor to handle input/output. + * I/O thread for this monitor to handle input/output. */ context =3D monitor_get_io_context(); /* We should have inited globals before reaching here. */ @@ -4718,7 +4718,7 @@ void monitor_init(Chardev *chr, int flags) /* * We can't call qemu_chr_fe_set_handlers() directly here * since during the procedure the chardev will be active - * and running in monitor iothread, while we'll still do + * and running in monitor I/O thread, while we'll still do * something before returning from it, which is a possible * race too. To avoid that, we just create a BH to setup * the handlers. @@ -4745,16 +4745,16 @@ void monitor_cleanup(void) Monitor *mon, *next; =20 /* - * We need to explicitly stop the iothread (but not destroy it), - * cleanup the monitor resources, then destroy the iothread since + * We need to explicitly stop the I/O thread (but not destroy it), + * cleanup the monitor resources, then destroy the I/O thread since * we need to unregister from chardev below in * monitor_data_destroy(), and chardev is not thread-safe yet */ iothread_stop(mon_global.mon_iothread); =20 /* - * After we have IOThread to send responses, it's possible that - * when we stop the IOThread there are still replies queued in the + * After we have I/O thread to send responses, it's possible that + * when we stop the I/O thread there are still replies queued in the * responder queue. Flush all of them. Note that even after this * flush it's still possible that out buffer is not flushed. * It'll be done in below monitor_flush() as the last resort. @@ -4770,7 +4770,7 @@ void monitor_cleanup(void) } qemu_mutex_unlock(&monitor_lock); =20 - /* QEMUBHs needs to be deleted before destroying the IOThread. */ + /* QEMUBHs needs to be deleted before destroying the I/O thread */ qemu_bh_delete(mon_global.qmp_dispatcher_bh); mon_global.qmp_dispatcher_bh =3D NULL; qemu_bh_delete(mon_global.qmp_respond_bh); --=20 2.17.1