From nobody Tue Nov 4 19:01:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530544411888582.8176532645665; Mon, 2 Jul 2018 08:13:31 -0700 (PDT) Received: from localhost ([::1]:33450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa0W8-0005gp-33 for importer@patchew.org; Mon, 02 Jul 2018 11:13:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa0TV-0003pF-D1 for qemu-devel@nongnu.org; Mon, 02 Jul 2018 11:10:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa0TS-0007h0-Ux for qemu-devel@nongnu.org; Mon, 02 Jul 2018 11:10:45 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:44243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fa0TS-0007fw-7b for qemu-devel@nongnu.org; Mon, 02 Jul 2018 11:10:42 -0400 Received: by mail-pf0-x241.google.com with SMTP id j3-v6so7649652pfh.11 for ; Mon, 02 Jul 2018 08:10:41 -0700 (PDT) Received: from localhost (g90.124-44-6.ppp.wakwak.ne.jp. [124.44.6.90]) by smtp.gmail.com with ESMTPSA id r77-v6sm10576728pfr.117.2018.07.02.08.10.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jul 2018 08:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4kKcrKeV9F/Qdu736T7k95sF9L6dvtl4xdV9jCWRIzA=; b=mkZZzp2QMR4H1414eG/tss32R32uqpmxVJ01FqgwqnpukfWqeO6qTLCMw5/f1FMIV4 pkuWXy8GgvaNmc7rV9PODdvHzB8Nes7yDXzQCutPbPDTTqWLz4KOXo642zmGzSO6Q1fI GLu0dJ3W6dU2OhVI1m8X0w7gSs/H2OdTY6WR1Fku2OGc36wuk4KMRFQzsujOjwimDCUR MCLaP9SIvghwIOPpHvmREfGoWr92HMR30zmlOcK/SQbeO29NXhhoT91yzP2U8Zc7Ard5 DPq9Tv8Iez0qsGvGHQrvwEIrf7M6Ftjc+TnMH/iYLh1BCIBvF+BqZM/gicHOhXvrCA8K 47bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4kKcrKeV9F/Qdu736T7k95sF9L6dvtl4xdV9jCWRIzA=; b=A5s11o0+GbB9Qz18sHomht1086TwgrbmzLwx7hlbjtnJV90+/hZUxmhnmCLOYrEDog RliNA9V+rsoRJtirrhMp7n12CeFvJlBnvgxIhdqqHy6frj43B0We55rfjcqcAGqthB26 BGnOzM6ovqDU+d6jCx16lemPtTS7omo89jjevfbn79BCEFHup4iKN7d6/dOFQBv/Bqv5 eaHnZVSyKMfSaqGGqlAoKelNVmk7Rbb/uyFbikk7IMcEyxTU9Qm0cfVxPDneQcEGocry 5bm9rHHDMXD3EuZOwiVe4KDnOuPWOvq+x1muAexx9Yc8Gw+hSNXNsQr/T79+2dEPVszn wubQ== X-Gm-Message-State: APt69E3JBEsp7fu1Km5/X+JDdz8Jy98RFKrX/SmkLbvsyPk4EjZxNzdF 9RqqG+fKplrGN2/Jk4QvSRI= X-Google-Smtp-Source: AAOMgpczaSc+voeIj/0gfHF/in1KT4sIKUiICzKDKv2VV+U2nwl6VuVubRKmtLjZd9tvLEUMTVXFzQ== X-Received: by 2002:a62:57dc:: with SMTP id i89-v6mr13777076pfj.65.1530544241199; Mon, 02 Jul 2018 08:10:41 -0700 (PDT) From: Stafford Horne To: Peter Maydell Date: Tue, 3 Jul 2018 00:09:59 +0900 Message-Id: <20180702151023.24532-2-shorne@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180702151023.24532-1-shorne@gmail.com> References: <20180702151023.24532-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PULL v2 01/25] target/openrisc: Fix mtspr shadow gprs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stafford Horne , Richard Henderson , QEMU Development Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Richard Henderson Missing break when this feature was added in 89e71e873d ("target/openrisc: implement shadow registers"). This was causing strange issues as we get writes into the translation block jump cache and other bits of state. Fixes: 89e71e873d ("target/openrisc: implement shadow registers") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson Signed-off-by: Stafford Horne --- target/openrisc/sys_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c index b284064381..2f337363ec 100644 --- a/target/openrisc/sys_helper.c +++ b/target/openrisc/sys_helper.c @@ -98,6 +98,7 @@ void HELPER(mtspr)(CPUOpenRISCState *env, case TO_SPR(0, 1024) ... TO_SPR(0, 1024 + (16 * 32)): /* Shadow GPRs */ idx =3D (spr - 1024); env->shadow_gpr[idx / 32][idx % 32] =3D rb; + break; =20 case TO_SPR(1, 512) ... TO_SPR(1, 512+DTLB_SIZE-1): /* DTLBW0MR 0-127 = */ idx =3D spr - TO_SPR(1, 512); --=20 2.17.0