From nobody Wed Nov 5 08:47:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530541971776342.1821376973244; Mon, 2 Jul 2018 07:32:51 -0700 (PDT) Received: from localhost ([::1]:33149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZzsj-0006WQ-1r for importer@patchew.org; Mon, 02 Jul 2018 10:32:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZzqW-0005M0-AM for qemu-devel@nongnu.org; Mon, 02 Jul 2018 10:30:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZzqV-0000RZ-7B for qemu-devel@nongnu.org; Mon, 02 Jul 2018 10:30:28 -0400 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]:33806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZzqU-0000R1-SH for qemu-devel@nongnu.org; Mon, 02 Jul 2018 10:30:27 -0400 Received: by mail-wr0-x230.google.com with SMTP id a12-v6so15791266wro.1 for ; Mon, 02 Jul 2018 07:30:26 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id b190-v6sm10545942wma.24.2018.07.02.07.30.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jul 2018 07:30:23 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id EAAC23E06DE; Mon, 2 Jul 2018 15:30:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5YJQD6mVsHQ+y4JfkIGsYKr2KX19OUMuNv1hJuaEJwQ=; b=Rx6vbZb7lmWm25d+Ips4mPMEpipLATKjvnSu9lSi6zBXIMerOGanczk5LrEMRLGWZ8 7oXwxjCQsE6+tciSC9SSfuTfyzQDqd4WBCsZdDQ77czPBr3fI4lChz0XIW3swRzmTU7e dy/F3OqsKUkeifxLp9wmxy93pW/CKAAWklLB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5YJQD6mVsHQ+y4JfkIGsYKr2KX19OUMuNv1hJuaEJwQ=; b=W5/A/tDG00u5nfUckRZG0cR4fWL2cHP1OBvXOuatlpDJ+rJRvQAtHDmcNa5pDnyIxb A6hxS9j13hoNv+QUp4SvOQ1aQVlUQ93R6VguPqRXcoDX9e/WdKg8FlrAd6PGcZmoq448 tPXrxO5iG/ReTy8PUnvnjMEEmEpemlJSPvh4yQlkJu3HjlUcNYCjwGg/VyTI7BOGgd/V mfe77Re1S1b9fHo9ELsxUUS5KKExuVy7QJ9X5u9SbjLif+JNNaplQbP0MTQ08T46GOfN 3JhZYr+3uBBjdo/2hEVkz7xQsvba1uzyY5cbXX3BfkNAeL9uwt3g947FzOodn85njPUs ydqw== X-Gm-Message-State: APt69E3rs2PvFqgr8C1sSqpqGsrrDIjvd2AWxKUqTisnk9bbvou8Bwva banMXbaYov+HKzsEBCPsN56WqQ== X-Google-Smtp-Source: AAOMgpfULTV4cxQN1BGw1GUkYrNQNQImKE3IILt+tT6+njneXUjiEM64uhprLlRm8WuGGIhXpYIgUA== X-Received: by 2002:adf:8162:: with SMTP id 89-v6mr12459648wrm.192.1530541825731; Mon, 02 Jul 2018 07:30:25 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Mon, 2 Jul 2018 15:30:04 +0100 Message-Id: <20180702143021.18864-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180702143021.18864-1-alex.bennee@linaro.org> References: <20180702143021.18864-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::230 Subject: [Qemu-devel] [PATCH v3 03/20] build-system: remove per-test GCOV reporting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/devel/testing.rst | 11 +++++------ tests/Makefile.include | 10 ---------- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index f33e5a8423..66ef219f69 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -158,12 +158,11 @@ rarely used. See "QEMU iotests" section below for mor= e information. GCC gcov support ---------------- =20 -``gcov`` is a GCC tool to analyze the testing coverage by instrumenting the -tested code. To use it, configure QEMU with ``--enable-gcov`` option and b= uild. -Then run ``make check`` as usual. There will be additional ``gcov`` output= as -the testing goes on, showing the test coverage percentage numbers per anal= yzed -source file. More detailed reports can be obtained by running ``gcov`` com= mand -on the output files under ``$build_dir/tests/``, please read the ``gcov`` +``gcov`` is a GCC tool to analyze the testing coverage by +instrumenting the tested code. To use it, configure QEMU with +``--enable-gcov`` option and build. Then run ``make check`` as usual. +Reports can be obtained by running ``gcov`` command on the output +files under ``$build_dir/tests/``, please read the ``gcov`` documentation for more information. =20 QEMU iotests diff --git a/tests/Makefile.include b/tests/Makefile.include index e8bb2d8f66..756474814a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -891,26 +891,16 @@ GCOV_OPTIONS =3D -n $(if $(V),-f,) =20 .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-so= ftmmu $(check-qtest-y) - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=3D$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=3Dqemu-img$(EXESUF) \ MALLOC_PERTURB_=3D$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=3D$(SPEED) $(check-qtest-$*-y) $(check-qte= st-generic-y),"GTESTER","$@") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y) $(gcov-files-generic-y);= do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) =20 .PHONY: $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)) $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: % - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command, \ MALLOC_PERTURB_=3D$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=3D$(SPEED) $*,"GTESTER","$*") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y) $(gcov-= files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) =20 # gtester tests with XML output =20 --=20 2.17.1