From nobody Sun Feb 8 06:55:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 153054090357420.30065123103634; Mon, 2 Jul 2018 07:15:03 -0700 (PDT) Received: from localhost ([::1]:33032 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZzba-00067B-Ou for importer@patchew.org; Mon, 02 Jul 2018 10:15:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZzMK-00030T-DP for qemu-devel@nongnu.org; Mon, 02 Jul 2018 09:59:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZzMJ-0008Uk-K8 for qemu-devel@nongnu.org; Mon, 02 Jul 2018 09:59:16 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:42963) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZzMJ-0008UY-Di for qemu-devel@nongnu.org; Mon, 02 Jul 2018 09:59:15 -0400 Received: by mail-pg0-x244.google.com with SMTP id c10-v6so7196214pgu.9 for ; Mon, 02 Jul 2018 06:59:15 -0700 (PDT) Received: from localhost (g90.124-44-6.ppp.wakwak.ne.jp. [124.44.6.90]) by smtp.gmail.com with ESMTPSA id y2-v6sm39862158pfa.43.2018.07.02.06.59.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Jul 2018 06:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vsPXNhn1H9gcv6Y3Ui8gTd5nIvqvpy28NrTKCozPLdA=; b=atFWKgzsp4HlaLphFS3X+4k56zSsxfniEo/D9eJg0vkjGCmsdePjZNbt6x49SRsZE9 fZpFszljHvPTZhr1Dxjzocd6tenomApC38DJQa9NlpKaxbOmFIX2+lqqaZbt+12RfciH BZV36bAwz2i9w2DsppdeoIsfZLaHuRfQzUWZj8fPGZtlACogEV37v3RZ3EqKk6bajCGV d7B5Z9uh+AKlJTKix/d8esZhXkIcEzEfgEHZvdRrzCdo33awbn8qgMI0Ee7QfNm0aogD 6GEmLxQzDPSCvsC14v4C2u3w4tqN/nWNeZTlWlx/ItInwhBD6iWucaujSPe7Ni4rnVsl Gm8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vsPXNhn1H9gcv6Y3Ui8gTd5nIvqvpy28NrTKCozPLdA=; b=I1S+dI4tbI2HRV6eiJWM7jV5G1u89DGJsAEyS1L4JMkxLdTqXoGwz9eht5gsty26g1 ztEo/UC4Bj2/rxKqkwqjsKbr2KkLP3o/3wrWqvyWEQXQ/fl3PLF4waQfMMlNONjm/6YI fiAzrLb/ZfcICPIKh0RIc5/6CW/kZCD3D8Quu1TfIbjKbbqPy2gJJYA22FsZ6kRi2+U7 /OL2yO5oD7X9fSXwToDchWTS4aypHXu/c0BwBQS3utx4XPer5xG8udPGpSG9rqjGJuMf aTa3ibTKS8ma5JyCk1/6VgyiIUYNfB1uxAme4+w/Of4W5euPV101TwiRRwXLehsgHmni KjdA== X-Gm-Message-State: APt69E3r/p63LFcuEcFMQbiqBZd+xsr5R/uVZ3lZwvD8E6oymEC7HpCU Sg3gc3l6fAK71J7mJ5vGR60= X-Google-Smtp-Source: AAOMgpfvHQXyju/KAY6xhp5qD21CZ0KK4IE/qyr2G1EiceOWrQZufjnDk9h3nys2vBDjwD4ifX95lQ== X-Received: by 2002:a62:33c4:: with SMTP id z187-v6mr25671026pfz.190.1530539954506; Mon, 02 Jul 2018 06:59:14 -0700 (PDT) From: Stafford Horne To: Peter Maydell Date: Mon, 2 Jul 2018 22:58:06 +0900 Message-Id: <20180702135806.7087-26-shorne@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180702135806.7087-1-shorne@gmail.com> References: <20180702135806.7087-1-shorne@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PULL 25/25] target/openrisc: Fix writes to interrupt mask register X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stafford Horne , QEMU Development Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The interrupt controller mask register (PICMR) allows writing any value to any of the 32 interrupt mask bits. Writing a 0 masks the interrupt writing a 1 unmasks (enables) the the interrupt. For some reason the old code was or'ing the write values to the PICMR meaning it was not possible to ever mask a interrupt once it was enabled. I have tested this by running linux 4.18 and my regular checks, I don't see any issues. Reported-by: Davidson Francis Reviewed-by: Richard Henderson Signed-off-by: Stafford Horne --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c index 541615bfb3..b66a45c1e0 100644 --- a/target/openrisc/sys_helper.c +++ b/target/openrisc/sys_helper.c @@ -142,7 +142,7 @@ void HELPER(mtspr)(CPUOpenRISCState *env, target_ulong = spr, target_ulong rb) } break; case TO_SPR(9, 0): /* PICMR */ - env->picmr |=3D rb; + env->picmr =3D rb; break; case TO_SPR(9, 2): /* PICSR */ env->picsr &=3D ~rb; --=20 2.17.0