From nobody Tue Nov 4 18:44:28 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530340177327865.8264158872511; Fri, 29 Jun 2018 23:29:37 -0700 (PDT) Received: from localhost ([::1]:45761 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ9O4-0003Y5-Bo for importer@patchew.org; Sat, 30 Jun 2018 02:29:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ96a-0004h5-Mk for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZ96Z-0003Bj-AL for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:32 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:37052) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZ96Z-0003Ag-3t for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:31 -0400 Received: by mail-wr0-x244.google.com with SMTP id k6-v6so10646645wrp.4 for ; Fri, 29 Jun 2018 23:11:31 -0700 (PDT) Received: from donizetti.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 24-v6sm563454wrz.94.2018.06.29.23.11.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Jun 2018 23:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=IGrPoG3FW8cCCf11OQa8mry+HXSemCrvfnZ4MxPIbBg=; b=uuYoqLlSYBkqK+h03h86kN9ZwKlATM7opKVnCAiwrYeAd+bVM/4iqNLKXX6NKpBZP1 vXNeIn+DegRswknrcmFEDh82RXf3K8ODfmscfZhatUSn1/H91uu2ZB7Cj5QuHzkl+AKP 3aK18viHmoUhtzBDcRCRINXebWH+c7+I7N/b10eGjsUVERD7S9PBmY3/QSKOsdNhdY25 QjbuX1gUJD/SvL0Va8Rqq401LPIOLI8onVTfRmjNEeLMIv8K/syLJ9jYFEw9ADsko8Tv bSHlpiRQ4x0qlBaFIQNtoKfI6B/a5NOeYHWFbgUS0xdT910VLR49ROMCwcqL3kGo62h0 CXJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=IGrPoG3FW8cCCf11OQa8mry+HXSemCrvfnZ4MxPIbBg=; b=VSI0LjBED44yfyqojXooyU+8T+WmqYUC1Y7RpZZmv5zJphlQZgBhRhRXwGzf8YFBQU kHviia/khreFMdksrx8afKvOpvQELuDoZfdnGtNqs8BgrPKYnkfNpCUGIzTOFFNxn55P AgF8hmBTp3nPgfqq7IpXA4Vcj+XcqtFQ8NureKQfjT9ra89uN1A30OgpI5V3fcJQjnUF n7G2AeWydDCJZSv7b4SvTC2aHfKRzOPRi9j6/nB5thjvPW4GjfwiOsllirpczJgYuqlB ahbyLne1tr5Mt118RWlDoNOr0+HwHDDhymb1eaBYWFY+3HyexgXn0rQJtVZr1EjMNrRp zyXA== X-Gm-Message-State: APt69E1fyQ92PIilyloRXm1b+DwDEkQeYl0DqFgq8Wa9Fn7H0oNySIRc iRvozcHjT+ukBO471NoyKGZSHziU X-Google-Smtp-Source: AAOMgpdSzowDUYIcmBMMVRjirrLtlCfx3MoCj3yUmTvoGSnZIe48wKDLRqlWpEmLy7h+CvGu3ejlzQ== X-Received: by 2002:a5d:6841:: with SMTP id o1-v6mr974782wrw.159.1530339090002; Fri, 29 Jun 2018 23:11:30 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 30 Jun 2018 08:10:40 +0200 Message-Id: <20180630061040.6018-48-pbonzini@redhat.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180630061040.6018-1-pbonzini@redhat.com> References: <20180630061040.6018-1-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PULL 47/47] serial: Open non-block X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" On a real serial device, the open can block if the handshake lines are in a particular state. If a QEMU is passing the serial device to the guest, the QEMU startup is blocked opening the device (with a symptom seen as a timeout from libvirt). Open the serial port with O_NONBLOCK. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- chardev/char-serial.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chardev/char-serial.c b/chardev/char-serial.c index ae548d2..3299b46 100644 --- a/chardev/char-serial.c +++ b/chardev/char-serial.c @@ -265,7 +265,8 @@ static void qmp_chardev_open_serial(Chardev *chr, ChardevHostdev *serial =3D backend->u.serial.data; int fd; =20 - fd =3D qmp_chardev_open_file_source(serial->device, O_RDWR, errp); + fd =3D qmp_chardev_open_file_source(serial->device, O_RDWR | O_NONBLOC= K, + errp); if (fd < 0) { return; } --=20 1.8.3.1