From nobody Tue Nov 4 19:05:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530341432650557.3609013451143; Fri, 29 Jun 2018 23:50:32 -0700 (PDT) Received: from localhost ([::1]:45872 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ9iJ-0004ze-WC for importer@patchew.org; Sat, 30 Jun 2018 02:50:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ96V-0004bc-LF for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZ96U-000327-P7 for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:27 -0400 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:55238) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZ96U-000301-He for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:26 -0400 Received: by mail-wm0-x235.google.com with SMTP id i139-v6so4086173wmf.4 for ; Fri, 29 Jun 2018 23:11:26 -0700 (PDT) Received: from donizetti.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 24-v6sm563454wrz.94.2018.06.29.23.11.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Jun 2018 23:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ARq/V/dSaQxoVfNeWVtFlk/ywnpP5riWQa6n8cn6FzU=; b=JYQSBaBqR1N+0JXSQqrQs71N2VjF995ShwoB8cx+J8DCFgXFAMWg+XE8EzKVgoB/GU N5pZ2aagyKGI5ZNkv3RtgPoehaWyHJzTtcRKilssAP/xEm97QNo9iPXmIQH0witIWr7F f9Rqhlz2nHyon03lR3h4Sd7jTSjVLhE/4hR0t/QWmZelx1zdYXOZznyvbNbXacJSrdmN TMwjfXPiKr9oItriZ/oqP40swHcC0PpArSRe2sG85ClrKuvSV+zpIRgxoSGerDqrPIyJ k2m8s8FCB3SBbIbd5xQF2OY5muZCfDSO2KMVLxzTedzkkrlUQKDxCwwSDK/fuaoz6s0n Niyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ARq/V/dSaQxoVfNeWVtFlk/ywnpP5riWQa6n8cn6FzU=; b=Nz6lVdq4GD2N6H2fKnFX8UDLEYC3RFOIeUPK5y3mFhpg9N5zwxaMY2gTZUUhBZl/0s BrGPEC8EBrsUgE/YasYnKGd72boOy74rCibObr/zfl5CLBNv8urLSvlBgDLXUpkj36Ct WVfUJALahlDpgxckANcfq7EjmouL+rMAInX5vrdDc9qo1ijp8d6fKlRJT/imNY627B8L 5JHLyLtDgzIZoc9b8vRmaaYjEXQA5opaK5fNq8EqMOCVRdmj+b0i+Q2ytJ/v0sSOmIp7 Bpea7nZJMBMN+EkQqkVJrlMJYek1CmDR6R7LLjCFLUZoNnlBN7OF5NMtGyWkzxUc/zKK YZEw== X-Gm-Message-State: APt69E19YlC9155WyyxDuMxqVcZG7/JnwB8MLlCK+MMmZSSzKeeIJNW4 f4MJC24gf6aZrXoYoCqeKjd6fDsT X-Google-Smtp-Source: AAOMgpfjeuWKniNGAi0gMhX1pWPX9xufJZ+Up0eH1RperwF6ZNmdw01gFbT0Zs1RtE0ZOj87LiZZ7A== X-Received: by 2002:a1c:7d47:: with SMTP id y68-v6mr3369876wmc.62.1530339085440; Fri, 29 Jun 2018 23:11:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 30 Jun 2018 08:10:35 +0200 Message-Id: <20180630061040.6018-43-pbonzini@redhat.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180630061040.6018-1-pbonzini@redhat.com> References: <20180630061040.6018-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::235 Subject: [Qemu-devel] [PULL 42/47] monitor: Use the IEC binary prefix definitions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Philippe Mathieu-Daud=C3=A9 It eases code review, unit is explicit. Patch generated using: $ git grep -n '[<>][<>]=3D ?[1-5]0' and modified manually. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20180625124238.25339-43-f4bug@amsat.org> Signed-off-by: Paolo Bonzini --- monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 0988eb4..61b727a 100644 --- a/monitor.c +++ b/monitor.c @@ -23,6 +23,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/units.h" #include #include "cpu.h" #include "hw/hw.h" @@ -3288,7 +3289,7 @@ static QDict *monitor_parse_arguments(Monitor *mon, monitor_printf(mon, "enter a positive value\n"); goto fail; } - val <<=3D 20; + val *=3D MiB; } qdict_put_int(qdict, key, val); } --=20 1.8.3.1