From nobody Tue Nov 4 18:42:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530339176038690.1459670087404; Fri, 29 Jun 2018 23:12:56 -0700 (PDT) Received: from localhost ([::1]:45672 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ97m-0005Il-NS for importer@patchew.org; Sat, 30 Jun 2018 02:12:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ95t-0003yK-KU for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:10:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZ95q-0001dH-0j for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:10:49 -0400 Received: from mail-wr0-x233.google.com ([2a00:1450:400c:c0c::233]:32913) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZ95p-0001cg-Pn for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:10:45 -0400 Received: by mail-wr0-x233.google.com with SMTP id k7-v6so7155239wrq.0 for ; Fri, 29 Jun 2018 23:10:45 -0700 (PDT) Received: from donizetti.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 24-v6sm563454wrz.94.2018.06.29.23.10.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Jun 2018 23:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=coHajTCOCs23/c7nuCpHVys0kHiQe1h4+kDa2qCsFXU=; b=ChWxa9KF8XcQVWCWzAuDQucnRA8ySlPv8ss2Bsugy8bG6kqeS5nwmZywowZUDcdoYB GO2O7mJ8FzSqmdq7w/x/Fi97xhrvXaFPWqyxlH6KDUjKPVx/C/oxSguRBh9U7DX3wflR Fzl+++CQTJ3QikZQ5c8q7YNrKhIAd6gmFPd+8LDxYK1Fx5cdwk3ttsRmZ5vkea96o4Yh g5n92qWL/TFLzsphkxk/JRWUDvWr9455Xxz0lPPA/YEeoBTzjlvIEbjzMbQ9jZM67v3B drYW2koTy5Xf8IoyJWnkVJzC3iomlW8oYchX/pCGPYthL10rVS5aOXDKNVZoT4Izw+A/ VyOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=coHajTCOCs23/c7nuCpHVys0kHiQe1h4+kDa2qCsFXU=; b=aFDsIRqDgldpXeswpYKZkMH4KGX3rV65NBHEdLGTDXW4AMGU4JZ4+chfQE3sEVXIEG r6gdSZeyX3AB5AHEYyAQu5k62MqaCN5Ayg9aWCZCjg+DshXV33Q5wTWaY904cLbebypc EffVGUjMwn/XCugMn2Kpo/MhWnoHSOYD5Keodk+2k8M88Bh+HCXzkrSQZVh5DRtLfMMu ufJYkfeSzninZOT9SeSF9rN+p30XtNtlZ3cMMmKANfYdl6IlxQpDQH6GtYO3IKHHjTFI bfWK6bczQqEFmtBAik8OOpMORjr6O5ddsgboBYgQ/PgszEkGw2xXqkUPr9ZdlBvfQ8g7 lj3g== X-Gm-Message-State: APt69E1gOroRyGbEDVaUWV4WcmIQW4+YwlE0hhwjGMaTAJojehjrbGI0 tHixrn5IZNoDPoVMs7bHPXqkQSOq X-Google-Smtp-Source: AAOMgpchcgV37XY0MZ8O/fINGL3WKhd5kG+PSqx2qRwazqHhsyb/pDiTo1EID0pEve9WNB1hseN5MA== X-Received: by 2002:adf:8345:: with SMTP id 63-v6mr14439725wrd.37.1530339044579; Fri, 29 Jun 2018 23:10:44 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 30 Jun 2018 08:09:55 +0200 Message-Id: <20180630061040.6018-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180630061040.6018-1-pbonzini@redhat.com> References: <20180630061040.6018-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::233 Subject: [Qemu-devel] [PULL 02/47] configure: add sanity check to catch builds from "git archive" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Daniel P. Berrang=C3=A9 The "git archive" feature creates tarballs which are missing all submodule content. GitHub unhelpfully provides users with "Download" links that claim to give them valid source release tarballs. These GitHub archives will not be buildable as they are created by the "git archive" feature and so are missing content. The user gets unhelpful messages from make such as: fatal error: ui/input-keymap-atset1-to-qcode.c: No such file or directory By adding a sanity check we can give users an informative message about what they've done wrong. Signed-off-by: Daniel P. Berrang=C3=A9 Message-Id: <20180418171151.5263-1-berrange@redhat.com> Reviewed-by: Cornelia Huck Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Paolo Bonzini --- configure | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/configure b/configure index ca7de4f..4b489fe 100755 --- a/configure +++ b/configure @@ -300,6 +300,24 @@ then else git_update=3Dno git_submodules=3D"" + + if ! test -f "$source_path/ui/keycodemapdb/README" + then + echo + echo "ERROR: missing file $source_path/ui/keycodemapdb/README" + echo + echo "This is not a GIT checkout but module content appears to" + echo "be missing. Do not use 'git archive' or GitHub download link= s" + echo "to acquire QEMU source archives. Non-GIT builds are only" + echo "supported with source archives linked from:" + echo + echo " https://www.qemu.org/download/" + echo + echo "Developers working with GIT can use scripts/archive-source.s= h" + echo "if they need to create valid source archives." + echo + exit 1 + fi fi git=3D"git" =20 --=20 1.8.3.1