From nobody Tue Nov 4 18:42:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530340228014148.68787845282145; Fri, 29 Jun 2018 23:30:28 -0700 (PDT) Received: from localhost ([::1]:45764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ9Oo-0004hu-3S for importer@patchew.org; Sat, 30 Jun 2018 02:30:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ96E-0004JB-Vx for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZ96D-0002E4-M0 for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:10 -0400 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:54093) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZ96D-0002Bm-Du for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:09 -0400 Received: by mail-wm0-x22c.google.com with SMTP id b188-v6so4122502wme.3 for ; Fri, 29 Jun 2018 23:11:09 -0700 (PDT) Received: from donizetti.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 24-v6sm563454wrz.94.2018.06.29.23.11.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Jun 2018 23:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xeDgZqYaPf77uGnNivk4MfAuwpcK4p81HkrHzCpOAc0=; b=rPK57ef0/Ud43vVmnoWKKRZzlv1PHRQ0ZouBc4cW2NXHvPGJ6TnkjcvGrGadV8xSz8 c4bbOg0msMKcENv345eQPnMwz5hmFXa45ZfJbHdOW2p0QP8mer4uGyC24P6CqTpTOEfm xUTfzZNHrjSsSuu2vIIFrbIhYfN9zzp892v82oKhYzxmLxfrVdGTmQkScbN6AEHBgVWL jVq1Z/8b9nbYix6J16XMWZKJk9qArkq0kPD+41iGm984YCoddxwf3jS2ZSO9da8mzNKI KJJLWm8KfIjQRzdS7hz8ejI0srsF2z3KhKwpgCZlid9Mou28c+dNatUDqIjQYO5EwFZj s+lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=xeDgZqYaPf77uGnNivk4MfAuwpcK4p81HkrHzCpOAc0=; b=uV9hsdIltluajuzgKzElV4ypnZYzI9p6ifaJzqiZU5DAVoJl/gVoQyZOwVZ9+wgNor H4VEUvTVbgwqBR7G5J72bGXZhL3+OCYBJKv7/Kgelj98JAPd3TeWcJbx8YzYYjZh5FfA D1sxy+XmBD1TQm1/4MAcJsKG+Zo+3sGsVlKMqRaLItguLaFR56K9ZCtfEZEqiJ5Tb9jq QcsMNxmW1OGFAOOgMfYIi2j5uGQsNDi6heJO+JjVn1V24RfmHlDPxX35fPZiBXkB5+j6 fg7H0nJJNEK+/FtUSMaY2/7rDKjy+UBDfsRO6afwl8d0/Hm9SnXjthjIcNRmyf+UdZMe wYEw== X-Gm-Message-State: APt69E2w4HaHfzy/SOeGj6QSV87kK1MRHrY5ktGzhhfevf0ENyw0AY20 V9Jhb5guprve9iMb4iNnyq7ARYms X-Google-Smtp-Source: AAOMgpdsI4eQ5IXI5OzmxSx6pjzV0uOcRMamnN3badx54Ba72lzkePcjI8y7u3cx2PjMxqmMy2nG9A== X-Received: by 2002:a1c:d92:: with SMTP id 140-v6mr3361552wmn.32.1530339068207; Fri, 29 Jun 2018 23:11:08 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 30 Jun 2018 08:10:18 +0200 Message-Id: <20180630061040.6018-26-pbonzini@redhat.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180630061040.6018-1-pbonzini@redhat.com> References: <20180630061040.6018-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22c Subject: [Qemu-devel] [PULL 25/47] hw/tricore: Use the IEC binary prefix definitions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Philippe Mathieu-Daud=C3=A9 It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Bastian Koppelmann Message-Id: <20180625124238.25339-24-f4bug@amsat.org> Signed-off-by: Paolo Bonzini --- hw/tricore/tricore_testboard.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/tricore/tricore_testboard.c b/hw/tricore/tricore_testboard.c index 8e61dfc..a58096f 100644 --- a/hw/tricore/tricore_testboard.c +++ b/hw/tricore/tricore_testboard.c @@ -19,6 +19,7 @@ =20 =20 #include "qemu/osdep.h" +#include "qemu/units.h" #include "qapi/error.h" #include "qemu-common.h" #include "cpu.h" @@ -72,17 +73,17 @@ static void tricore_testboard_init(MachineState *machin= e, int board_id) cpu =3D TRICORE_CPU(cpu_create(machine->cpu_type)); env =3D &cpu->env; memory_region_init_ram(ext_cram, NULL, "powerlink_ext_c.ram", - 2 * 1024 * 1024, &error_fatal); + 2 * MiB, &error_fatal); memory_region_init_ram(ext_dram, NULL, "powerlink_ext_d.ram", - 4 * 1024 * 1024, &error_fatal); - memory_region_init_ram(int_cram, NULL, "powerlink_int_c.ram", 48 * 102= 4, + 4 * MiB, &error_fatal); + memory_region_init_ram(int_cram, NULL, "powerlink_int_c.ram", 48 * KiB, &error_fatal); - memory_region_init_ram(int_dram, NULL, "powerlink_int_d.ram", 48 * 102= 4, + memory_region_init_ram(int_dram, NULL, "powerlink_int_d.ram", 48 * KiB, &error_fatal); memory_region_init_ram(pcp_data, NULL, "powerlink_pcp_data.ram", - 16 * 1024, &error_fatal); + 16 * KiB, &error_fatal); memory_region_init_ram(pcp_text, NULL, "powerlink_pcp_text.ram", - 32 * 1024, &error_fatal); + 32 * KiB, &error_fatal); =20 memory_region_add_subregion(sysmem, 0x80000000, ext_cram); memory_region_add_subregion(sysmem, 0xa1000000, ext_dram); --=20 1.8.3.1