From nobody Tue Nov 4 18:42:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530339879765911.4419626869249; Fri, 29 Jun 2018 23:24:39 -0700 (PDT) Received: from localhost ([::1]:45735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ9JB-0007Gj-FQ for importer@patchew.org; Sat, 30 Jun 2018 02:24:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fZ95z-00042n-Il for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:11:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fZ95y-0001pD-Ga for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:10:55 -0400 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:55231) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fZ95y-0001nj-8J for qemu-devel@nongnu.org; Sat, 30 Jun 2018 02:10:54 -0400 Received: by mail-wm0-x22f.google.com with SMTP id i139-v6so4085359wmf.4 for ; Fri, 29 Jun 2018 23:10:54 -0700 (PDT) Received: from donizetti.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 24-v6sm563454wrz.94.2018.06.29.23.10.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Jun 2018 23:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dtay3fhDXtHI87/toLahyMqaAc3N2SKYPqLh7D77MmE=; b=Zxa3S9M0oIhRoTbFauyKn1qDLmT9ZsDuhiTY0DXKN3b16bCKMNbDB0Ni6IR9XfGVPH pyNahq5ZyyIOtaJf/C2dIvO3owsPr88pzhJu1sR41Tj3Sz4ENn8bDzcYYkSsxPlaBdcO VW3P6+KP/A8+OK2EXs3RUK6B5vM46Dy9gk8T8tchDMXxfnmqx+6byxhJz68nL+FH80r5 +pvQt3LVD8Nbr4IAbfGQFI0gyQT4/PsawM+AwrzGXvVlEZbeLBqfD51aNsxsFL3QEFGt 1DEfjm0fe1TRbafI+5cGldvqJu5U501FM1btolCn0RRceoxsvbMSMh2cRW8FhlzM3KwF T5tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Dtay3fhDXtHI87/toLahyMqaAc3N2SKYPqLh7D77MmE=; b=rlS5DzGGwYBxdRZjI1cLa01YRd+rWQhHqwm21f+KpSAJGuT5l65OAgfeQ8i8XzRn1X ODkFfkjmErTznGmWnwkSkJObeGWOjWRyB+NeoYLZBQa8EX7dWPSkQa3+aGtZe+GlGp5p DZRcmPe1k5frPMZzH0kKqHe2PABwyCDjE3WgbnDOkI2cpllMJxhjA8xfAgTfP9tuzobO iPxnSUSx+/aG13skafO//phZgVZxXyd0ToFgRc6NO/2+FNMP2E2OpPVBNc4p8bH6FBHE z2aUn+7WjQvSnzpgcw7TQeGNOy8HHvx3Di+9+FY7RJAFoMA3DsMf24LXwD4LBeAksOj1 uxKw== X-Gm-Message-State: APt69E2s8A7yMbG45da5wjRa9V8zFaUbkpdKBJBP1hmOB3+pQ0Bk2QsO 0DSkuosEn2kibz9ovk1jVDpJzsyY X-Google-Smtp-Source: AAOMgpeu1Isu42ZQ/h1feLQWrHOZxGNpSFk6gGXebNCZRo+YNP2Fpn6MIDTv0XEXq43BUtXGgbkzlw== X-Received: by 2002:a1c:c241:: with SMTP id s62-v6mr3669815wmf.146.1530339053073; Fri, 29 Jun 2018 23:10:53 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Sat, 30 Jun 2018 08:10:03 +0200 Message-Id: <20180630061040.6018-11-pbonzini@redhat.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180630061040.6018-1-pbonzini@redhat.com> References: <20180630061040.6018-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22f Subject: [Qemu-devel] [PULL 10/47] hw/ipack: Use the IEC binary prefix definitions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Philippe Mathieu-Daud=C3=A9 It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alberto Garcia Message-Id: <20180625124238.25339-9-f4bug@amsat.org> Signed-off-by: Paolo Bonzini --- hw/ipack/tpci200.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ipack/tpci200.c b/hw/ipack/tpci200.c index da05c85..cd3e791 100644 --- a/hw/ipack/tpci200.c +++ b/hw/ipack/tpci200.c @@ -9,6 +9,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/units.h" #include "hw/ipack/ipack.h" #include "hw/pci/pci.h" #include "qemu/bitops.h" @@ -597,9 +598,9 @@ static void tpci200_realize(PCIDevice *pci_dev, Error *= *errp) memory_region_init_io(&s->las1, OBJECT(s), &tpci200_las1_ops, s, "tpci200_las1", 1024); memory_region_init_io(&s->las2, OBJECT(s), &tpci200_las2_ops, - s, "tpci200_las2", 1024*1024*32); + s, "tpci200_las2", 32 * MiB); memory_region_init_io(&s->las3, OBJECT(s), &tpci200_las3_ops, - s, "tpci200_las3", 1024*1024*16); + s, "tpci200_las3", 16 * MiB); pci_register_bar(&s->dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mmio); pci_register_bar(&s->dev, 1, PCI_BASE_ADDRESS_SPACE_IO, &s->io); pci_register_bar(&s->dev, 2, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->las0); --=20 1.8.3.1