From nobody Mon Feb 9 19:17:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530197994313550.9458920363296; Thu, 28 Jun 2018 07:59:54 -0700 (PDT) Received: from localhost ([::1]:37049 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYYOn-000110-NK for importer@patchew.org; Thu, 28 Jun 2018 10:59:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYYNO-0000Mx-3f for qemu-devel@nongnu.org; Thu, 28 Jun 2018 10:58:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYYNJ-0007Uk-R0 for qemu-devel@nongnu.org; Thu, 28 Jun 2018 10:58:26 -0400 Received: from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:44984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYYNJ-0007RZ-Ib for qemu-devel@nongnu.org; Thu, 28 Jun 2018 10:58:21 -0400 Received: by mail-wr0-x22b.google.com with SMTP id p12-v6so5839971wrn.11 for ; Thu, 28 Jun 2018 07:58:21 -0700 (PDT) Received: from bark.daynix ([141.226.163.173]) by smtp.gmail.com with ESMTPSA id m185-v6sm8399691wma.36.2018.06.28.07.58.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Jun 2018 07:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=YnYl+E/SbkFiPemnF7n23dMoIp3LNcAdM8asvxX09g4=; b=aaNN8Y8YIBmjF1BteE5bwn2cE48ewVpDpRUQU6SyHvq4y0pgWoEZAoncgi4ABm4b/c PJWE5jhZYo02zsQ3dw03bynGGTUncZ6WA8bAz/ILfet5G9r0BpZKf5n3oK167ZoLRhlC gH8d9ukaH8+tiwv8YjTEDZzuWaHq1GXekb0l4UvO2y4MzMRDjSHEfbmls4LCK0gTo4MK msPrS2/L3ZXe5mamskuXdBtN9XsOymwhsEBM/rMBDhrYp3bdQXWuLcvm2sgLoz+99ys7 9k5YO3+Ok8uz1bGixUiaeHZ3o6UNAHdJv+sWtdSJR6Ir3HSbUncvmaTtNdJ0WhjRgiTz cVSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YnYl+E/SbkFiPemnF7n23dMoIp3LNcAdM8asvxX09g4=; b=AKHnOFdTcHyuBKB1eRzr/Tg++waMljunnCgDDNTwVG9GZcSX1JRF0fxapJ8luzmD50 amHPchR8RM8KNVQBz7GZyOtnFCkayuIFT6SGwLHU3tkG4twLJL9tROuUaTLj3/daNhKD n1uZOgu9Wgqu2/SB9tRPRSlJSPbhCDSpQT8VNLf4qyV02EbhRhthqR4eS3kjatqj7lwt 2cKwr7SfD5GXEb9g1sKnOI6s1Oi683O/JdFeO1BVGKtkAKjZ33x/xGLsk0lRJoMJwPuC UBiFZ9/2xFCR2DQP9L6uZ8BBd7BZtgln0/Nc8yN7WmSsNJVuRkaYN/odPM6H7fQzdbfL +gpw== X-Gm-Message-State: APt69E23/LVFFvN32Ae96Br7xIrNXwDYFzGxsQ1nNrOvt6YOkFn7kthd 4hBckAzLr1xZMcJvE5efo5MrTQaB X-Google-Smtp-Source: AAOMgpf8idA3Fv05CbWnr7VKRf//8dacYYFwkVDtASA2cjfdAfjOXYaTm4bcdTvV4zDAQ+WCbcumaQ== X-Received: by 2002:a5d:4392:: with SMTP id i18-v6mr9544815wrq.156.1530197899952; Thu, 28 Jun 2018 07:58:19 -0700 (PDT) From: Bishara AbuHattoum To: qemu-devel@nongnu.org, Michael Roth Date: Thu, 28 Jun 2018 17:58:16 +0300 Message-Id: <20180628145816.30339-1-bishara@daynix.com> X-Mailer: git-send-email 2.13.6 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22b Subject: [Qemu-devel] [PATCH v3] qga-win: Fixing msi upgrade disallow in WiX file X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Issue: When upgrading qemu-ga using the msi from an old version to a newer one, the upgrade is not allowed by the msi showing this error message "Another version of this product is already installed." BZ# 1536331: https://bugzilla.redhat.com/show_bug.cgi?id=3D1536331 Fix: For the upgrade to be allowed by the msi the WiX file must provide three things: 1. Changing product's Id. (assigning it to "*") 2. Constant product's UpgradeId. (exists) 3. Changing version. (exists) Reference: http://wixtoolset.org/documentation/manual/v3/howtos/updates/maj= or_upgrade.html Signed-off-by: Bishara AbuHattoum --- qga/installer/qemu-ga.wxs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index 5af11627f8..f751a7e9f7 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -41,7 +41,7 @@ =20