From nobody Tue Nov 4 15:26:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530087909626920.8705425444175; Wed, 27 Jun 2018 01:25:09 -0700 (PDT) Received: from localhost ([::1]:57339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fY5l5-000393-Jn for importer@patchew.org; Wed, 27 Jun 2018 04:24:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fY5j8-00021C-7L for qemu-devel@nongnu.org; Wed, 27 Jun 2018 04:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fY5j6-0002Ps-PF for qemu-devel@nongnu.org; Wed, 27 Jun 2018 04:22:58 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59600 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fY5j6-0002Ok-Kd for qemu-devel@nongnu.org; Wed, 27 Jun 2018 04:22:56 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 442F9BF580; Wed, 27 Jun 2018 08:22:56 +0000 (UTC) Received: from dhcp201-121.englab.pnq.redhat.com (dhcp193-105.pnq.redhat.com [10.65.193.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F0692026D5B; Wed, 27 Jun 2018 08:22:54 +0000 (UTC) From: Pankaj Gupta To: mst@redhat.com, amit@kernel.org, qemu-devel@nongnu.org Date: Wed, 27 Jun 2018 13:52:48 +0530 Message-Id: <20180627082248.14921-3-pagupta@redhat.com> In-Reply-To: <20180627082248.14921-1-pagupta@redhat.com> References: <20180627082248.14921-1-pagupta@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 27 Jun 2018 08:22:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Wed, 27 Jun 2018 08:22:56 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'pagupta@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH 2/2] virtio: Set status early in VirtIODevice parent object X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: slopezpa@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" To process pending requests for driver status 'VIRTIO_CONFIG_S_DRIVER_OK', virtio-rng 'set_status' calls 'is_guest_ready' function. This checks if=20 virtqueue is ready and status is set to 'VIRTIO_CONFIG_S_DRIVER_OK'.=20 This call is made before new status is updated in VirtIODevice parent obje= ct=20 and calling function uses old status value. Signed-off-by: Pankaj Gupta --- hw/virtio/virtio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index d4e4d98b59..37dc59a686 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -1154,10 +1154,11 @@ int virtio_set_status(VirtIODevice *vdev, uint8_t v= al) } } } + vdev->status =3D val; + if (k->set_status) { k->set_status(vdev, val); } - vdev->status =3D val; return 0; } =20 --=20 2.14.3