From nobody Tue Nov 4 15:31:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530027987219827.8716963497151; Tue, 26 Jun 2018 08:46:27 -0700 (PDT) Received: from localhost ([::1]:53506 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXqAk-0004Sb-Fd for importer@patchew.org; Tue, 26 Jun 2018 11:46:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXq57-0008Nl-DU for qemu-devel@nongnu.org; Tue, 26 Jun 2018 11:40:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXq56-0005eV-Al for qemu-devel@nongnu.org; Tue, 26 Jun 2018 11:40:37 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:40361) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXq56-0005e6-32 for qemu-devel@nongnu.org; Tue, 26 Jun 2018 11:40:36 -0400 Received: by mail-wr0-x241.google.com with SMTP id g18-v6so17734564wro.7 for ; Tue, 26 Jun 2018 08:40:35 -0700 (PDT) Received: from donizetti.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id y129-v6sm2308490wmy.4.2018.06.26.08.40.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Jun 2018 08:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=fTipQ78m3ZW8pWlMHJPp+9G7GF/v8QQRPNK3J+DsODw=; b=FdDeQOpJ7GCunXK5dMvAdliRIb2bhMYQ9EEvHgTt49jKOotn871D2GIDRqhfD4StWI 00N+ZMLZePBza9nVK2Bs5WEOz758Rof9NYBh9bjW6FAZM+Tqkcvm80uJEvO332Xtb5Wt KPVmvgycOd90vtaNxjjEHEM6dUFtRYG4DgQxM/h7kUYe1iTH/7aRDFwMXF5MFx1LiglA xuudaw+I0KYdAYsNA6Mh5PlaC6YLrTF4ngM1YzY6XdARLXyuYCDRF/FlcBHJ7idcvkPj dRTFmuctWWT7X57HCK6ov53yVYFlatVKm0k1jXbUc1aO+sQ2l2mvenrjPFec9N31TMvA JdOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=fTipQ78m3ZW8pWlMHJPp+9G7GF/v8QQRPNK3J+DsODw=; b=eQPu24TKamu5zKWhXr/vSWOI2MvPa9FJT6PEPOBnNHNIZcOfS0xtcL7ZePSU3A7AZ1 gUV6WtqW5r58nRKq277d+WNUx+TV0zZFSI2vdaYirFU9/IJeB72Auo3k45v+HIO3RQmg HByI++nBClH5dsrlnB4XxH4YA3m7AA6Eu33G2m7FvcvfObGjpzPxcNzgJ3JmdmJdB8rD Lnyf/sZ6uVN5CC3aL/zETuK69AmMzN3cYk+9VQ2yhiLHBA/WNepde9dbtbfHhLwD4Zxt O8hP20n8nraVXrMSmkX3egr7C/m5OHDu0RTTyKZYX8deM2tgi9VbRYqEhRTjU41GImD+ Z/ow== X-Gm-Message-State: APt69E18I0KZjthi70Owy6Nj18icMKc3aRrJldEhMCCT+Q6uVKbrG3Ib 05L5JhiGkBZLvDQp3J5t0EyJV0gq X-Google-Smtp-Source: AAOMgpcGqpymaHpgwuXF3nNY30CliEMJNB4cnyl3DbcohLYH1vjbA0PBEAIP53wpPvzsh2Zj+hIb9A== X-Received: by 2002:adf:8610:: with SMTP id 16-v6mr1909174wrv.255.1530027634819; Tue, 26 Jun 2018 08:40:34 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 26 Jun 2018 17:40:26 +0200 Message-Id: <20180626154028.11133-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180626154028.11133-1-pbonzini@redhat.com> References: <20180626154028.11133-1-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PATCH 3/5] pr-manager-helper: avoid SIGSEGV when writing to the socket fail X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When writing to the qemu-pr-helper socket failed, the persistent reservation manager was correctly disconnecting the socket, but it did not clear pr_mgr->ioc. So the rest of the code did not know that the socket had been disconnected, accessed pr_mgr->ioc and happily caused a crash. To reproduce, it is enough to stop qemu-pr-helper between QEMU startup and executing e.g. sg_persist -k /dev/sdb. Signed-off-by: Paolo Bonzini Reviewed-by: Michal Privoznik --- scsi/pr-manager-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c index 82ff6b6123..0c0fe389b7 100644 --- a/scsi/pr-manager-helper.c +++ b/scsi/pr-manager-helper.c @@ -71,6 +71,7 @@ static int pr_manager_helper_write(PRManagerHelper *pr_mg= r, if (n_written <=3D 0) { assert(n_written !=3D QIO_CHANNEL_ERR_BLOCK); object_unref(OBJECT(pr_mgr->ioc)); + pr_mgr->ioc =3D NULL; return n_written < 0 ? -EINVAL : 0; } =20 --=20 2.17.1