From nobody Tue Feb 10 07:01:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152992571967140.21701903684334; Mon, 25 Jun 2018 04:21:59 -0700 (PDT) Received: from localhost ([::1]:45545 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXPZD-0006C1-KT for importer@patchew.org; Mon, 25 Jun 2018 07:21:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXPX4-0004wm-Io for qemu-devel@nongnu.org; Mon, 25 Jun 2018 07:19:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXPX2-0008CS-SV for qemu-devel@nongnu.org; Mon, 25 Jun 2018 07:19:42 -0400 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:38892) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXPX2-0008C7-MD for qemu-devel@nongnu.org; Mon, 25 Jun 2018 07:19:40 -0400 Received: by mail-wr0-x22c.google.com with SMTP id e18-v6so13263639wrs.5 for ; Mon, 25 Jun 2018 04:19:40 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id g125-v6sm3849066wmf.16.2018.06.25.04.19.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 04:19:37 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 2450E3E08BB; Mon, 25 Jun 2018 12:19:36 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s7NALE73HWatGlnIs6kj6n7zdn41IoOMv+JfEkZG3yc=; b=RPr9ga0/YskNWdafeVQFHbri9LrlxLa3vEUv+l7SBWNWB2vC2TbUvvCbFouxa6K7cC s2Gk1q748ueUgQ0bG+XcD+QicatNLZzdfcPRzsBZQXjuPIGChzqRXTHeoIAoGtNn5R7Y 2Pd9u8MeAY1xqtK8Tovkb7H3Hd7iYaj572608= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s7NALE73HWatGlnIs6kj6n7zdn41IoOMv+JfEkZG3yc=; b=AVx23PzXFJu13jk1LDVw8t5RziaEq+ypaIg69ouX4/OW+qhRD6ubn+zd0uK3NNjunD SIht9dZDH8ONX8X6xu+EiNa16V8ZaMS3iFGt7b8bE9AtqXGFkz5899KtWUgdsW6Cfn7M tPR2CgArxsncys1eQLoLfKKVfP6tZc0tpNEx50IImcmlAZZFjsDUgsyIvjRk4VaUY25G qByE+1Ilwm1KwJ+aUQbDAsq+w3C1Rs1I7EY/S6/dv0+6vCVI2BkU8M2fpHJW+pu75SJh GKUUa8tVJ08xwb1EOdrCIFt1jtdx4bh9taAN5zDsSrg0dFSyedR80VTQNR7mpDx2aBhB /EEw== X-Gm-Message-State: APt69E0kMMiJc1Nb/jBvXedaKmh7xHwJCjffeFo920PSJEkst2HFC3Cs U/Jw2QEwDJCDENMjkZ3WFFeSYA== X-Google-Smtp-Source: AAOMgpfUvPg1LooG7wXU80XHSPEGm0zdxLokjQeQIqEfmouKNhwXhHZm/Wqv+W9X22KWH+mlKepJcw== X-Received: by 2002:adf:c546:: with SMTP id s6-v6mr10321534wrf.46.1529925579570; Mon, 25 Jun 2018 04:19:39 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Mon, 25 Jun 2018 12:19:28 +0100 Message-Id: <20180625111935.26108-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180625111935.26108-1-alex.bennee@linaro.org> References: <20180625111935.26108-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22c Subject: [Qemu-devel] [PATCH v1 03/10] build-system: remove per-test GCOV reporting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/devel/testing.rst | 11 +++++------ tests/Makefile.include | 10 ---------- 2 files changed, 5 insertions(+), 16 deletions(-) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index f33e5a8423..66ef219f69 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -158,12 +158,11 @@ rarely used. See "QEMU iotests" section below for mor= e information. GCC gcov support ---------------- =20 -``gcov`` is a GCC tool to analyze the testing coverage by instrumenting the -tested code. To use it, configure QEMU with ``--enable-gcov`` option and b= uild. -Then run ``make check`` as usual. There will be additional ``gcov`` output= as -the testing goes on, showing the test coverage percentage numbers per anal= yzed -source file. More detailed reports can be obtained by running ``gcov`` com= mand -on the output files under ``$build_dir/tests/``, please read the ``gcov`` +``gcov`` is a GCC tool to analyze the testing coverage by +instrumenting the tested code. To use it, configure QEMU with +``--enable-gcov`` option and build. Then run ``make check`` as usual. +Reports can be obtained by running ``gcov`` command on the output +files under ``$build_dir/tests/``, please read the ``gcov`` documentation for more information. =20 QEMU iotests diff --git a/tests/Makefile.include b/tests/Makefile.include index e8bb2d8f66..756474814a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -891,26 +891,16 @@ GCOV_OPTIONS =3D -n $(if $(V),-f,) =20 .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-so= ftmmu $(check-qtest-y) - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=3D$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=3Dqemu-img$(EXESUF) \ MALLOC_PERTURB_=3D$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=3D$(SPEED) $(check-qtest-$*-y) $(check-qte= st-generic-y),"GTESTER","$@") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y) $(gcov-files-generic-y);= do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) =20 .PHONY: $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)) $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: % - $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command, \ MALLOC_PERTURB_=3D$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ gtester $(GTESTER_OPTIONS) -m=3D$(SPEED) $*,"GTESTER","$*") - $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y) $(gcov-= files-generic-y); do \ - echo Gcov report for $$f:;\ - $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ - done,) =20 # gtester tests with XML output =20 --=20 2.17.1