From nobody Mon Feb 9 23:01:12 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529378940964725.4915128402379; Mon, 18 Jun 2018 20:29:00 -0700 (PDT) Received: from localhost ([::1]:39072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV7KG-00086P-8E for importer@patchew.org; Mon, 18 Jun 2018 23:29:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5k4-0003VQ-MH for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:47:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV5k3-00016k-QS for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:47:32 -0400 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]:46328) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV5k3-00016A-Lt; Mon, 18 Jun 2018 21:47:31 -0400 Received: by mail-ot0-x242.google.com with SMTP id v24-v6so12230813otk.13; Mon, 18 Jun 2018 18:47:31 -0700 (PDT) Received: from localhost ([2600:1700:70:e488:b0ee:9bda:ee6f:91be]) by smtp.gmail.com with ESMTPSA id v8-v6sm16551556oti.35.2018.06.18.18.47.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 18:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=VbHSHczm6kRZ3SxNutgNs35u4qeOQ6xR2EZdRxwnzos=; b=rgyIyIOb3DCWITIV9az4McNz83GmyIrfSN1q5rs0og7CME1YPEKZ2GPgVI/1t4U9Zw FjtW+3g0dVYtRJuSBm0vH3+p0VTJ6gfeWTDon0W0Ne34N2aIhxYKYzCcIYf2JB+NSJb2 4krzPWIBlVw6qD3az4Qzv3UjIVvB2xNxIklpWT7AaaOLn8ifzoXUszH+IaSHOTKIkYFZ hpntOqRT72gLTgrovYpViccd7N9QXP4wB5N6Nm0xgRE+UmTro+uh1zQC4drWV6gNB8E2 SZNM9k3w+yKheORn9Y9qCQDMlpEsrPk/hzqsa9rYHnimvtfGyYmRoO8fsppz6sZsN/ty nK/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=VbHSHczm6kRZ3SxNutgNs35u4qeOQ6xR2EZdRxwnzos=; b=mtLdiAIJXBTBDvfNUw9weF7zEr2IGmc5AsBhZ7ThFpdBVV6iG0BJ7ij8fiBfVw1Byf xNh9FGCzO/riCKh7oYF/BdgrlYaxYalSP613NugaqhpmTOVQw5t4YvR51K2O5bk4Kk9O giQaysbS8w2xSSmYwcgT36UK4YPpOwx4XqYubiBtgcWSJilY+GtZZKtn6OuQsVxI8b1g +1FLHeFUN5uTKhDPRr0Zdqgfx5hbhDtbq8RjVc0i4KlAgCG5WQz6eqD+7YlZcdFbkQPs 2bM5K4Vcak2O6AekMPjQBuUlLrIuJoktAkkwQx5sdKgurifqEFRhZ4WjV85WGBnVHIRs QghA== X-Gm-Message-State: APt69E0oi/A3+kYe+3aGe8WXurdPYa4aUPLHpF+wZAkU7swfYy05UTsZ Oo4dhfSePgD/HTy6oZzeA6Z2uiqBiYU= X-Google-Smtp-Source: ADUXVKL/LS6iw2Sw/g2urcVZNMs9Bu6vhb+pW+nFN1ENPihfz+Er6z+i642g1T+Nprihj+w9jhOTKQ== X-Received: by 2002:a9d:1012:: with SMTP id h18-v6mr8661669ote.364.1529372850537; Mon, 18 Jun 2018 18:47:30 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 18 Jun 2018 20:41:34 -0500 Message-Id: <20180619014319.28272-9-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> References: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::242 Subject: [Qemu-devel] [PATCH 008/113] spapr: set vsmt to MAX(8, smp_threads) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Greg Kurz , qemu-stable@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laurent Vivier We ignore silently the value of smp_threads when we set the default VSMT value, and if smp_threads is greater than VSMT kernel is going into trouble later. Fixes: 8904e5a750 ("spapr: Adjust default VSMT value for better migration compatibility") Signed-off-by: Laurent Vivier Reviewed-by: Greg Kurz Signed-off-by: David Gibson (cherry picked from commit 4ad64cbd0c3f9df15be5f7d1c920285551e802ca) Signed-off-by: Greg Kurz --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 0c6547faef..6f78c1cf7a 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2289,7 +2289,7 @@ static void spapr_set_vsmt_mode(sPAPRMachineState *sp= apr, Error **errp) * the value that we'd get with KVM on POWER8, the * overwhelmingly common case in production systems. */ - spapr->vsmt =3D 8; + spapr->vsmt =3D MAX(8, smp_threads); } =20 /* KVM: If necessary, set the SMT mode: */ --=20 2.11.0