From nobody Mon Feb 9 23:01:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529378133474691.8237644046077; Mon, 18 Jun 2018 20:15:33 -0700 (PDT) Received: from localhost ([::1]:38948 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV77E-0005xs-K0 for importer@patchew.org; Mon, 18 Jun 2018 23:15:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5jb-00036M-8b for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:47:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV5ja-0000r3-DK for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:47:03 -0400 Received: from mail-ot0-x232.google.com ([2607:f8b0:4003:c0f::232]:33930) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV5ja-0000ql-8J; Mon, 18 Jun 2018 21:47:02 -0400 Received: by mail-ot0-x232.google.com with SMTP id r18-v6so20784940otk.1; Mon, 18 Jun 2018 18:47:02 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id q23-v6sm10138556otd.25.2018.06.18.18.46.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 18:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=0qlR3rSlK8DzNJTG4Fb2fqNBJBmgd1QCCWI4QD1Lig8=; b=ln9lCICQR7hiM8BNGqT+jIxE/M4C3s+FzVQWq+fZOYxNH5O2OIENvcW9uT/y9OkpKr i8n9bxkI//PoGfhO5U8xkSzzDJF/rJ+A9QbbEABfwYbLUIgFKPLqf6KsJGoeYWpBptia eVNRIO+TIs/EmbX/L8oU1hNdMxfHYQMKLC71iU58HnmrFNo99KdIFJoK1oqf6xeQguWd EQaFC8ajZEBd4jvse3DHsvJcIAH2yE7dIoH+i98CEUA9GhWSNGI4AcsfNruNE6D1Qqri qbdMOsqdiIIz4nFh/NPzT6YBduvg5NbtkXMgKY99rvw6cTBDwBzxVX7nEjXUGQEeUPjO yOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=0qlR3rSlK8DzNJTG4Fb2fqNBJBmgd1QCCWI4QD1Lig8=; b=AvtSS5ZAo1dgttrqf0J5kjiF0CXYmsuf3fdADBexh3M15IiTwX7A+kAwipODcsYhXL xY+FuePW1t6v78Bsdda0sSTx/VaUIla+g0qjFPLtSn4GUeG9UfyiRmgo9/6wZH4aosSs DiABTM9mY7vez1PEt/Fg7utX8qj7Z/bMYjC8Mz2NzhA9J1yOEVX7qGIiYVMVTkT/W+RT qP1NXR1Q3PFyDdfZ++/6+9Z/iSBXSOvdUi85zTVy7JuISGPRlvsOqWbdLueYI2a5Yma/ xfM9BfETuQa7HjIrelrZIgE3JfQuyfISSk2pjd8gyDWE6K7T5Dv6QotUPv0a9E+5OKmT yAxA== X-Gm-Message-State: APt69E1hKsImULRXaV1d7k0/nD8iA6Vz03nIUt5sUxMepNvx8QPpdq5P akh2Kqk2txGukFT5HjI8b5zDjy4t6vE= X-Google-Smtp-Source: ADUXVKKDO2NUD8ZYz4yqt7jwUbGd/a8H/qyz0LwejS6Z5JT5/heO5goyiE7DfvT+EMZjr9xhkveHIA== X-Received: by 2002:a9d:a12:: with SMTP id 18-v6mr8723160otg.359.1529372821087; Mon, 18 Jun 2018 18:47:01 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 18 Jun 2018 20:42:44 -0500 Message-Id: <20180619014319.28272-79-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> References: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::232 Subject: [Qemu-devel] [PATCH 078/113] pc-bios/s390-ccw: struct tpi_info must be declared as aligned(4) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Cornelia Huck , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth I've run into a compilation error today with the current version of GCC 8: In file included from s390-ccw.h:49, from main.c:12: cio.h:128:1: error: alignment 1 of 'struct tpi_info' is less than 4 [-Werro= r=3Dpacked-not-aligned] } __attribute__ ((packed)); ^ cc1: all warnings being treated as errors Since the struct tpi_info contains an element ("struct subchannel_id schid") which is marked as aligned(4), we've got to mark the struct tpi_info as aligned(4), too. CC: qemu-stable@nongnu.org Signed-off-by: Thomas Huth Message-Id: <1525774672-11913-1-git-send-email-thuth@redhat.com> Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger Signed-off-by: Cornelia Huck (cherry picked from commit a6e4385dea94850d7b06b0542e7960c1063fdabd) Signed-off-by: Michael Roth --- pc-bios/s390-ccw/cio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h index 55eaeee4b6..1a0795f645 100644 --- a/pc-bios/s390-ccw/cio.h +++ b/pc-bios/s390-ccw/cio.h @@ -125,7 +125,7 @@ struct tpi_info { __u32 reserved3 : 12; __u32 int_type : 3; __u32 reserved4 : 12; -} __attribute__ ((packed)); +} __attribute__ ((packed, aligned(4))); =20 /* channel command word (type 1) */ struct ccw1 { --=20 2.11.0