From nobody Mon Feb 9 23:01:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529377526711923.4464855187671; Mon, 18 Jun 2018 20:05:26 -0700 (PDT) Received: from localhost ([::1]:38885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV6xQ-0005wO-0S for importer@patchew.org; Mon, 18 Jun 2018 23:05:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5j4-0002eI-Gz for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:46:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV5j3-0000Ot-La for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:46:30 -0400 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]:46322) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV5j3-0000OY-GK; Mon, 18 Jun 2018 21:46:29 -0400 Received: by mail-ot0-x242.google.com with SMTP id v24-v6so12228844otk.13; Mon, 18 Jun 2018 18:46:29 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id o65-v6sm6630390oia.35.2018.06.18.18.46.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 18:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=BguzolFWXl+W3ujQpdUm/+0lbazkkDZNVKMZ88T52Y0=; b=qLPIFBYGcioZsKk/vkrX8cpFrtMzebcCKaVIZFJEHcvVey4EtAbfH/IjeuLSF0/a7p sCj3+VzAUHBSfQdGlnqivKRtWDQWk0fLq89U6FNFFwMEYyXniVsdYFIjb3uylloGt57n ZlwVURpnOq/UIKUyEcagM7i3BDbo7tnIBw/NXxyHkO1icMqUuoXzQRPUm628nR0juTpP 2rILYTMJbAci5DctFT+FJHRk7ERYlxIPVc3c3z0XPUC4zNxpcUvJpEZlotB9ZsO32LWX X04HR7hB7rBEpmGPBsNw+BPXOk8RL185iH5vdTHsEtM0ITBoH7s4gSc808kIwKWkpAq6 y3dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=BguzolFWXl+W3ujQpdUm/+0lbazkkDZNVKMZ88T52Y0=; b=f5QUA3hiazKKBT/DuoodHWqAghj2BNBtWeRl8pXq5ZGEsLgIMJyAdjDR05QmdZJvQg xP9J8tb2x2SORhan5mrt18PKCwrv9esAWpFNf+1DBaqm1N4cQtgn/ERoiO+lQ3kD0LHT F+ye7Ec6mLJyf2G0DX8Fp69XVYQdrxqw4kZg4a9YytI/nCNHagJTD6bRnyRZHh3pHhj7 car9ymOeagjsr6JRZRiNMoINcxHDygfPMDsjLAMnte41lm9foFNlwBL4SKJ2Ilsmw9iw S+JpEQPL6nMHEjkw7EOeqUcOQMvhj4xqvNaVx3se0j8Ovg6wjbZBs4x1dDwnHg98Fevy ymkQ== X-Gm-Message-State: APt69E0TKXWiLcOnfQZi1ugO//GCqXhb47OMDCc83Z54TmZZ63c+V+V/ LqwnljONEl8nRZlEnl1JD03yU7jZdFY= X-Google-Smtp-Source: ADUXVKK/3VDkdEVgICNGcodu8WTpeLwZZN5kxcFrn8nD1Oloa60DbYvi6fVyYyKvPv0m95I95DqSJA== X-Received: by 2002:a9d:4c02:: with SMTP id l2-v6mr8724075otf.242.1529372788378; Mon, 18 Jun 2018 18:46:28 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 18 Jun 2018 20:42:30 -0500 Message-Id: <20180619014319.28272-65-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> References: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::242 Subject: [Qemu-devel] [PATCH 064/113] tcg/arm: Fix memory barrier encoding X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Henry Wertz , Richard Henderson , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Henry Wertz I found with qemu 2.11.x or newer that I would get an illegal instruction error running some Intel binaries on my ARM chromebook. On investigation, I found it was quitting on memory barriers. qemu instruction: mb $0x31 was translating as: 0x604050cc: 5bf07ff5 blpl #0x600250a8 After patch it gives: 0x604050cc: f57ff05b dmb ish In short, I found INSN_DMB_ISH (memory barrier for ARMv7) appeared to be correct based on online docs, but due to some endian-related shenanigans it had to be byte-swapped to suit qemu; it appears INSN_DMB_MCR (memory barrier for ARMv6) also should be byte swapped (and this patch does so). I have not checked for correctness of aarch64's barrier instruction. Cc: qemu-stable@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Henry Wertz Signed-off-by: Richard Henderson (cherry picked from commit 3f814b803797c007abfe5c4041de754e01723031) Signed-off-by: Michael Roth --- tcg/arm/tcg-target.inc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index 98a12535a5..ccbd324262 100644 --- a/tcg/arm/tcg-target.inc.c +++ b/tcg/arm/tcg-target.inc.c @@ -159,8 +159,8 @@ typedef enum { INSN_STRD_IMM =3D 0x004000f0, INSN_STRD_REG =3D 0x000000f0, =20 - INSN_DMB_ISH =3D 0x5bf07ff5, - INSN_DMB_MCR =3D 0xba0f07ee, + INSN_DMB_ISH =3D 0xf57ff05b, + INSN_DMB_MCR =3D 0xee070fba, =20 /* Architected nop introduced in v6k. */ /* ??? This is an MSR (imm) 0,0,0 insn. Anyone know if this --=20 2.11.0