From nobody Mon Feb 9 23:01:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529375052757183.48370032825915; Mon, 18 Jun 2018 19:24:12 -0700 (PDT) Received: from localhost ([::1]:38597 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV6JX-0005cu-TE for importer@patchew.org; Mon, 18 Jun 2018 22:24:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5hn-0001NW-Np for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:45:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV5hm-0008GJ-NO for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:45:11 -0400 Received: from mail-ot0-x242.google.com ([2607:f8b0:4003:c0f::242]:41798) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV5hm-0008F0-II; Mon, 18 Jun 2018 21:45:10 -0400 Received: by mail-ot0-x242.google.com with SMTP id d19-v6so20756290oti.8; Mon, 18 Jun 2018 18:45:10 -0700 (PDT) Received: from localhost ([2600:1700:70:e488:b0ee:9bda:ee6f:91be]) by smtp.gmail.com with ESMTPSA id t4-v6sm16637380otd.40.2018.06.18.18.45.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 18:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=zSRIdxM346fc9dvuF02xB4T4y4i0o2MA9xesv1qFtTg=; b=B7ksLXbs/2wQU0gPBH+lw81R0arujm7pBdl8e4GJeyF7nqDxgN/IF8lT+7cdp68MC1 zTfQTI4/DBepIVUbKyx8N06PYurKi0Q9/EHyTdYfS9h72W9lvxZjZc4n304rPteUeCW+ 0Nwu8aIkQgxnbPq/5WgfbSlYIjrw4MXQMYeMvIC6wdTjuwFNtEDugXHvvxqceTY/w2pO 3xkwvyLEYo01D3VXtaSpgCttbYR40gmqngcG1i71PSq4nJZbtvjSc1gO6sWxoNb6I9s7 b/a/sYUdXfEFD2uJTksKdceZ8NdxizbAE/mj0w0pho61XFrteJpThKuIyEti260NS/zq fT1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=zSRIdxM346fc9dvuF02xB4T4y4i0o2MA9xesv1qFtTg=; b=aKeDe3J67q7KYc7O0rx4IpDkpT5kVPhewDN7YLrKSQrqMmy4hjjwXgyWTrNag3LrhZ PGEAcI68i85hTS2QilLRI6+hR0AiF4MnfKdpc7KOK6cDO3h17KJZS/PRWnUeG9u8eG/q mtLzzwo1bp2KH3ZYYS2sCCNub3P1e6GuyFwbfjf0Jhn1F4cRKxZog7fEzHNrNo9FAumL LZLdukWZQ7WCKFwHnqGzEhRgPM0p35aRipOkK6BgaDmbXClgi/+YoBPlQWpzuxC6/T9/ XSw2H+aJqGorMvAiIyRXsi9scTy9oWYVow2HYyCKQuhdvA0sSV511bkJyYfpyh8PrBUA 0k5A== X-Gm-Message-State: APt69E1fwBgWPDxtO9DLx3QMpJ6O5ORidpPg42Q7MudcaLo+8ewDeUal wi/eir879TRJuYHg/V586cg5izgs X-Google-Smtp-Source: ADUXVKIZp67iyMUQRrx+B0kl6mrGk58F2L4BrpyE+lhg+JI3zu4IDxISErqshMF7lhjmWUpIFOmrIA== X-Received: by 2002:a9d:12c9:: with SMTP id g67-v6mr8586462otg.350.1529372709387; Mon, 18 Jun 2018 18:45:09 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 18 Jun 2018 20:41:28 -0500 Message-Id: <20180619014319.28272-3-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> References: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::242 Subject: [Qemu-devel] [PATCH 002/113] pci-bridge/i82801b11: clear bridge registers on platform reset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Apfelbaum , Laszlo Ersek , qemu-stable@nongnu.org, "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Laszlo Ersek The "i82801b11-bridge" device model is a descendant of "base-pci-bridge" (TYPE_PCI_BRIDGE). However, unlike other similar devices, such as - pci-bridge, - pcie-pci-bridge, - PCIE Root Port, - xio3130 switch upstream and downstream ports, - dec-21154-p2p-bridge, - pbm-bridge, - xilinx-pcie-root, "i82801b11-bridge" does not clear the bridge specific registers at platform reset. This is a problem because devices on "i82801b11-bridge" continue to respond to config space cycles after platform reset, when addressed with the bus number that was previously programmed into the secondary bus number register of "i82801b11-bridge". This error breaks OVMF's search for extra (PXB) root buses, for example. The device class reset method for "i82801b11-bridge" is currently NULL; set it directly to pci_bridge_reset(), like the last three bridge models in the above listing do. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: qemu-stable@nongnu.org Ref: https://bugzilla.redhat.com/show_bug.cgi?id=3D1541839 Signed-off-by: Laszlo Ersek Reviewed-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit ed247f40db84c8bd4bb7d10948702cd47cc4d5ae) Signed-off-by: Michael Roth --- hw/pci-bridge/i82801b11.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c index cb522bf30c..ebf7f5f0e8 100644 --- a/hw/pci-bridge/i82801b11.c +++ b/hw/pci-bridge/i82801b11.c @@ -98,6 +98,7 @@ static void i82801b11_bridge_class_init(ObjectClass *klas= s, void *data) k->realize =3D i82801b11_bridge_realize; k->config_write =3D pci_bridge_write_config; dc->vmsd =3D &i82801b11_bridge_dev_vmstate; + dc->reset =3D pci_bridge_reset; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); } =20 --=20 2.11.0