From nobody Mon Feb 9 23:00:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529374679132741.3510779221; Mon, 18 Jun 2018 19:17:59 -0700 (PDT) Received: from localhost ([::1]:38559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV6DW-0000kf-An for importer@patchew.org; Mon, 18 Jun 2018 22:17:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5hf-0001Ey-1d for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:45:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV5he-0008AC-7n for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:45:03 -0400 Received: from mail-ot0-x244.google.com ([2607:f8b0:4003:c0f::244]:39250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV5he-00089q-2J; Mon, 18 Jun 2018 21:45:02 -0400 Received: by mail-ot0-x244.google.com with SMTP id l15-v6so20760935oth.6; Mon, 18 Jun 2018 18:45:01 -0700 (PDT) Received: from localhost ([2600:1700:70:e488:b0ee:9bda:ee6f:91be]) by smtp.gmail.com with ESMTPSA id t10-v6sm8489627ota.23.2018.06.18.18.44.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 18:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=XRVeJm8/PQHEvmfZNgTlf2ILrxYRXKQzS0Noee4oDww=; b=KwHiMDex/2r+dsnHVIOjoaQumhvVPrt5rEUFdoSdiRJFD1Z3g/sa2O110YLQ1TnGEs 5A4BDBs4NEIplzPrw6H0mV4TmxPqdC5hVH2IaEntbGohlIKrTqYK5n27mAF9fPvy96N/ LXXU522Ppwm89iTPqHi9Dw2yu3ei5/nWdoWf1fDL+Ou4IXJHcqa3iltWJ/b71xabogpt ktP+8lzT2FMhzuOcxrDSYYkbQ1gaedpMpkTFxpWuETZLo6sNrjvQqZFhnP6SexroXMjs h4/2gsi0jAPqaKGa6zVa194hKKEE2xMonZeZ/xi956LlHzuoa4eRo7zGWWgfFGsQaH2x 1xVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=XRVeJm8/PQHEvmfZNgTlf2ILrxYRXKQzS0Noee4oDww=; b=ThFJ28rSkmIg6eQWPaAepeYmGjAA5/Q4wPu4FvOAzNORlGnNqN5A5Hm9ezIBsZS+d7 fjABZmM41eqeXVYhRBDVQYVSyHFgw86HKUXox55tB5GoHG6H7O1oxkjSU/Vg8fEjOxni jNCEfKub6Sxyr/XrbGZiIm0ZbXrPe1SYJq5xtQNdKfLIwV1WolgfFOEfij2Awmf/k+iw ZM0eM4ijcc0qEjuNfr0aAFgBwolf8YihBv5NH9yWdmHlnz52ltvkoE6pYPP1k7i5gnoh Lga9aCbSq6qhIDigpkw7isGg8ErafzfkYYj54j3F5A54OOx99PwnPoWdRPj7DjhnOE8Y nwjQ== X-Gm-Message-State: APt69E2Yn9BwrlnlkX7ilVxcLF2NvAlWnGHO6wMwN4v28rByBduUyV7e 2eyCLkTpeHFrDxOpx3GYXGxjTRyg X-Google-Smtp-Source: ADUXVKLW8P7bfqxQmKheaXUIJZzeKUtl2rbXBZChUTOwzDIbTJ2eSj+7kQHPi96cj4i8Gk8Qiz1n2Q== X-Received: by 2002:a9d:e7c:: with SMTP id n57-v6mr9637366otd.10.1529372700768; Mon, 18 Jun 2018 18:45:00 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 18 Jun 2018 20:41:53 -0500 Message-Id: <20180619014319.28272-28-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> References: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::244 Subject: [Qemu-devel] [PATCH 027/113] openpic_kvm: drop address_space_to_flatview call X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Paolo Bonzini The MemoryListener is registered on address_space_memory, there is not much to assert. This currently works because the callback is invoked only once when the listener is registered, but section->fv is the _new_ FlatView, not the old one on later calls and that would break. This confines address_space_to_flatview to exec.c and memory.c. Acked-by: David Gibson Reviewed-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini (cherry picked from commit 80d2b933f9fe3e53d4f76a45a1bc1a0175669468) Signed-off-by: Michael Roth --- hw/intc/openpic_kvm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/intc/openpic_kvm.c b/hw/intc/openpic_kvm.c index fa83420254..39a6f369c5 100644 --- a/hw/intc/openpic_kvm.c +++ b/hw/intc/openpic_kvm.c @@ -124,10 +124,6 @@ static void kvm_openpic_region_add(MemoryListener *lis= tener, uint64_t reg_base; int ret; =20 - if (section->fv !=3D address_space_to_flatview(&address_space_memory))= { - abort(); - } - /* Ignore events on regions that are not us */ if (section->mr !=3D &opp->mem) { return; --=20 2.11.0