From nobody Tue Feb 10 19:14:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529374588028644.4175279889963; Mon, 18 Jun 2018 19:16:28 -0700 (PDT) Received: from localhost ([::1]:38555 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV6C2-0008Af-Tg for importer@patchew.org; Mon, 18 Jun 2018 22:16:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5hQ-00010X-TY for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:44:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV5hP-000844-Ti for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:44:48 -0400 Received: from mail-ot0-x22d.google.com ([2607:f8b0:4003:c0f::22d]:40166) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV5hP-00083x-OL; Mon, 18 Jun 2018 21:44:47 -0400 Received: by mail-ot0-x22d.google.com with SMTP id w9-v6so20744296otj.7; Mon, 18 Jun 2018 18:44:47 -0700 (PDT) Received: from localhost ([2600:1700:70:e488:b0ee:9bda:ee6f:91be]) by smtp.gmail.com with ESMTPSA id m62-v6sm7707536otc.71.2018.06.18.18.44.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 18:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=MVi4npPwBscy6kPVWn04VlJlshfdAar9kxYtJjYaQVA=; b=E8jTrwiF6nfDfIRii8iLUvLGBQjr+FfBLGQmFbFruoyjU2lSAZamXid5EV3l/ei4XR GyUNYrPW2y1kmFBjY2g9H3hAfqyfQt5oxJQ8i69DOu6CEV6S+SOdPtuBbONlDl+rObC7 AKEv8opNtyE6Yk4lmnf2umGf55JqQnrPSERtZ70Ffn8tlsG+RjyPH7kbo8pQPyPDmDHU J5qEXmzri8AHfO/7X9MeGpjZxHsIOZodSU1P7U3Wsma28WSol0JApeufLgr2dstIVuYu ij2MWDu/XJFZWhWeqEGClQkyh8RxjuxpJCL6L+CpyVpyJzXyT02cYRHgQpnXzHjhbocY QwMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=MVi4npPwBscy6kPVWn04VlJlshfdAar9kxYtJjYaQVA=; b=FlA1PM7NszSBm6KaJjz6SCH8Vvkp77byzETuytGFtf5ekBJI314JtcDh/0KNxlKI9Q y/ECGQpccS+9/UxO/j6i3o1XZ69sJJgkwFb2WG/+gxP46eUZH6PaPR4+6+Is4wf2ILOH dVUSOg4NfS3xSs3vXT92uRwvYMbUkeJBesJMoxnohXRv5Sf0RCU++S8eZsJ03uqxRfOZ Pkd1i30fp5zVxxefFn6lODo6kN/zf+yecIV5x/oK9kkE5alTAlyd573tegm5fyfevZJp UPnO3XnfQ9YXopb5kqBQV0BrNgIp1zFG1GnRXNsECigAQ3hiqacnoGDbc99CiQAlZgzs Z2KQ== X-Gm-Message-State: APt69E0Lq7dlukoBgtnyw0PaRvdlSy5FW/vrAWgIyq9xHDbq0qzdAIyR pshxbrZbp4YiFvyRbzq30Lha+Jvc X-Google-Smtp-Source: ADUXVKL6fVoJyeyNlTyTifG+JVwHj3wE1XBTRhbNuwpZr8N/SKhCg6FkWjrMiBBni3ck98dOPy8boQ== X-Received: by 2002:a9d:1339:: with SMTP id f54-v6mr9689180ote.307.1529372686553; Mon, 18 Jun 2018 18:44:46 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 18 Jun 2018 20:41:27 -0500 Message-Id: <20180619014319.28272-2-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> References: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::22d Subject: [Qemu-devel] [PATCH 001/113] block/ssh: fix possible segmentation fault when .desc is not null-terminated X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jeff Cody , Max Reitz , qemu-stable@nongnu.org, Murilo Opsfelder Araujo Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Murilo Opsfelder Araujo This patch prevents a possible segmentation fault when .desc members are ch= ecked against NULL. The ssh_runtime_opts was added by commit 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts for runt= ime options"). This fix was inspired by http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg00883.html. Fixes: 8a6a80896d6af03b8ee0c17cdf37219eca2588a7 ("block/ssh: Use QemuOpts f= or runtime options") Cc: Max Reitz Cc: Eric Blake Signed-off-by: Murilo Opsfelder Araujo Reviewed-by: Eric Blake Reviewed-by: Jeff Cody Signed-off-by: Jeff Cody (cherry picked from commit fbd5c4c0db47e578e3fdd88a0ebc4314a1ed3d42) Signed-off-by: Michael Roth --- block/ssh.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/ssh.c b/block/ssh.c index b049a16eb9..8890a0c4ba 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -556,6 +556,7 @@ static QemuOptsList ssh_runtime_opts =3D { .type =3D QEMU_OPT_STRING, .help =3D "Defines how and what to check the host key against", }, + { /* end of list */ } }, }; =20 --=20 2.11.0