From nobody Mon Feb 9 23:01:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152937304162147.20122922830694; Mon, 18 Jun 2018 18:50:41 -0700 (PDT) Received: from localhost ([::1]:38385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5n6-0005CO-G3 for importer@patchew.org; Mon, 18 Jun 2018 21:50:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV5gq-0000Il-2j for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:44:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV5gp-0007l6-6l for qemu-devel@nongnu.org; Mon, 18 Jun 2018 21:44:12 -0400 Received: from mail-ot0-x235.google.com ([2607:f8b0:4003:c0f::235]:36651) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV5gp-0007kv-1T; Mon, 18 Jun 2018 21:44:11 -0400 Received: by mail-ot0-x235.google.com with SMTP id c15-v6so20775289otl.3; Mon, 18 Jun 2018 18:44:10 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id f64-v6sm8457072oib.10.2018.06.18.18.44.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 18:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=3QsA4ftZLjeFU66rIFLeA5bR2aVAwSXJ5EzD0jMfr0U=; b=IR/hTIO7hqvipVMx0FUak6xv6VArsGjT6ttjRevkl8FdEbd9zTAT8eAV/atPuF4pEg 0ooXU/AijOMmRB8LqRIHd5fbUYlE8C22gvvltvkPa4saEvD7VKBQrdDXOVuR4OszSgr7 F8OanIpjhkYMArk1+o0u7Mifqx6XfaR2zv2Fte4725SboJ4gVVy9pjPeWsiNvHWdOh4v zvHnYKH9G567zaiRvTHEhEMGjgv6DghyBclfQ6Wd+bptW8yHtWhWYeXG7xEjy5ajoVc5 TPU6DeKummbzC3pPy5+vr2f7CR5ma4A3aW93X9ww4TP2sRhkY0vM4uwaJwzxFozwyNR2 x90Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=3QsA4ftZLjeFU66rIFLeA5bR2aVAwSXJ5EzD0jMfr0U=; b=iopnmiCnmcssoBSNMwn092+DCIuX6DdFaH6Ur7vox08775bovdbsiq1UyX8vGmkZG+ cAoKrIhJKIc7sOv00g0TQRvQgOZgfk5Zr71M2cV1Vs2lGCsMpMl+LcPJXPgaHOxeKu0D AT1Nho5PTnR/erap1kfzdom1w/UbftqBavo/SkMW6HlnbM/KVshNwGrQMn8um0gwuCWT 6bE4I2wcfqCL99IKZ1hFwZFIDbQkIoNrzB/VLEoz44YwQDesM1REVoHHrAcn+pWF/3Bh ip/nAF8vKGIMQ4dPeuGOU6L2qzT2nxL8NwDfdVpdZReN10FVeR3vxd+ZTC+BQWDokOqj vugw== X-Gm-Message-State: APt69E0ZetFtSNiTYNvmtUewW2nSDnT93L0166qg6X3WIEikMico9A5P UPPIjO7hYaH290avPqrztaQDGqOB X-Google-Smtp-Source: ADUXVKKFYGr9cijW5may9zxXKHadt4MO77w2+LpJNm7BDiIyxE359TdvhQhd+F7JpjzR+NCXw8WWIw== X-Received: by 2002:a9d:3cb2:: with SMTP id z47-v6mr8376922otc.67.1529372649935; Mon, 18 Jun 2018 18:44:09 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 18 Jun 2018 20:43:15 -0500 Message-Id: <20180619014319.28272-110-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> References: <20180619014319.28272-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::235 Subject: [Qemu-devel] [PATCH 109/113] tap: set vhostfd passed from qemu cli to non-blocking X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Brijesh Singh , qemu-stable@nongnu.org, "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Brijesh Singh A guest boot hangs while probing the network interface when iommu_platform=3Don is used. The following qemu cli hangs without this patch: # $QEMU \ -netdev tap,fd=3D3,id=3Dhostnet0,vhost=3Don,vhostfd=3D4 3<>/dev/tap67 4<>= /dev/host-net \ -device virtio-net-pci,netdev=3Dhostnet0,id=3Dnet0,iommu_platform=3Don,di= sable-legacy=3Don \ ... Commit: c471ad0e9bd46 (vhost_net: device IOTLB support) took care of setting vhostfd to non-blocking when QEMU opens /dev/host-net but if the fd is passed from qemu cli then we need to ensure that fd is set to non-blocking. Fixes: c471ad0e9bd46 ("vhost_net: device IOTLB support") Cc: qemu-stable@nongnu.org Cc: Michael S. Tsirkin Cc: Jason Wang Signed-off-by: Brijesh Singh Signed-off-by: Jason Wang (cherry picked from commit d542800d1edc62f63f8a29cfa6bdd1a9536ae11c) Signed-off-by: Michael Roth --- net/tap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tap.c b/net/tap.c index 979e622e60..aefd6edd1e 100644 --- a/net/tap.c +++ b/net/tap.c @@ -40,6 +40,7 @@ #include "qemu-common.h" #include "qemu/cutils.h" #include "qemu/error-report.h" +#include "qemu/sockets.h" =20 #include "net/tap.h" =20 @@ -689,6 +690,7 @@ static void net_init_tap_one(const NetdevTapOptions *ta= p, NetClientState *peer, error_propagate(errp, err); return; } + qemu_set_nonblock(vhostfd); } else { vhostfd =3D open("/dev/vhost-net", O_RDWR); if (vhostfd < 0) { --=20 2.11.0