From nobody Tue Feb 10 22:18:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529294495311325.33208674691843; Sun, 17 Jun 2018 21:01:35 -0700 (PDT) Received: from localhost ([::1]:60915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUlMB-0003K3-5E for importer@patchew.org; Mon, 18 Jun 2018 00:01:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUlEY-0005Jo-6Q for qemu-devel@nongnu.org; Sun, 17 Jun 2018 23:53:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUlEX-0003zJ-0N for qemu-devel@nongnu.org; Sun, 17 Jun 2018 23:53:38 -0400 Received: from ozlabs.org ([203.11.71.1]:33609) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fUlEW-0003we-Jl; Sun, 17 Jun 2018 23:53:36 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 418HJB1zswz9s7F; Mon, 18 Jun 2018 13:53:29 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1529294010; bh=0t29In3SXoQ2Ew1qViOrl0y16Ozsxj160YK86Tr+eCE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jXTH284e5TCiWYK1bWNjS4pTB3tPg0TLmIXvOfebXQKhQ4/kveDAV40W1QQiqnBFp z5o9QyjSvI41BeyKvNAGAysZFUPUZl4SDxKLSzydexkOFCX8J+m8xC1raVFMlOiuU0 WwypNm6+PEGSn13i2mz5fGYnCH8P95hX8sn20D1w= From: David Gibson To: peter.maydell@linaro.org Date: Mon, 18 Jun 2018 13:53:09 +1000 Message-Id: <20180618035324.19907-14-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180618035324.19907-1-david@gibson.dropbear.id.au> References: <20180618035324.19907-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 13/28] mos6522: only clear the shift register interrupt upon write X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, Mark Cave-Ayland , agraf@suse.de, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Mark Cave-Ayland According to the 6522 datasheet the shift register (SR) interrupt flag is cleared upon write with no mention of any other interrupt flags. Signed-off-by: Mark Cave-Ayland Signed-off-by: David Gibson --- hw/misc/mos6522.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/mos6522.c b/hw/misc/mos6522.c index 44eb306cf1..ad5041d8c0 100644 --- a/hw/misc/mos6522.c +++ b/hw/misc/mos6522.c @@ -241,7 +241,7 @@ uint64_t mos6522_read(void *opaque, hwaddr addr, unsign= ed size) break; case VIA_REG_SR: val =3D s->sr; - s->ifr &=3D ~(SR_INT | CB1_INT | CB2_INT); + s->ifr &=3D ~SR_INT; mos6522_update_irq(s); break; case VIA_REG_ACR: --=20 2.17.1