From nobody Tue Feb 10 20:48:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529095194480892.2353606427258; Fri, 15 Jun 2018 13:39:54 -0700 (PDT) Received: from localhost ([::1]:49273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTvVh-0000tq-Nr for importer@patchew.org; Fri, 15 Jun 2018 16:39:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTuoi-0000lV-IA for qemu-devel@nongnu.org; Fri, 15 Jun 2018 15:55:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTuoh-0006s7-De for qemu-devel@nongnu.org; Fri, 15 Jun 2018 15:55:28 -0400 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:35209) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fTuoh-0006rh-5a for qemu-devel@nongnu.org; Fri, 15 Jun 2018 15:55:27 -0400 Received: by mail-wm0-x22e.google.com with SMTP id j15-v6so5791415wme.0 for ; Fri, 15 Jun 2018 12:55:26 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id c18-v6sm8420839wrq.17.2018.06.15.12.55.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 15 Jun 2018 12:55:21 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id E6E0C3E0B71; Fri, 15 Jun 2018 20:47:06 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JJuWuvJJaqmpA1JDMnPjci5XY8PH5s/2mcDjRcXEBD8=; b=QeqyCA3Jkpj8mxV+OU4pIeX11wDEOPt5N+bRVhll12PW+RP746dEzS4GRb19QoZsSc NZsz6zfF9COHb+ztQ9WSp0Pp/ggEouCsVUp0ryz0oCx8W7HaUwJy4Jr+F5chKtedg7in 0Hoqa7OcbGhFwdPAQbh5DnYKpuGszUZnqHxjQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JJuWuvJJaqmpA1JDMnPjci5XY8PH5s/2mcDjRcXEBD8=; b=jpsoSEDcez+vf0tdZsufRQR4KU7O+sLhOVbJUlsWCGxe606/1RNTexWe2OH8lJXghH Du9TWk26Fk0RmACMCbwfkmz+URO8PcV+pU+SSa2XN6+g+BlmMHsH2lbD1UlqD0ZQTO4Z 4WuHAKtkpG+RSJ9v7MxT67cNXzwFp8ISycinvXSchgnHe9MrCmvpW6RROZvNcSIpOQQE FE6s14kjBxd+8MTuTJZGFm8fPU8RDtSBi4epRQVv4WRhRnGn9S2pUWqUe5OtnMvKJt6T C0DNhHeZdLwGMMi0GzGe7GYR88OhRibS+3RrClXtpCcReNRZPEcPgsn1YCOLX9syhqVs JsfA== X-Gm-Message-State: APt69E1Ch9h4n+IyD9YwpFWEReiKBPr/xm1WallqAD0N9KX20ZFRX19N qwuYbVPdAErEM+h/nsEZwyoDmQ== X-Google-Smtp-Source: ADUXVKIyEXMEvDcLCRUn2L8uYEmHHQVue8opiGYQ69T8aeEfKMat1HbSvukn7Nu/yUVrNQwKEYU5sA== X-Received: by 2002:a1c:69d7:: with SMTP id z84-v6mr2094224wmh.147.1529092525999; Fri, 15 Jun 2018 12:55:25 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de, peter.maydell@linaro.org Date: Fri, 15 Jun 2018 20:46:29 +0100 Message-Id: <20180615194705.28019-19-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180615194705.28019-1-alex.bennee@linaro.org> References: <20180615194705.28019-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22e Subject: [Qemu-devel] [PATCH v7 18/54] tests/tcg/i386: add runner for test-i386-fprem X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, Eduardo Habkost , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 The runner needs to compare against a reference run. We also only run this test when SPEED=3Dslow as it takes a while. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- v5 - include test-i386-fprem.ref v5.1 - remove the 69Mb test-i386-fprem.ref - generate test-i386-fprem.ref on developers machine - add TIMEOUT=3D60 --- tests/tcg/i386/Makefile.target | 16 ++++++++++++++++ tests/tcg/i386/test-i386-fprem.c | 12 +++++++++--- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target index 8b46cc021e..64d241cfdf 100644 --- a/tests/tcg/i386/Makefile.target +++ b/tests/tcg/i386/Makefile.target @@ -33,5 +33,21 @@ test-i386: test-i386.c test-i386-code16.S test-i386-vm86= .S test-i386.h test-i386 run-runcom: runcom pi_10.com $(call quiet-command, $(QEMU) ./runcom $(I386_SRC)/pi_10.com > runcom.out= , "TEST", "$< on $(TARGET_NAME)") =20 +ifeq ($(SPEED), slow) + +test-i386-fprem.ref: test-i386-fprem + $(call quiet-command, ./$< > $@,"GENREF","generating $@") + +run-test-i386-fprem: TIMEOUT=3D60 +run-test-i386-fprem: test-i386-fprem + $(call quiet-command, \ + $(QEMU) $< > $<.out && \ + diff -u $(I386_SRC)/$<.ref $<.out, \ + "TEST", "$< (default) on $(TARGET_NAME)") +else +run-test-i386-fprem: test-i386-fprem + $(call quiet-command, /bin/true, "SLOW TEST", "$< SKIPPED on $(TARGET_NAM= E)") +endif + # On i386 and x86_64 Linux only supports 4k pages (large pages are a diffe= rent hack) EXTRA_RUNS+=3Drun-test-mmap-4096 diff --git a/tests/tcg/i386/test-i386-fprem.c b/tests/tcg/i386/test-i386-fp= rem.c index 1a71623204..66f5a9657d 100644 --- a/tests/tcg/i386/test-i386-fprem.c +++ b/tests/tcg/i386/test-i386-fprem.c @@ -23,7 +23,10 @@ * along with this program; if not, see . */ =20 -#include "qemu/osdep.h" +#include +#include + +#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) =20 /* * Inspired by 's union ieee854_long_double, but with single @@ -39,7 +42,7 @@ union float80u { unsigned int exponent:15; unsigned int negative:1; unsigned int empty:16; - } QEMU_PACKED ieee; + } __attribute__((packed)) ieee; =20 /* This is for NaNs in the IEEE 854 double-extended-precision format. = */ struct { @@ -49,7 +52,7 @@ union float80u { unsigned int exponent:15; unsigned int negative:1; unsigned int empty:16; - } QEMU_PACKED ieee_nan; + } __attribute__((packed)) ieee_nan; }; =20 #define IEEE854_LONG_DOUBLE_BIAS 0x3fff @@ -229,6 +232,7 @@ static void test_fprem_cases(void) do_fprem_stack_underflow(); =20 printf("=3D invalid operation =3D\n"); + do_fprem(q_nan.d, 1.0); do_fprem(s_nan.d, 1.0); do_fprem(1.0, 0.0); do_fprem(pos_inf.d, 1.0); @@ -238,6 +242,8 @@ static void test_fprem_cases(void) do_fprem(pos_denorm.d, 1.0); do_fprem(1.0, pos_denorm.d); =20 + do_fprem(smallest_positive_norm.d, smallest_positive_norm.d); + /* printf("=3D underflow =3D\n"); */ /* TODO: Is there a case where FPREM raises underflow? */ } --=20 2.17.1