From nobody Tue Feb 10 16:22:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529004438934136.14503052109364; Thu, 14 Jun 2018 12:27:18 -0700 (PDT) Received: from localhost ([::1]:42293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTXtn-0002Qy-2J for importer@patchew.org; Thu, 14 Jun 2018 15:27:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTXi1-0001fm-51 for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:15:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTXhw-0001c6-IU for qemu-devel@nongnu.org; Thu, 14 Jun 2018 15:15:01 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50752 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fTXhm-0001Ss-KU; Thu, 14 Jun 2018 15:14:46 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4523368800; Thu, 14 Jun 2018 19:14:46 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-1.ams2.redhat.com [10.36.117.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 00E1E23141; Thu, 14 Jun 2018 19:14:46 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2185911386A4; Thu, 14 Jun 2018 21:14:44 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 14 Jun 2018 21:14:32 +0200 Message-Id: <20180614191443.14361-8-armbru@redhat.com> In-Reply-To: <20180614191443.14361-1-armbru@redhat.com> References: <20180614191443.14361-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 14 Jun 2018 19:14:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 14 Jun 2018 19:14:46 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'armbru@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v2 07/18] block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, jcody@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The following pattern occurs in the .bdrv_co_create_opts() methods of parallels, qcow, qcow2, qed, vhdx and vpc: qobj =3D qdict_crumple_for_keyval_qiv(qdict, errp); qobject_unref(qdict); qdict =3D qobject_to(QDict, qobj); if (qdict =3D=3D NULL) { ret =3D -EINVAL; goto done; } v =3D qobject_input_visitor_new_keyval(QOBJECT(qdict)); [...] ret =3D 0; done: qobject_unref(qdict); [...] return ret; If qobject_to() fails, we return failure without setting errp. That's wrong. As far as I can tell, it cannot fail here. Clean it up anyway, by removing the useless conversion. Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf --- block/parallels.c | 9 ++++----- block/qcow.c | 9 ++++----- block/qcow2.c | 9 ++++----- block/qed.c | 9 ++++----- block/vhdx.c | 9 ++++----- block/vpc.c | 9 ++++----- 6 files changed, 24 insertions(+), 30 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 695899fc4b..ceb7a15d62 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -616,7 +616,7 @@ static int coroutine_fn parallels_co_create_opts(const = char *filename, BlockdevCreateOptions *create_options =3D NULL; Error *local_err =3D NULL; BlockDriverState *bs =3D NULL; - QDict *qdict =3D NULL; + QDict *qdict; QObject *qobj; Visitor *v; int ret; @@ -654,14 +654,13 @@ static int coroutine_fn parallels_co_create_opts(cons= t char *filename, qdict_put_str(qdict, "file", bs->node_name); =20 qobj =3D qdict_crumple_for_keyval_qiv(qdict, errp); - qobject_unref(qdict); - qdict =3D qobject_to(QDict, qobj); - if (qdict =3D=3D NULL) { + if (!qobj) { ret =3D -EINVAL; goto done; } =20 - v =3D qobject_input_visitor_new_keyval(QOBJECT(qdict)); + v =3D qobject_input_visitor_new_keyval(qobj); + qobject_unref(qobj); visit_type_BlockdevCreateOptions(v, NULL, &create_options, &local_err); visit_free(v); =20 diff --git a/block/qcow.c b/block/qcow.c index 860b058240..2f81f081fd 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -946,7 +946,7 @@ static int coroutine_fn qcow_co_create_opts(const char = *filename, { BlockdevCreateOptions *create_options =3D NULL; BlockDriverState *bs =3D NULL; - QDict *qdict =3D NULL; + QDict *qdict; QObject *qobj; Visitor *v; const char *val; @@ -998,14 +998,13 @@ static int coroutine_fn qcow_co_create_opts(const cha= r *filename, qdict_put_str(qdict, "file", bs->node_name); =20 qobj =3D qdict_crumple_for_keyval_qiv(qdict, errp); - qobject_unref(qdict); - qdict =3D qobject_to(QDict, qobj); - if (qdict =3D=3D NULL) { + if (!qobj) { ret =3D -EINVAL; goto fail; } =20 - v =3D qobject_input_visitor_new_keyval(QOBJECT(qdict)); + v =3D qobject_input_visitor_new_keyval(qobj); + qobject_unref(qobj); visit_type_BlockdevCreateOptions(v, NULL, &create_options, &local_err); visit_free(v); =20 diff --git a/block/qcow2.c b/block/qcow2.c index 0a27afa2ef..8c338661db 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3080,7 +3080,7 @@ static int coroutine_fn qcow2_co_create_opts(const ch= ar *filename, QemuOpts *opt Error **errp) { BlockdevCreateOptions *create_options =3D NULL; - QDict *qdict =3D NULL; + QDict *qdict; QObject *qobj; Visitor *v; BlockDriverState *bs =3D NULL; @@ -3153,14 +3153,13 @@ static int coroutine_fn qcow2_co_create_opts(const = char *filename, QemuOpts *opt =20 /* Now get the QAPI type BlockdevCreateOptions */ qobj =3D qdict_crumple_for_keyval_qiv(qdict, errp); - qobject_unref(qdict); - qdict =3D qobject_to(QDict, qobj); - if (qdict =3D=3D NULL) { + if (!qobj) { ret =3D -EINVAL; goto finish; } =20 - v =3D qobject_input_visitor_new_keyval(QOBJECT(qdict)); + v =3D qobject_input_visitor_new_keyval(qobj); + qobject_unref(qobj); visit_type_BlockdevCreateOptions(v, NULL, &create_options, &local_err); visit_free(v); =20 diff --git a/block/qed.c b/block/qed.c index 88fa36d409..fcec760b26 100644 --- a/block/qed.c +++ b/block/qed.c @@ -722,7 +722,7 @@ static int coroutine_fn bdrv_qed_co_create_opts(const c= har *filename, Error **errp) { BlockdevCreateOptions *create_options =3D NULL; - QDict *qdict =3D NULL; + QDict *qdict; QObject *qobj; Visitor *v; BlockDriverState *bs =3D NULL; @@ -764,14 +764,13 @@ static int coroutine_fn bdrv_qed_co_create_opts(const= char *filename, qdict_put_str(qdict, "file", bs->node_name); =20 qobj =3D qdict_crumple_for_keyval_qiv(qdict, errp); - qobject_unref(qdict); - qdict =3D qobject_to(QDict, qobj); - if (qdict =3D=3D NULL) { + if (!qobj) { ret =3D -EINVAL; goto fail; } =20 - v =3D qobject_input_visitor_new_keyval(QOBJECT(qdict)); + v =3D qobject_input_visitor_new_keyval(qobj); + qobject_unref(qobj); visit_type_BlockdevCreateOptions(v, NULL, &create_options, &local_err); visit_free(v); =20 diff --git a/block/vhdx.c b/block/vhdx.c index 78b29d9fc7..f2aec3d2cd 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1965,7 +1965,7 @@ static int coroutine_fn vhdx_co_create_opts(const cha= r *filename, Error **errp) { BlockdevCreateOptions *create_options =3D NULL; - QDict *qdict =3D NULL; + QDict *qdict; QObject *qobj; Visitor *v; BlockDriverState *bs =3D NULL; @@ -2006,14 +2006,13 @@ static int coroutine_fn vhdx_co_create_opts(const c= har *filename, qdict_put_str(qdict, "file", bs->node_name); =20 qobj =3D qdict_crumple_for_keyval_qiv(qdict, errp); - qobject_unref(qdict); - qdict =3D qobject_to(QDict, qobj); - if (qdict =3D=3D NULL) { + if (!qobj) { ret =3D -EINVAL; goto fail; } =20 - v =3D qobject_input_visitor_new_keyval(QOBJECT(qdict)); + v =3D qobject_input_visitor_new_keyval(qobj); + qobject_unref(qobj); visit_type_BlockdevCreateOptions(v, NULL, &create_options, &local_err); visit_free(v); =20 diff --git a/block/vpc.c b/block/vpc.c index 16178e5a90..a9bb04149d 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -1081,7 +1081,7 @@ static int coroutine_fn vpc_co_create_opts(const char= *filename, QemuOpts *opts, Error **errp) { BlockdevCreateOptions *create_options =3D NULL; - QDict *qdict =3D NULL; + QDict *qdict; QObject *qobj; Visitor *v; BlockDriverState *bs =3D NULL; @@ -1120,14 +1120,13 @@ static int coroutine_fn vpc_co_create_opts(const ch= ar *filename, qdict_put_str(qdict, "file", bs->node_name); =20 qobj =3D qdict_crumple_for_keyval_qiv(qdict, errp); - qobject_unref(qdict); - qdict =3D qobject_to(QDict, qobj); - if (qdict =3D=3D NULL) { + if (!qobj) { ret =3D -EINVAL; goto fail; } =20 - v =3D qobject_input_visitor_new_keyval(QOBJECT(qdict)); + v =3D qobject_input_visitor_new_keyval(qobj); + qobject_unref(qobj); visit_type_BlockdevCreateOptions(v, NULL, &create_options, &local_err); visit_free(v); =20 --=20 2.17.1