From nobody Tue Feb 10 10:03:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528786281668194.43629344854685; Mon, 11 Jun 2018 23:51:21 -0700 (PDT) Received: from localhost ([::1]:53235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSd9F-0006zJ-0C for importer@patchew.org; Tue, 12 Jun 2018 02:51:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSd3g-0002cZ-Pd for qemu-devel@nongnu.org; Tue, 12 Jun 2018 02:45:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSd3d-0001fR-5S for qemu-devel@nongnu.org; Tue, 12 Jun 2018 02:45:36 -0400 Received: from ozlabs.org ([203.11.71.1]:49089) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSd3c-0001Z2-46; Tue, 12 Jun 2018 02:45:32 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 414gPM2yZtz9s1R; Tue, 12 Jun 2018 16:45:27 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1528785927; bh=+nVNr0ayMUbITDv8d+gMrMxghilBI3rCJ8iuoSQHjcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D5aLDNuBBFFh81XaBW+IAjO1SeruBNFJlGbH9QDqmSwDwFztM2qEBb17VijAZxG2p VQbaaLBv3Oa+jJcvKEhrvX7kIbpkM6+atEXvbZLQQi6DZi5hpvvfG+yBROiG9ttUnQ H+TVziyAoAIPnMoibAxV/mVx9mMvc+epZTI+pEs0= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 12 Jun 2018 16:44:34 +1000 Message-Id: <20180612064503.14282-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180612064503.14282-1-david@gibson.dropbear.id.au> References: <20180612064503.14282-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 04/33] hw/ppc/spapr_drc: Replace error_setg(&error_abort) by error_report() + abort() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 Use error_report() + abort() instead of error_setg(&error_abort), as suggested by the "qapi/error.h" documentation: Please don't error_setg(&error_fatal, ...), use error_report() and exit(), because that's more obvious. Likewise, don't error_setg(&error_abort, ...), use assert(). Use abort() instead of the suggested assert() because the error message already got displayed. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Eric Auger Signed-off-by: David Gibson --- hw/ppc/spapr_drc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 8a045d6b93..2edb7d1e9c 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -366,7 +366,8 @@ static void prop_get_fdt(Object *obj, Visitor *v, const= char *name, break; } default: - error_setg(&error_abort, "device FDT in unexpected state: %d",= tag); + error_report("device FDT in unexpected state: %d", tag); + abort(); } fdt_offset =3D fdt_offset_next; } while (fdt_depth !=3D 0); --=20 2.17.1