From nobody Mon Feb 9 20:18:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528787400279464.74909016733943; Tue, 12 Jun 2018 00:10:00 -0700 (PDT) Received: from localhost ([::1]:53344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSdRH-0006Gf-F4 for importer@patchew.org; Tue, 12 Jun 2018 03:09:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSd3r-0002qs-7t for qemu-devel@nongnu.org; Tue, 12 Jun 2018 02:45:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSd3q-0001yT-1N for qemu-devel@nongnu.org; Tue, 12 Jun 2018 02:45:47 -0400 Received: from ozlabs.org ([203.11.71.1]:60935) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSd3p-0001v4-K8; Tue, 12 Jun 2018 02:45:45 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 414gPY0xSLzB3t1; Tue, 12 Jun 2018 16:45:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1528785937; bh=U4BqNBo3O8aRt6uF7yEqnL7EqtPlVOKskwfE3fms4VQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I8UvJ5rGTxurM8HcwaxwKOc1oCZdNhkQ7FH2nxi4/Fz/567G3IlclGcgacymGR95/ lE0K05i3IvoOnfji3hb8xWAo4ZLkaMM8hQEklUI2VuBDtGtu93HMbhATqGcrENj/QA pEtCTJB04IwwliVNqWWH2TbDak7zg4+8nTRqat/4= From: David Gibson To: peter.maydell@linaro.org Date: Tue, 12 Jun 2018 16:44:55 +1000 Message-Id: <20180612064503.14282-26-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180612064503.14282-1-david@gibson.dropbear.id.au> References: <20180612064503.14282-1-david@gibson.dropbear.id.au> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 Subject: [Qemu-devel] [PULL 25/33] spapr: no need to verify the node X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, David Hildenbrand , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: David Hildenbrand The node property can always be queried and the value has already been verified in pc_dimm_realize(). Acked-by: David Gibson Reviewed-by: Greg Kurz Signed-off-by: David Hildenbrand Signed-off-by: David Gibson --- hw/ppc/spapr.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 2375cbee12..f16a0b2870 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3578,14 +3578,8 @@ static void spapr_machine_device_plug(HotplugHandler= *hotplug_dev, error_setg(errp, "Memory hotplug not supported for this machin= e"); return; } - node =3D object_property_get_uint(OBJECT(dev), PC_DIMM_NODE_PROP, = errp); - if (*errp) { - return; - } - if (node < 0 || node >=3D MAX_NODES) { - error_setg(errp, "Invaild node %d", node); - return; - } + node =3D object_property_get_uint(OBJECT(dev), PC_DIMM_NODE_PROP, + &error_abort); =20 spapr_memory_plug(hotplug_dev, dev, node, errp); } else if (object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_CPU_CORE)) { --=20 2.17.1