From nobody Tue Feb 10 15:29:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528395248877359.63831100303014; Thu, 7 Jun 2018 11:14:08 -0700 (PDT) Received: from localhost ([::1]:59634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQzQ6-0006wg-Mm for importer@patchew.org; Thu, 07 Jun 2018 14:13:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQzJP-00025T-PW for qemu-devel@nongnu.org; Thu, 07 Jun 2018 14:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQzJO-0004Sx-TO for qemu-devel@nongnu.org; Thu, 07 Jun 2018 14:07:03 -0400 Received: from mail-qt0-x22b.google.com ([2607:f8b0:400d:c0d::22b]:37498) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fQzJO-0004SX-P5; Thu, 07 Jun 2018 14:07:02 -0400 Received: by mail-qt0-x22b.google.com with SMTP id q13-v6so10799766qtp.4; Thu, 07 Jun 2018 11:07:02 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id s15-v6sm26838414qtc.81.2018.06.07.11.06.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jun 2018 11:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uuolPF/qep1do+QHIzhyDQZJtmzmVRMDR5bXzePYNiw=; b=lMlkTjjjIlmuyuW/Mhkkk7d/md6dgOYNWayG0NGUH6T/EEcZ/m/9sQWqmJA30s1feb duIteO9cykOGjGt07OwkMjlWo8s163itOmiJ5+JxL4MUpAIFx3aXNHOEzBd04jFZsu4H ujMmzm7Jfj5gtply54vOhL+Hd8cGyRvQwZUCayLhG5X6tcCdrrvRlRjlcMIybIoXC17N bVon3n6SFiPuLgnV1CGiGQ71s6T0F1OtkTbX6ThVzXq++D30DT+TTpRpDveNH5TIGd5K jzJndl6NeSB3DYqGu9cyKStRtjZNWUJ7M2xKnsHV9WAiVFvM1WVGBGc31o83NceWegfZ T3GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=uuolPF/qep1do+QHIzhyDQZJtmzmVRMDR5bXzePYNiw=; b=oApoCU8XnZD9/IDtbMhHkda7T5t9tOlnDGLf54EO0Lz0/tzKRuJfrFfVyH40iOe9OZ FAT8mWjhgZxIRg4hz/NPsgpw4zY4gApWS/Guilc8dN85MIeomftzSGr2ep32h9R63au3 L09otgxYhWhwoz+H7ZKHsW0osTVGBUAHdj0b9Vz1PRmLqHI/tQ0PKpkTyWLVZbpbXhnU 35j5TdQGHZTlejb7ZAaQuBxRwh38uY5RZ5OFZ4ZBtZsoQF5WBK42ICq2Xar9J8M1ojhV ov0y7KqHbBJK0IilkigK1Iiwmhm6WbEWw735ubDrt8lq6oeG10Zb/W8SN3N7K502KCHv dzkw== X-Gm-Message-State: APt69E1ufQVVfSCeNAiqyiJ4JSYzdVBWl6FARzXQvY6xURtFvSETRplo y/NVCVqo9L2pNu7BwMxZZZk= X-Google-Smtp-Source: ADUXVKIYN+N6DrXKxbr+vSqiFz/UVvDZ2K35RQRE/KE90PC6kEFplzgDeGUdkaPGnfyzEN3G7fD3hQ== X-Received: by 2002:ac8:23d4:: with SMTP id r20-v6mr2773538qtr.17.1528394822312; Thu, 07 Jun 2018 11:07:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell Date: Thu, 7 Jun 2018 15:06:38 -0300 Message-Id: <20180607180641.874-5-f4bug@amsat.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180607180641.874-1-f4bug@amsat.org> References: <20180607180641.874-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::22b Subject: [Qemu-devel] [PATCH v2 4/7] sdcard: Disable SEND_IF_COND (CMD8) for Spec v1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Crosthwaite , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Paul Brook , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 CMD8 is "Reserved" in Spec v1.10. Spec v2.00 introduces the SEND_IF_COND command: 6.4.1 Power Up CMD8 is newly added in the Physical Layer Specification Version 2.00 to support multiple voltage ranges and used to check whether the card supports supplied voltage. The version 2.00 or later host shall issue CMD8 and verify voltage before card initialization. The host that does not support CMD8 shall supply high voltage range. Message-Id: 201204252110.20873.paul@codesourcery.com Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/sd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 1ae085de69..3ec0f71f24 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1018,7 +1018,9 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, S= DRequest req) break; =20 case 8: /* CMD8: SEND_IF_COND */ - /* Physical Layer Specification Version 2.00 command */ + if (sd->spec_version < SD_PHY_SPECv2_00_VERS) { + break; + } if (sd->state !=3D sd_idle_state) { break; } --=20 2.17.1