From nobody Tue Feb 10 16:22:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528125402826178.36425388690327; Mon, 4 Jun 2018 08:16:42 -0700 (PDT) Received: from localhost ([::1]:40293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrDi-0006iX-8z for importer@patchew.org; Mon, 04 Jun 2018 11:16:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPrBr-0005gK-RM for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPrBq-0001g1-Vw for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:35 -0400 Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]:39193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fPrBq-0001fJ-Rk for qemu-devel@nongnu.org; Mon, 04 Jun 2018 11:14:34 -0400 Received: by mail-qk0-x232.google.com with SMTP id g14-v6so12898759qkm.6 for ; Mon, 04 Jun 2018 08:14:34 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id f9-v6sm18192856qtl.96.2018.06.04.08.14.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 08:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nDt3cA8K7cKSYmoKiitoGFHjMSdxoz2jn9n4cbinW7s=; b=XMBBgIf9dbSkO+4lOLUP45Bs361FXKqMIEvYBWxAR1WLMvSzA/aMUmW8xsD5UuJxRK k6JI+Wz0ByNI9UMfQdGhakcO/Za/SqX4ftOBExy/174TKtKGnt/BXiuWq9I/iuWQTl+M umeNJ7lw7AqKZ07Qf0mpeTDmUwJF9mS1Tn9hKCXCtLdGMzJjhaB0OG9a9UySZ5GlRWH6 Xe6LrVbLEPhOnS/Iu3OQPpkAvAaxGnhvjRnQtqikUgNWk8hfFvFjzV2pe1G3nBDiJHyQ utnQjvdxX+X7sw9b0Omt8+MEm+j3SgNP2qqbTQIFccJ0IIhhUo2IPMSEDuMnz9Fxz7je 4htA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nDt3cA8K7cKSYmoKiitoGFHjMSdxoz2jn9n4cbinW7s=; b=FrhETxUpiUlMpRC4ymEja8Dz+pFV5rgI9DNtcv4SMtJEwEpuVO5vQuLTy9yoOWJxyJ UNR8Yi2YG99XMnNIr/eB9SGk1vSzYX6q1pSLwUQTN7SxaHBUZkn3Y37jeL0xsVY9pJaY qYOuv6tL1Ybxcu+KGarSqGW0Eo191cOQBxyEHztYRR0+HB2mFjjrmsJSfvTX3FSmHJmv JgaolY2IosBZgjJ/7RP7DJz+pDA4qYYHQZhpn0madjsvlUyhI47jXfwOgHJGIIi8GIRf TO/PDZVvfuAh2lzYhn+fGaJiD6VSOXSwrNTkmVp8BTkY7DFpyXqyzMC5//hpPMzOKMhS FwcA== X-Gm-Message-State: APt69E3Z/jly4vv+zdAfoe1WLsPijsy7lGiTvAbF9zEGDn421TZ+CTiZ 6ODASl1lsI5NEIhl8tsrLPY= X-Google-Smtp-Source: ADUXVKIkwYosEQkY7x5XLH6E/xj+ZvQD6LUdqlD3ScAD1R1R3Dn5dPgSVXyMDlFQjcJRL0ZzwxQH/g== X-Received: by 2002:a37:4249:: with SMTP id p70-v6mr13179823qka.297.1528125274386; Mon, 04 Jun 2018 08:14:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Gerd Hoffmann Date: Mon, 4 Jun 2018 12:14:20 -0300 Message-Id: <20180604151421.23385-3-f4bug@amsat.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180604151421.23385-1-f4bug@amsat.org> References: <20180604151421.23385-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::232 Subject: [Qemu-devel] [PATCH v2 2/3] usb/dev-mtp: Fix use of uninitialized values X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 This fixes: hw/usb/dev-mtp.c:971:5: warning: 4th function call argument is an uniniti= alized value trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); ^~~~~~~~~~ and: hw/usb/dev-mtp.c:981:12: warning: Assigned value is garbage or undefined offset =3D c->argv[1]; ^ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 560c61c7c1..b0ab6a7912 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1017,12 +1017,16 @@ static MTPData *usb_mtp_get_object(MTPState *s, MTP= Control *c, static MTPData *usb_mtp_get_partial_object(MTPState *s, MTPControl *c, MTPObject *o) { - MTPData *d =3D usb_mtp_data_alloc(c); + MTPData *d; off_t offset; =20 + if (c->argc <=3D 2) { + return NULL; + } trace_usb_mtp_op_get_partial_object(s->dev.addr, o->handle, o->path, c->argv[1], c->argv[2]); =20 + d =3D usb_mtp_data_alloc(c); d->fd =3D open(o->path, O_RDONLY); if (d->fd =3D=3D -1) { usb_mtp_data_free(d); --=20 2.17.1