From nobody Tue Feb 10 03:37:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1527210073578159.94077195731586; Thu, 24 May 2018 18:01:13 -0700 (PDT) Received: from localhost ([::1]:41298 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fM16Q-0006wP-Mv for importer@patchew.org; Thu, 24 May 2018 21:01:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fM14c-0005pB-VO for qemu-devel@nongnu.org; Thu, 24 May 2018 20:59:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fM14Z-0005DH-1Q for qemu-devel@nongnu.org; Thu, 24 May 2018 20:59:14 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47964 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fM14Y-0005D6-Rx for qemu-devel@nongnu.org; Thu, 24 May 2018 20:59:10 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 48C90859AA; Fri, 25 May 2018 00:59:10 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-126-90.rdu2.redhat.com [10.10.126.90]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C04AE2023487; Fri, 25 May 2018 00:59:09 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Thu, 24 May 2018 20:58:37 -0400 Message-Id: <20180525005839.11556-4-crosa@redhat.com> In-Reply-To: <20180525005839.11556-1-crosa@redhat.com> References: <20180525005839.11556-1-crosa@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 25 May 2018 00:59:10 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 25 May 2018 00:59:10 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'crosa@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH 3/5] Acceptance tests: add quick VNC tests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Amador Pahim , Stefan Hajnoczi , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch adds a few simple behavior tests for VNC. These tests introduce manipulation of the QEMUMachine arguments, by setting the arguments, instead of adding to the existing ones. Signed-off-by: Cleber Rosa --- tests/acceptance/test_vnc.py | 50 ++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 tests/acceptance/test_vnc.py diff --git a/tests/acceptance/test_vnc.py b/tests/acceptance/test_vnc.py new file mode 100644 index 0000000000..9d9a35cf55 --- /dev/null +++ b/tests/acceptance/test_vnc.py @@ -0,0 +1,50 @@ +from avocado_qemu import Test + + +class Vnc(Test): + """ + :avocado: enable + :avocado: tags=3Dvnc,quick + """ + def test_no_vnc(self): + self.vm.add_args('-nodefaults', '-S') + self.vm.launch() + self.assertFalse(self.vm.qmp('query-vnc')['return']['enabled']) + + def test_no_vnc_change_password(self): + self.vm.add_args('-nodefaults', '-S') + self.vm.launch() + self.assertFalse(self.vm.qmp('query-vnc')['return']['enabled']) + set_password_response =3D self.vm.qmp('change', + device=3D'vnc', + target=3D'password', + arg=3D'new_password') + self.assertIn('error', set_password_response) + self.assertEqual(set_password_response['error']['class'], + 'GenericError') + self.assertEqual(set_password_response['error']['desc'], + 'Could not set password') + + def test_vnc_change_password_requires_a_password(self): + self.vm.add_args('-nodefaults', '-S', '-vnc', ':0') + self.vm.launch() + self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled']) + set_password_response =3D self.vm.qmp('change', + device=3D'vnc', + target=3D'password', + arg=3D'new_password') + self.assertIn('error', set_password_response) + self.assertEqual(set_password_response['error']['class'], + 'GenericError') + self.assertEqual(set_password_response['error']['desc'], + 'Could not set password') + + def test_vnc_change_password(self): + self.vm.add_args('-nodefaults', '-S', '-vnc', ':0,password') + self.vm.launch() + self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled']) + set_password_response =3D self.vm.qmp('change', + device=3D'vnc', + target=3D'password', + arg=3D'new_password') + self.assertEqual(set_password_response['return'], {}) --=20 2.17.0