From nobody Mon Feb 9 06:49:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152720138192756.158719224730476; Thu, 24 May 2018 15:36:21 -0700 (PDT) Received: from localhost ([::1]:40932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLyqK-0005FH-Lq for importer@patchew.org; Thu, 24 May 2018 18:36:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLypC-0004jB-5Y for qemu-devel@nongnu.org; Thu, 24 May 2018 18:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLyp8-0004SG-Vy for qemu-devel@nongnu.org; Thu, 24 May 2018 18:35:10 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:37252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fLyp8-0004S1-S2 for qemu-devel@nongnu.org; Thu, 24 May 2018 18:35:06 -0400 Received: by mail-qt0-x241.google.com with SMTP id q13-v6so4227540qtp.4 for ; Thu, 24 May 2018 15:35:06 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id j7-v6sm15438271qth.35.2018.05.24.15.35.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 15:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=B/P6zVVx/vfRCKeWo3i7W1x5uAPzpCotlUx0Cd0tvQQ=; b=t6Xd5RicIRHr/PBDievKqw7yxlC25WKMocHdrRk7aErZjA9uS33GEYCogc2qYfi76f inRx+n4xnC1aGPD99at78X/wej7SM42p3ixmPUVmS4S451GUMwD9xI/HqAsBHRdbxmV1 HkGVF/hudkjQXapVa7U4nNsv+s/K7BJ9NdStTTdaNyuhDt8+DybNU0vFUce0+r6+b09M kaOQ2mRmpkq5wLNSu7hCl/lCUzNIfB/srr2vlf/jWRidtbm+j3VuL1W7FBTuwH9Kl72S iej+L2H+mrSIWIgCkTvK1cUSPd60ke4+dZRK/FpFVjqPpNVpnh4yc21xFvSPTozP9w5b 3lhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=B/P6zVVx/vfRCKeWo3i7W1x5uAPzpCotlUx0Cd0tvQQ=; b=DE59zF/xAaYF+odCFjp0hGc4VyxqbZ2T9cuQQFMW2m23Xpu1uL7CG8oFZAhtl+Bha8 ZrCe+uT8aXFbYVR+na8YHTMiwxVcoaTbT5zMs3PNl1tCUFtFlry57WfMrMWuHzSLVBYq 2i2klG0ge/0PxscbnHfIXX4gR6fQbZ8BSWswyfPsDrxErAda8kQwCX3s+fWyGIkMvIFs umK4hJc+UR0kohuk225+mxQf6L3rtBwONbdVi2M/CU4uMKAPvUDc2Lvg2cuZuvpsWB8n GJLV5b+lpXHTSVR3Zog44Zgzrkn8N71PiA5Qd/FhitWJO7sFQBS4+ZHhZqnmDFM6Rss8 6mwQ== X-Gm-Message-State: ALKqPwf0zWq0PPpJlhNeHrBEmJvPDfFRxEVBxZ0TkzU+gHA5Y8eBO95d +AmSxdTTpZRCT9JKbMKxr2U= X-Google-Smtp-Source: ADUXVKJSA/cxIs4SqhIdgtM5tC7NvUd/gy1n74q/3Wfm4lIwTxtA75YaF9rkR20AvjU0Hmon9QIz4A== X-Received: by 2002:aed:3aa4:: with SMTP id o33-v6mr9392028qte.186.1527201306326; Thu, 24 May 2018 15:35:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Paolo Bonzini Date: Thu, 24 May 2018 19:34:58 -0300 Message-Id: <20180524223458.5651-1-f4bug@amsat.org> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH] gdbstub: Prevent fd leakage X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Michael Tokarev , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Since 2f652224f7, we now check if socket_set_nodelay() errored, but forgot to close the socket before reporting an error. Fixes: Coverity CID 1391290 (RESOURCE_LEAK) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Thomas Huth --- gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub.c b/gdbstub.c index e4ece2f5bc..9c860cd81c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1836,6 +1836,7 @@ static bool gdb_accept(void) /* set short latency */ if (socket_set_nodelay(fd)) { perror("setsockopt"); + close(fd); return false; } =20 --=20 2.17.0