From nobody Wed May 8 04:36:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526961507363358.0113342928679; Mon, 21 May 2018 20:58:27 -0700 (PDT) Received: from localhost ([::1]:53474 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKyRL-0005HI-2M for importer@patchew.org; Mon, 21 May 2018 23:58:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKyPh-0004T0-ME for qemu-devel@nongnu.org; Mon, 21 May 2018 23:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKyPg-0002zV-WC for qemu-devel@nongnu.org; Mon, 21 May 2018 23:56:41 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35138 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fKyPg-0002z9-RP for qemu-devel@nongnu.org; Mon, 21 May 2018 23:56:40 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 50B4E401EF0F for ; Tue, 22 May 2018 03:56:40 +0000 (UTC) Received: from xz-mi.nay.redhat.com (dhcp-14-151.nay.redhat.com [10.66.14.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40CFB10E60DA; Tue, 22 May 2018 03:56:37 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Tue, 22 May 2018 11:56:28 +0800 Message-Id: <20180522035629.30428-2-peterx@redhat.com> In-Reply-To: <20180522035629.30428-1-peterx@redhat.com> References: <20180522035629.30428-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 22 May 2018 03:56:40 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 22 May 2018 03:56:40 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'peterx@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v2 1/2] qemu-error: introduce {error|warn}_report_once X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Markus Armbruster , peterx@redhat.com, "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" I stole the printk_once() macro. I always wanted to be able to print some error directly if there is a buffer to dump, however we can't use error_report() where the code path can be triggered by DDOS attack. To avoid that, we can introduce a print-once-like function for it. Meanwhile, we also introduce the corresponding helper for warn_report(). CC: Markus Armbruster Signed-off-by: Peter Xu --- include/qemu/error-report.h | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h index e1c8ae1a52..3e6e84801f 100644 --- a/include/qemu/error-report.h +++ b/include/qemu/error-report.h @@ -44,6 +44,32 @@ void error_report(const char *fmt, ...) GCC_FMT_ATTR(1, = 2); void warn_report(const char *fmt, ...) GCC_FMT_ATTR(1, 2); void info_report(const char *fmt, ...) GCC_FMT_ATTR(1, 2); =20 +/* Similar to error_report(), but it only prints the message once. */ +#define error_report_once(fmt, ...) \ + ({ \ + static bool __print_once; \ + bool __ret_print_once =3D !__print_once; \ + \ + if (!__print_once) { \ + __print_once =3D true; \ + error_report(fmt, ##__VA_ARGS__); \ + } \ + unlikely(__ret_print_once); \ + }) + +/* Similar to warn_report(), but it only prints the message once. */ +#define warn_report_once(fmt, ...) \ + ({ \ + static bool __print_once; \ + bool __ret_print_once =3D !__print_once; \ + \ + if (!__print_once) { \ + __print_once =3D true; \ + warn_report(fmt, ##__VA_ARGS__); \ + } \ + unlikely(__ret_print_once); \ + }) + const char *error_get_progname(void); extern bool enable_timestamp_msg; =20 --=20 2.17.0 From nobody Wed May 8 04:36:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526961510711323.5311490117955; Mon, 21 May 2018 20:58:30 -0700 (PDT) Received: from localhost ([::1]:53475 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKyRR-0005Ls-Uk for importer@patchew.org; Mon, 21 May 2018 23:58:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKyPk-0004UP-Vs for qemu-devel@nongnu.org; Mon, 21 May 2018 23:56:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKyPj-00031K-KE for qemu-devel@nongnu.org; Mon, 21 May 2018 23:56:45 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45486 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fKyPj-000311-EM for qemu-devel@nongnu.org; Mon, 21 May 2018 23:56:43 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAC807D83A for ; Tue, 22 May 2018 03:56:42 +0000 (UTC) Received: from xz-mi.nay.redhat.com (dhcp-14-151.nay.redhat.com [10.66.14.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA7FA10E51A0; Tue, 22 May 2018 03:56:40 +0000 (UTC) From: Peter Xu To: qemu-devel@nongnu.org Date: Tue, 22 May 2018 11:56:29 +0800 Message-Id: <20180522035629.30428-3-peterx@redhat.com> In-Reply-To: <20180522035629.30428-1-peterx@redhat.com> References: <20180522035629.30428-1-peterx@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 22 May 2018 03:56:42 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 22 May 2018 03:56:42 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'peterx@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v2 2/2] intel-iommu: start to use error_report_once X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Markus Armbruster , peterx@redhat.com, "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Replace existing trace_vtd_err() with error_report_once() then stderr will capture something if any of the error happens, meanwhile we don't suffer from any DDOS. Then remove the trace point. Signed-off-by: Peter Xu Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/intel_iommu.c | 34 +++++++++++++++++----------------- hw/i386/trace-events | 1 - 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index fb31de9416..cf655fb9f6 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -285,14 +285,14 @@ static void vtd_generate_fault_event(IntelIOMMUState = *s, uint32_t pre_fsts) { if (pre_fsts & VTD_FSTS_PPF || pre_fsts & VTD_FSTS_PFO || pre_fsts & VTD_FSTS_IQE) { - trace_vtd_err("There are previous interrupt conditions " + error_report_once("There are previous interrupt conditions " "to be serviced by software, fault event " "is not generated."); return; } vtd_set_clear_mask_long(s, DMAR_FECTL_REG, 0, VTD_FECTL_IP); if (vtd_get_long_raw(s, DMAR_FECTL_REG) & VTD_FECTL_IM) { - trace_vtd_err("Interrupt Mask set, irq is not generated."); + error_report_once("Interrupt Mask set, irq is not generated."); } else { vtd_generate_interrupt(s, DMAR_FEADDR_REG, DMAR_FEDATA_REG); vtd_set_clear_mask_long(s, DMAR_FECTL_REG, VTD_FECTL_IP, 0); @@ -400,19 +400,19 @@ static void vtd_report_dmar_fault(IntelIOMMUState *s,= uint16_t source_id, trace_vtd_dmar_fault(source_id, fault, addr, is_write); =20 if (fsts_reg & VTD_FSTS_PFO) { - trace_vtd_err("New fault is not recorded due to " + error_report_once("New fault is not recorded due to " "Primary Fault Overflow."); return; } =20 if (vtd_try_collapse_fault(s, source_id)) { - trace_vtd_err("New fault is not recorded due to " + error_report_once("New fault is not recorded due to " "compression of faults."); return; } =20 if (vtd_is_frcd_set(s, s->next_frcd_reg)) { - trace_vtd_err("Next Fault Recording Reg is used, " + error_report_once("Next Fault Recording Reg is used, " "new fault is not recorded, set PFO field."); vtd_set_clear_mask_long(s, DMAR_FSTS_REG, 0, VTD_FSTS_PFO); return; @@ -421,7 +421,7 @@ static void vtd_report_dmar_fault(IntelIOMMUState *s, u= int16_t source_id, vtd_record_frcd(s, s->next_frcd_reg, source_id, addr, fault, is_write); =20 if (fsts_reg & VTD_FSTS_PPF) { - trace_vtd_err("There are pending faults already, " + error_report_once("There are pending faults already, " "fault event is not generated."); vtd_set_frcd_and_update_ppf(s, s->next_frcd_reg); s->next_frcd_reg++; @@ -1339,7 +1339,7 @@ static uint64_t vtd_context_cache_invalidate(IntelIOM= MUState *s, uint64_t val) break; =20 default: - trace_vtd_err("Context cache invalidate type error."); + error_report_once("Context cache invalidate type error."); caig =3D 0; } return caig; @@ -1445,7 +1445,7 @@ static uint64_t vtd_iotlb_flush(IntelIOMMUState *s, u= int64_t val) am =3D VTD_IVA_AM(addr); addr =3D VTD_IVA_ADDR(addr); if (am > VTD_MAMV) { - trace_vtd_err("IOTLB PSI flush: address mask overflow."); + error_report_once("IOTLB PSI flush: address mask overflow."); iaig =3D 0; break; } @@ -1454,7 +1454,7 @@ static uint64_t vtd_iotlb_flush(IntelIOMMUState *s, u= int64_t val) break; =20 default: - trace_vtd_err("IOTLB flush: invalid granularity."); + error_report_once("IOTLB flush: invalid granularity."); iaig =3D 0; } return iaig; @@ -1604,7 +1604,7 @@ static void vtd_handle_ccmd_write(IntelIOMMUState *s) /* Context-cache invalidation request */ if (val & VTD_CCMD_ICC) { if (s->qi_enabled) { - trace_vtd_err("Queued Invalidation enabled, " + error_report_once("Queued Invalidation enabled, " "should not use register-based invalidation"); return; } @@ -1625,7 +1625,7 @@ static void vtd_handle_iotlb_write(IntelIOMMUState *s) /* IOTLB invalidation request */ if (val & VTD_TLB_IVT) { if (s->qi_enabled) { - trace_vtd_err("Queued Invalidation enabled, " + error_report_once("Queued Invalidation enabled, " "should not use register-based invalidation."); return; } @@ -1644,7 +1644,7 @@ static bool vtd_get_inv_desc(dma_addr_t base_addr, ui= nt32_t offset, dma_addr_t addr =3D base_addr + offset * sizeof(*inv_desc); if (dma_memory_read(&address_space_memory, addr, inv_desc, sizeof(*inv_desc))) { - trace_vtd_err("Read INV DESC failed."); + error_report_once("Read INV DESC failed."); inv_desc->lo =3D 0; inv_desc->hi =3D 0; return false; @@ -1999,7 +1999,7 @@ static uint64_t vtd_mem_read(void *opaque, hwaddr add= r, unsigned size) trace_vtd_reg_read(addr, size); =20 if (addr + size > DMAR_REG_SIZE) { - trace_vtd_err("Read MMIO over range."); + error_report_once("Read MMIO over range."); return (uint64_t)-1; } =20 @@ -2050,7 +2050,7 @@ static void vtd_mem_write(void *opaque, hwaddr addr, trace_vtd_reg_write(addr, size, val); =20 if (addr + size > DMAR_REG_SIZE) { - trace_vtd_err("Write MMIO over range."); + error_report_once("Write MMIO over range."); return; } =20 @@ -2432,7 +2432,7 @@ static int vtd_irte_get(IntelIOMMUState *iommu, uint1= 6_t index, addr =3D iommu->intr_root + index * sizeof(*entry); if (dma_memory_read(&address_space_memory, addr, entry, sizeof(*entry))) { - trace_vtd_err("Memory read failed for IRTE."); + error_report_once("Memory read failed for IRTE."); return -VTD_FR_IR_ROOT_INVAL; } =20 @@ -2564,14 +2564,14 @@ static int vtd_interrupt_remap_msi(IntelIOMMUState = *iommu, } =20 if (origin->address & VTD_MSI_ADDR_HI_MASK) { - trace_vtd_err("MSI address high 32 bits non-zero when " + error_report_once("MSI address high 32 bits non-zero when " "Interrupt Remapping enabled."); return -VTD_FR_IR_REQ_RSVD; } =20 addr.data =3D origin->address & VTD_MSI_ADDR_LO_MASK; if (addr.addr.__head !=3D 0xfee) { - trace_vtd_err("MSI addr low 32 bit invalid."); + error_report_once("MSI addr low 32 bit invalid."); return -VTD_FR_IR_REQ_RSVD; } =20 diff --git a/hw/i386/trace-events b/hw/i386/trace-events index 22d44648af..e08cf2a9a7 100644 --- a/hw/i386/trace-events +++ b/hw/i386/trace-events @@ -68,7 +68,6 @@ vtd_ir_remap_msi_req(uint64_t addr, uint64_t data) "addr = 0x%"PRIx64" data 0x%"PR vtd_fsts_ppf(bool set) "FSTS PPF bit set to %d" vtd_fsts_clear_ip(void) "" vtd_frr_new(int index, uint64_t hi, uint64_t lo) "index %d high 0x%"PRIx64= " low 0x%"PRIx64 -vtd_err(const char *str) "%s" vtd_err_dmar_iova_overflow(uint64_t iova) "iova 0x%"PRIx64 vtd_err_dmar_slpte_read_error(uint64_t iova, int level) "iova 0x%"PRIx64" = level %d" vtd_err_dmar_slpte_perm_error(uint64_t iova, int level, uint64_t slpte, bo= ol is_write) "iova 0x%"PRIx64" level %d slpte 0x%"PRIx64" write %d" --=20 2.17.0