From nobody Sat Apr 27 13:03:40 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526898997581342.6925386612428; Mon, 21 May 2018 03:36:37 -0700 (PDT) Received: from localhost ([::1]:49765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKiB0-0001pK-8A for importer@patchew.org; Mon, 21 May 2018 06:36:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKi9s-0001QH-R9 for qemu-devel@nongnu.org; Mon, 21 May 2018 06:35:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKi9o-0004cT-Th for qemu-devel@nongnu.org; Mon, 21 May 2018 06:35:16 -0400 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]:46782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKi9o-0004bJ-MQ for qemu-devel@nongnu.org; Mon, 21 May 2018 06:35:12 -0400 Received: by mail-wr0-x22c.google.com with SMTP id x9-v6so12623712wrl.13 for ; Mon, 21 May 2018 03:35:12 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id z66-v6sm13616750wme.13.2018.05.21.03.35.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 May 2018 03:35:10 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id DC9B13E01D7; Mon, 21 May 2018 11:35:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CIwTKMK4qchus228T/2oMGk0w0PzooyIQONrteB6LCg=; b=dbpW5ETlgDb7lmChMZedRzSjZR7ey6hb7SK30qETEHnjQd69QE0rBq6c2ucB3XElHr r+QJg5c0fdhxuZizxN7mKMM9v1Rw59A0PCtI+zVfRflLpK5qct+O1LRBJjd5VsXTqCU/ tbP910qCRB//YX/wuoxRUKCcJjq4LVDo1ODKc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CIwTKMK4qchus228T/2oMGk0w0PzooyIQONrteB6LCg=; b=XP6Ynl+gNN8A4/JQxbjipTXJfIlzwRc/E1Yg0weDYZUq/MxbCAZNTtkg12IwhrcPps yvRkGxc1NLTHSVZeC23PVE3/+oPuDVjrfeg8xgHLBAUDW7ZBX4WLkx77NRPDjPoTTXBg eJuJ4uxj3moZbpBj3iDtg2jxUexqbKXsnZFKLy7U4/fCDLHmwKBUmFIuOr/JTRcVNxmQ LY4bs4EqHRhVa5wYh7lPNTCEB8awYuvkoKYOOvJq4W3F+76NoWAR3J/BRl6xHkLTnHIz Iuoy1KYOrCg6siOF/MibPZabAlYur0WxRWnxcdLxfKaDrS1cDHeuEucRbey1XSl4imUj 7CXg== X-Gm-Message-State: ALKqPwcCwSaeFtpiDuPt1xM86UjLXjjB7kbQja5TEkJm9T9ZLaJwATvI onFoN29nFzBtKERiSf+TaIyQvw== X-Google-Smtp-Source: AB8JxZqQ7uXp+Zk6WPqJoLxO9bj0RNYdKKzgjvTxm2gjixHz4C+I99zEBLlGTPasy7AHqQWb5e6Z1g== X-Received: by 2002:adf:ad61:: with SMTP id p88-v6mr14364931wrc.24.1526898911217; Mon, 21 May 2018 03:35:11 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: famz@redhat.com Date: Mon, 21 May 2018 11:35:04 +0100 Message-Id: <20180521103504.26432-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22c Subject: [Qemu-devel] [PATCH v2] tests/docker/Makefile.include: handle empty TARGET_LIST X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 If the user doesn't specify a TARGET_LIST they get the current configuration but with spaces and hilarity ensues. This adds some make magic to turn the TARGET_LIST back into a comma separated list. Signed-off-by: Alex Benn=C3=A9e --- v2 - use common $(SPACE) and $(COMMA) in rules.mak --- rules.mak | 3 +++ tests/docker/Makefile.include | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/rules.mak b/rules.mak index 04c7f74d07..bbb2667928 100644 --- a/rules.mak +++ b/rules.mak @@ -1,4 +1,7 @@ =20 +# These are used when we want to do substitutions without confusing Make +NULL :=3D +SPACE :=3D $(NULL) # COMMA :=3D , =20 # Don't use implicit rules or variables diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index d00887bdf1..e911d44d9f 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -148,7 +148,7 @@ docker-run: docker-qemu-src $(if $V,,--rm) \ $(if $(DEBUG),-ti,) \ $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=3D$(NETWORK)),--net= =3Dnone) \ - -e TARGET_LIST=3D$(TARGET_LIST) \ + -e TARGET_LIST=3D$(subst $(SPACE),$(COMMA),$(TARGET_LIST)) \ -e EXTRA_CONFIGURE_OPTS=3D"$(EXTRA_CONFIGURE_OPTS)" \ -e V=3D$V -e J=3D$J -e DEBUG=3D$(DEBUG) \ -e SHOW_ENV=3D$(SHOW_ENV) \ --=20 2.17.0