From nobody Thu Oct 30 15:17:00 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526549229211225.20196975679426; Thu, 17 May 2018 02:27:09 -0700 (PDT) Received: from localhost ([::1]:44916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJFBg-0007Gt-S4 for importer@patchew.org; Thu, 17 May 2018 05:27:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJFA1-0006Om-JG for qemu-devel@nongnu.org; Thu, 17 May 2018 05:25:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJF9x-0004Xx-Fn for qemu-devel@nongnu.org; Thu, 17 May 2018 05:25:21 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56466 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJF9w-0004Wq-TE for qemu-devel@nongnu.org; Thu, 17 May 2018 05:25:17 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80F5F81663C0 for ; Thu, 17 May 2018 09:25:16 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-49.ams2.redhat.com [10.36.116.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59DC11002965; Thu, 17 May 2018 09:25:14 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D774A31E28; Thu, 17 May 2018 11:25:13 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Thu, 17 May 2018 11:25:12 +0200 Message-Id: <20180517092513.735-4-kraxel@redhat.com> In-Reply-To: <20180517092513.735-1-kraxel@redhat.com> References: <20180517092513.735-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 17 May 2018 09:25:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 17 May 2018 09:25:16 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'kraxel@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH 3/4] bochs-display: add dirty tracking support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/display/bochs-display.c | 33 ++++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index beeda58475..9ea6f798f4 100644 --- a/hw/display/bochs-display.c +++ b/hw/display/bochs-display.c @@ -192,9 +192,13 @@ nofb: static void bochs_display_update(void *opaque) { BochsDisplayState *s =3D opaque; + DirtyBitmapSnapshot *snap =3D NULL; + bool full_update =3D false; BochsDisplayMode mode; DisplaySurface *ds; uint8_t *ptr; + bool dirty; + int y, ys; =20 bochs_display_get_mode(s, &mode); if (!mode.size) { @@ -212,9 +216,34 @@ static void bochs_display_update(void *opaque) mode.stride, ptr + mode.offset); dpy_gfx_replace_surface(s->con, ds); + full_update =3D true; } =20 - dpy_gfx_update_full(s->con); + if (full_update) { + dpy_gfx_update_full(s->con); + } else { + snap =3D memory_region_snapshot_and_clear_dirty(&s->vram, + mode.offset, mode.si= ze, + DIRTY_MEMORY_VGA); + ys =3D -1; + for (y =3D 0; y < mode.height; y++) { + dirty =3D memory_region_snapshot_get_dirty(&s->vram, snap, + mode.offset + mode.st= ride * y, + mode.stride); + if (dirty && ys < 0) { + ys =3D y; + } + if (!dirty && ys >=3D 0) { + dpy_gfx_update(s->con, 0, ys, + mode.width, y - ys); + ys =3D -1; + } + } + if (ys >=3D 0) { + dpy_gfx_update(s->con, 0, ys, + mode.width, y - ys); + } + } } =20 static const GraphicHwOps bochs_display_gfx_ops =3D { @@ -250,6 +279,8 @@ static void bochs_display_realize(PCIDevice *dev, Error= **errp) pci_set_byte(&s->pci.config[PCI_REVISION_ID], 2); pci_register_bar(&s->pci, 0, PCI_BASE_ADDRESS_MEM_PREFETCH, &s->vram); pci_register_bar(&s->pci, 2, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mmio); + + memory_region_set_log(&s->vram, true, DIRTY_MEMORY_VGA); } =20 static bool bochs_display_get_big_endian_fb(Object *obj, Error **errp) --=20 2.9.3