From nobody Mon Feb 9 17:06:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526497556404102.98390923232193; Wed, 16 May 2018 12:05:56 -0700 (PDT) Received: from localhost ([::1]:34250 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJ1kH-0005UN-Aa for importer@patchew.org; Wed, 16 May 2018 15:05:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJ1XK-0003Nv-Mq for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJ1XJ-0000rs-RT for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:30 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:39418) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fJ1XJ-0000rV-Kg for qemu-devel@nongnu.org; Wed, 16 May 2018 14:52:29 -0400 Received: by mail-wm0-x241.google.com with SMTP id f8-v6so4256258wmc.4 for ; Wed, 16 May 2018 11:52:29 -0700 (PDT) Received: from gmail.com (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id g71-v6sm774226lfh.85.2018.05.16.11.52.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 May 2018 11:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KUALcK3vECLrM/JqhYp21vezhk8mqpk1PiWa6PxbHME=; b=UJYtedCeB2KQNevIrfcv8ID5JAYEwOVsMCle8bgjPykhjIgPHPr/bCny0xn/Zu+EZJ mCd6llT8+8ZWrFOXWeIoKrHFMREfyJ18qoZkud6R3NOUOJ/q9rrbsgpzRcKJES1BBhi5 1HrcjmffVjy4m69BD7mwecCh+OhErKddrHKIJT2phtKSW72d3zTsMJP2sKjFOZq4/4UG 9w1ubEd/x9lHgFSC2K2Y+lMoQk03A6IYn69mv1Hp66PyGfCjLseTQQsvSQc5nUmsM2vR AO4CuDg0eb72WDZsxG1MpJMo2ws2htwRA1LZRhYprwjkZ5ywEuLWvKpBWAbu8v7RWjpf tiCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KUALcK3vECLrM/JqhYp21vezhk8mqpk1PiWa6PxbHME=; b=UU7cGt862L0FAh6q5GJbVIZNQSguWCCjrDuE180nWMIJhIskFwDU41qRzqQk4gXa77 A8NByTcyg3MIdfCQdXSKjlNXN06PqOh+mawP2lXu9r+tEITumGp+jdDP1gGvjGP12AKk 1eBh64r6dEJWG3xz1ogTC4TunkgbcBI70T2CJKKRIdlMW7Q8DuMZkeTFGvSwfTlZWDqr lIYdLWLNQeidIY71jJUm9xGEtPY05uRIxW8zsXvxUyDQz1hDFJLoZZqEEopkrAX/NOyd 5nqVku5M3kwVHzMsOu/nvswteODECYSDy2ILbuIyZQqW7rdb7cKFQvmJDh2X5cizqfU2 knbg== X-Gm-Message-State: ALKqPweT3HrQzjsfI2OwI9eUVR3ylSzlUigDWicvwnrY7jCNuoZZaMEi Wvt1Ckk88c3p5I1PrazqZgk2Vg== X-Google-Smtp-Source: AB8JxZr2kYpd0uGMNod1F4awhIjbpPeLIMZiVXWw7Ul2H6pw74E+rUBS+W6SF0/sKbIH6xUiQCpoVQ== X-Received: by 2002:a2e:1545:: with SMTP id 5-v6mr1289825ljv.56.1526496748267; Wed, 16 May 2018 11:52:28 -0700 (PDT) From: "Edgar E. Iglesias" To: qemu-devel@nongnu.org Date: Wed, 16 May 2018 20:51:33 +0200 Message-Id: <20180516185146.30708-26-edgar.iglesias@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180516185146.30708-1-edgar.iglesias@gmail.com> References: <20180516185146.30708-1-edgar.iglesias@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PATCH v3 25/38] target-microblaze: mmu: Remove unused register state X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, sstabellini@kernel.org, sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com, alistair@alistair23.me, richard.henderson@linaro.org, frederic.konrad@adacore.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Edgar E. Iglesias" Add explicit handling for MMU_R_TLBX and log accesses to invalid MMU registers. We can now remove the state for all regs but PID, ZPR and TLBX (0 - 2). Reviewed-by: Richard Henderson Signed-off-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/microblaze/mmu.c | 7 +++++-- target/microblaze/mmu.h | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index f4a4c339c9..231803ceea 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -211,11 +211,14 @@ uint32_t mmu_read(CPUMBState *env, uint32_t rn) } r =3D env->mmu.regs[rn]; break; + case MMU_R_TLBX: + r =3D env->mmu.regs[rn]; + break; case MMU_R_TLBSX: qemu_log_mask(LOG_GUEST_ERROR, "TLBSX is write-only.\n"); break; default: - r =3D env->mmu.regs[rn]; + qemu_log_mask(LOG_GUEST_ERROR, "Invalid MMU register %d.\n", r= n); break; } D(qemu_log("%s rn=3D%d=3D%x\n", __func__, rn, r)); @@ -298,7 +301,7 @@ void mmu_write(CPUMBState *env, uint32_t rn, uint32_t v) break; } default: - env->mmu.regs[rn] =3D v; + qemu_log_mask(LOG_GUEST_ERROR, "Invalid MMU register %d.\n", r= n); break; } } diff --git a/target/microblaze/mmu.h b/target/microblaze/mmu.h index 113539c6e9..624becfded 100644 --- a/target/microblaze/mmu.h +++ b/target/microblaze/mmu.h @@ -67,7 +67,7 @@ struct microblaze_mmu /* We keep a separate ram for the tids to avoid the 48 bit tag width. = */ uint8_t tids[TLB_ENTRIES]; /* Control flops. */ - uint32_t regs[8]; + uint32_t regs[3]; =20 int c_mmu; int c_mmu_tlb_access; --=20 2.14.1