From nobody Mon Feb 9 19:30:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526394358223248.58179681917886; Tue, 15 May 2018 07:25:58 -0700 (PDT) Received: from localhost ([::1]:40421 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIatp-0002UB-Cx for importer@patchew.org; Tue, 15 May 2018 10:25:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIaeW-0006EJ-2h for qemu-devel@nongnu.org; Tue, 15 May 2018 10:10:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIaeQ-0005fm-4Z for qemu-devel@nongnu.org; Tue, 15 May 2018 10:10:08 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59818 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fIaeP-0005fH-VE for qemu-devel@nongnu.org; Tue, 15 May 2018 10:10:02 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4FE01aK123810 for ; Tue, 15 May 2018 10:10:01 -0400 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0b-001b2d01.pphosted.com with ESMTP id 2hyxh5qkwy-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 15 May 2018 10:10:00 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 15 May 2018 10:09:59 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 15 May 2018 10:09:57 -0400 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4FE9uPZ51708002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 15 May 2018 14:09:56 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 03C50112056; Tue, 15 May 2018 10:09:59 -0400 (EDT) Received: from heisenbug.br.ibm.com (unknown [9.18.235.77]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP id 13900112034; Tue, 15 May 2018 10:09:57 -0400 (EDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Date: Tue, 15 May 2018 11:09:44 -0300 X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180515140944.15979-1-danielhb@linux.ibm.com> References: <20180515140944.15979-1-danielhb@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18051514-0056-0000-0000-0000044EAAD3 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009029; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000260; SDB=6.01032676; UDB=6.00527959; IPR=6.00811807; MB=3.00021126; MTD=3.00000008; XFM=3.00000015; UTC=2018-05-15 14:09:59 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051514-0057-0000-0000-00000892BF14 Message-Id: <20180515140944.15979-3-danielhb@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-05-15_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805150143 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 Subject: [Qemu-devel] [PATCH v6 2/2] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , mdroth@linux.vnet.ibm.com, dgilbert@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the existence of 'system_wakeup' and also on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-target' QMP command. Reported-by: Balamuruhan S Signed-off-by: Daniel Henrique Barboza Reviewed-by: Michael Roth --- qga/qapi-schema.json | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 17884c7c70..e3fb8adfce 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -566,8 +566,11 @@ # package installed in the guest. # # IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-ram. +# command and the guest to support wake up from suspend. Thus, it's +# *required* to query QEMU for the presence of the 'system_wakeup' command +# and to verify that wake up from suspend is enabled by checking the +# 'wakeup-suspend-support' flag of 'query-target' QMP command, before issu= ing +# guest-suspend-ram. # # This command does NOT return a response on success. There are two options # to check for success: @@ -593,8 +596,11 @@ # This command requires the pm-utils package to be installed in the guest. # # IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wak= eup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-hybrid. +# command and the guest to support wake up from suspend. Thus, it's +# *required* to query QEMU for the presence of the 'system_wakeup' command +# and to verify that wake up from suspend is enabled by checking the +# 'wakeup-suspend-support' flag of 'query-target' QMP command, before issu= ing +# guest-suspend-hybrid. # # This command does NOT return a response on success. There are two options # to check for success: --=20 2.14.3