From nobody Sat Nov 1 08:16:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 15263360738882.8491508647441606; Mon, 14 May 2018 15:14:33 -0700 (PDT) Received: from localhost ([::1]:49878 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fILjl-0000oT-0F for importer@patchew.org; Mon, 14 May 2018 18:14:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fILhj-0007md-CK for qemu-devel@nongnu.org; Mon, 14 May 2018 18:12:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fILhg-0007I5-W6 for qemu-devel@nongnu.org; Mon, 14 May 2018 18:12:27 -0400 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]:41374) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fILhg-0007G0-Pf for qemu-devel@nongnu.org; Mon, 14 May 2018 18:12:24 -0400 Received: by mail-pl0-x241.google.com with SMTP id az12-v6so8144532plb.8 for ; Mon, 14 May 2018 15:12:24 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id y2-v6sm14512457pgp.92.2018.05.14.15.12.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 May 2018 15:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/eGeUttM52eudQ5TkxSYzl7bDNiiGBDFDqUuWF7ZJu0=; b=PDrBgN8mttkQhEeVsJ8cF+pl9Uh1C85TtECdJP14WvAzINkIT5cG+JAWvaWvv+8m/8 /AYlMKpUNsl8CYQYJZHJiPC2pv0xzzEb+pZtn+cz3GrAcat9nfr8m+GFVMUvw6jAU0r6 DAdWh5QBKAfPUkfeW2rTm3cy2CVU6PZzyUoRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/eGeUttM52eudQ5TkxSYzl7bDNiiGBDFDqUuWF7ZJu0=; b=Hmrh+UCOnbuesEYFOHbR6zWHubdn9yLjyyuNhJKOXmYPVTKfu273/o8PGf/D9qwjpy +vqq/OBmOBxj3Zr4Oe6SPpNAl5sgSL1GaXTOIeji9Um3RxbdoMFszzZ9zjody2/0EJSn GCeLS5LUdik8A7gAKpOiZPcvOZ8QPB9OTInJFoIt++oA51IvRD42ZIZ38Ho+HoqFNuMo 0E9Xr8t6FzZxcPmIwnZTzDHjdzY9XgJFv/4UNXEblaNMMlIIQIC9gUrNCCvNDg41GMBp HUg8yooxJnhCzrwc4BGG2tQyhff7DaljBn3LWDNhfvpC46aQxqwGWXYkyyDgLYwZAKsS ++8g== X-Gm-Message-State: ALKqPwf7QVd6WnakvDk4bzITeCeML0jkTuleYWzPytzVcjxDAaGjT1z/ 13VV4dgA3dvkbHi9Jwp2jwYA2d5KvsE= X-Google-Smtp-Source: AB8JxZqF7lnqtIPwOBuu1zi/K49EOGyKw02PlFWzHy4VUT3StgpIIr0bABvwQ0UZEH6FEBOMYTYd/A== X-Received: by 2002:a17:902:7288:: with SMTP id d8-v6mr11624458pll.218.1526335943603; Mon, 14 May 2018 15:12:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 14 May 2018 15:11:52 -0700 Message-Id: <20180514221219.7091-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180514221219.7091-1-richard.henderson@linaro.org> References: <20180514221219.7091-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::241 Subject: [Qemu-devel] [PATCH v5 01/28] fpu/softfloat: Fix conversion from uint64 to float128 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org, qemu-stable@nongnu.org, Petr Tesarik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Petr Tesarik The significand is passed to normalizeRoundAndPackFloat128() as high first, low second. The current code passes the integer first, so the result is incorrectly shifted left by 64 bits. This bug affects the emulation of s390x instruction CXLGBR (convert from logical 64-bit binary-integer operand to extended BFP result). Cc: qemu-stable@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Petr Tesarik Message-Id: <20180511071052.1443-1-ptesarik@suse.com> Signed-off-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- fpu/softfloat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index bc0f52fa54..d07419324a 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -3147,7 +3147,7 @@ float128 uint64_to_float128(uint64_t a, float_status = *status) if (a =3D=3D 0) { return float128_zero; } - return normalizeRoundAndPackFloat128(0, 0x406E, a, 0, status); + return normalizeRoundAndPackFloat128(0, 0x406E, 0, a, status); } =20 =20 --=20 2.17.0