From nobody Sat Nov 1 07:50:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526317602983913.3466360917797; Mon, 14 May 2018 10:06:42 -0700 (PDT) Received: from localhost ([::1]:47319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIGvl-0001Vn-Fc for importer@patchew.org; Mon, 14 May 2018 13:06:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIGlE-0008MB-ED for qemu-devel@nongnu.org; Mon, 14 May 2018 12:55:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIGlC-0005x3-Qi for qemu-devel@nongnu.org; Mon, 14 May 2018 12:55:44 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:40660) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fIGlC-0005wP-K1 for qemu-devel@nongnu.org; Mon, 14 May 2018 12:55:42 -0400 Received: by mail-pf0-x244.google.com with SMTP id f189-v6so6306966pfa.7 for ; Mon, 14 May 2018 09:55:42 -0700 (PDT) Received: from localhost.localdomain (109.227.199.104.bc.googleusercontent.com. [104.199.227.109]) by smtp.gmail.com with ESMTPSA id u69-v6sm631448pgb.42.2018.05.14.09.55.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 May 2018 09:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aX3sDwjfakqhtRP0Z49uFUz5sIyRodddMtGk3by/K9Y=; b=TKtcI3PKuvoSJkDXKDbpDjUUC47gLvuhVO16WZuHre5n4dm3XTHWPPD1m9zt9R+uzW fchrb4wcmtxOYgADjKVuif6Mpzjeet7MkhCngT2Jt/7lf8H/SRoF+bzM8SUwWStcA6mk DbjtbDKn5p2TfIIbasNN7oXP3JrJC2T8kbEgcZiTCf0mBSFzon6pPiq23fnZn1Lpnoo7 YvN6sPnIXb/VoKOP67ygRlNI797E4i2puma+0DPOUBIpkV7Y2c6cQ7N3dj5gt5hG/bV1 M5VKmG8DvQXuwF3B5TsXRbMAZAVAPUZIDoNNec0KT2Zsh2GVuq+kfw42IBE0R2d44TJr p1Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aX3sDwjfakqhtRP0Z49uFUz5sIyRodddMtGk3by/K9Y=; b=tdGN+19jJlxTsznxd8EKyVI27sc+5BnP0V8T9v3WjG7F99XJMhltSegR5YLfBz2rM7 v6UyKwtheR3pa9x5qtmWF+mzmM8pcp+S0bERHlzx75Awq/O1Zl9k7NTm2BPbx0ueasHa InqyKIasAHehBDgLL2wxehF4fGIAlEKa600EB/bxMnrzWCqwaNgOERRlhcfMaH4Ht1zw A/096c0T3uUBmmPrP1laXSBoJxzPk5BSw5OjpdTIgs0WYbRQxo3Wgl8N5s/Q3WLjuYWu FkK926cWSrs78a9gE+pU/wuRqf9sxU6WBXEzMmRdgBEyXVUQZVV/sKme/bObXwJ2n5DG VQ0A== X-Gm-Message-State: ALKqPwcLRRoUfj5Ulit7sAFKomZWyc7IGA6SnxtWIdsAuBVUz+CZvulh XL5Hnrch2TfJF0lBdpPKuW3LKA== X-Google-Smtp-Source: AB8JxZpQyR0UNL7v7YFFoImwiJJ//uqqePh3taKMHH1zwETKiSUWwNd6vF4qgfJzeZqUBRRgL7PUPg== X-Received: by 2002:a63:6fc8:: with SMTP id k191-v6mr1107216pgc.153.1526316941277; Mon, 14 May 2018 09:55:41 -0700 (PDT) From: Zhang Chen To: qemu-devel@nongnu.org Date: Tue, 15 May 2018 00:54:20 +0800 Message-Id: <20180514165424.12884-14-zhangckid@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180514165424.12884-1-zhangckid@gmail.com> References: <20180514165424.12884-1-zhangckid@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH V7 RESEND 13/17] COLO: flush host dirty ram from cache X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhanghailiang , Li Zhijian , Jason Wang , Markus Armbruster , "Dr . David Alan Gilbert" , Zhang Chen , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: zhanghailiang Don't need to flush all VM's ram from cache, only flush the dirty pages since last checkpoint Signed-off-by: Li Zhijian Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 4235a8f24d..21027c5b4d 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2786,6 +2786,7 @@ int colo_init_ram_cache(void) } ram_state =3D g_new0(RAMState, 1); ram_state->migration_dirty_pages =3D 0; + memory_global_dirty_log_start(); =20 return 0; =20 @@ -2806,10 +2807,12 @@ void colo_release_ram_cache(void) { RAMBlock *block; =20 + memory_global_dirty_log_stop(); QLIST_FOREACH_RCU(block, &ram_list.blocks, next) { g_free(block->bmap); block->bmap =3D NULL; } + rcu_read_lock(); QLIST_FOREACH_RCU(block, &ram_list.blocks, next) { if (block->colo_cache) { @@ -3042,6 +3045,15 @@ static void colo_flush_ram_cache(void) void *src_host; unsigned long offset =3D 0; =20 + memory_global_dirty_log_sync(); + qemu_mutex_lock(&ram_state->bitmap_mutex); + rcu_read_lock(); + RAMBLOCK_FOREACH(block) { + migration_bitmap_sync_range(ram_state, block, 0, block->used_lengt= h); + } + rcu_read_unlock(); + qemu_mutex_unlock(&ram_state->bitmap_mutex); + trace_colo_flush_ram_cache_begin(ram_state->migration_dirty_pages); rcu_read_lock(); block =3D QLIST_FIRST_RCU(&ram_list.blocks); --=20 2.17.0