From nobody Thu Oct 30 01:40:16 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526316876528565.8770086754531; Mon, 14 May 2018 09:54:36 -0700 (PDT) Received: from localhost ([::1]:47247 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIGk7-000765-OW for importer@patchew.org; Mon, 14 May 2018 12:54:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIGYM-0006tx-Lo for qemu-devel@nongnu.org; Mon, 14 May 2018 12:42:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIGYJ-0005jG-Jq for qemu-devel@nongnu.org; Mon, 14 May 2018 12:42:26 -0400 Received: from mail-cys01nam02on0061.outbound.protection.outlook.com ([104.47.37.61]:63568 helo=NAM02-CY1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fIGYJ-0005if-CB for qemu-devel@nongnu.org; Mon, 14 May 2018 12:42:23 -0400 Received: from bmoger-ubuntu.amd.com (165.204.78.1) by MW2PR12MB2476.namprd12.prod.outlook.com (2603:10b6:907:9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Mon, 14 May 2018 16:42:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8/7sqGkhbQQTDHGPGYEiNo1pCSE/hXRWhi6i7h625Tw=; b=lnRrQ7kVLLK4Cf85NJzgL36ZoRzmpJ/F+URYAjYWrXMbrEIcnDHIBI3OBY5WkezJuZhu/hkI6TfhkdnjCk4SfgMVcBuKK8ViGP9M3jxGQAkXsFCcyS9XxLz3xLqxVVQw/jwmmgVL9OzALoOyqGlYlVbFqcDQaebqZKeEDUaw2lk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Mon, 14 May 2018 11:41:55 -0500 Message-Id: <20180514164156.27034-7-babu.moger@amd.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180514164156.27034-1-babu.moger@amd.com> References: <20180514164156.27034-1-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: SN4PR0701CA0008.namprd07.prod.outlook.com (2603:10b6:803:28::18) To MW2PR12MB2476.namprd12.prod.outlook.com (2603:10b6:907:9::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:MW2PR12MB2476; X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2476; 3:/wl4+iXO3Dw6T2ubsc+Km5tN7ZtnPntS41ycQpLocQrXu7J80Vd4qyBRtv79d/Y7q6YUBQsgBqPs0nLv5afh0xXzQuFK+EU3dvkqEhzEExHHzPC6kMj2TB5Lo9qqo+ff6VVCkDbnDMlFWYf4Aqh13ZLvRH/twLTt4jx5gp32wSYAdpadB86/6Hz2F2cKMVwEIvTw+Dr4h4euemkUmh4Uk/NdrVVf+RqTnMDppeEFOL+FhxHycud2eNkNe1QP2mo4; 25:YUpipdGYWg8taWNsfXrxsTQE0Klbj+ZVtQQdDrfmUC3jiZxxPveMduCLh4TrriYByHDW3q2JC8usvpjapDq3n5SpHxt94B+mORzL+Ndg3diBl0QjEI84TpJYhS6Afbfco8Tly9IYk1uN3G3lvkexSgygMATLNpicasUVjNPcfBKdHDwKjXK1h4J42k5JnPjikdLOkm1tuOdf42xHu29ww6ZD6ae+49nBUT9WcX5coiEw+IU9RfkVpARTsd+IHUH0G9MvqtsKo8XByNRXAUHt6lrVGQmurwn0Kg2r440WkzVGMNrm/MRG5eowialeZ4eDwR9MLvo2WFE7kkz9O6FNmg==; 31:TxSXawlnFiDFfB+QjJRGipDeexJfqgfIDEewzYGctmlnPZLIktXvCvc2l1LTNqCOwAHUjxsgYKaQmXSmjDb6fVw7uIbCnSuHIhCvK31TV7rRtSMcw5mNjwFNRtKejeXs9cJPP50Re1g+dt/Dqx9SbGrOwuUv5fwRmcMK630oT21U7tzuTwiXWgCiC9brermGpwwoRHNGHocfsQhLiUuumE9/XE0jUqg17SG2P3CShuU= X-MS-TrafficTypeDiagnostic: MW2PR12MB2476: X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2476; 20:+swCnak/mQRlt54/xjp7HhfPO4VKl3RQTiqHQ5o/zLhqjYbhZtJKAnMc0CzIFDzDXDjak9XBS3gQMO6jwe6aP8FrMfSaKlHu3FAAhna2JDY9fboYuOSwOLqpjgiBiKCYBZR17+jXf6qtY0DpNzqH9sJp3KdfRLawls8dEVgOWK94YWkAvSnKBewvJ+y6Bnptq+iUEb5zPn6y8emX13eHh30ixoV4D/sw6ZDD7vYSMvXa+7xgcGY/Izh/zc3WN6TIkLiJ1r4K9AnNKhlxRd5ZYoHxRBmQdUp/c9GYk7kgcbtox5HPpeRFjm+nZSUrV3PjNrq58+UnCNHEI1e2g6oIs/YpKG+xlVMPVwg7lr3JUmvr6e1GSm27lXND6pr8tkaB9t3Q44PP2CsIQDGQ3IfOsyYPlQtKHOGzIcEKnnpyIYJ+Zai3NZjEufUh2qiMd426973x65FIOqs89hmWuIbfL8euVnTypBrYy5JBQizTg4VP25uL6zKa0GZHe8kOZ8YV; 4:pYgx4Y0mEfPXBd4Cj/nc9KVfeId6NGA4Aggr4pZVoN7KOj7DHW0cMfSa7WaYQZ4HK+yMUD72UJpjhJD66OmqJFuQFUkESUL98MYsLAaNeb97cxH62qg5e6+VMCupMV7aqQcOx8I3fen2b3Id+oh+Hr8Ft0dOZmIt+D+S2G11LSOUzdGzKuPmCtUV7fsKVxBnjDt5v0Xu/ea8fk36v08I4b6UoRQfIn6rPlT7wHk9NWAR42IULsRz1DBJxAfn8QEQ9JmByr6uY+mct++2fHtW/Bks/0we/4z0n2FvcwEpD/ylDTt+lQwmN5QHxkJoP205 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:MW2PR12MB2476; BCL:0; PCL:0; RULEID:; SRVR:MW2PR12MB2476; X-Forefront-PRVS: 067270ECAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(396003)(346002)(376002)(366004)(199004)(189003)(50226002)(53936002)(50466002)(8936002)(8676002)(39060400002)(48376002)(2616005)(486006)(476003)(305945005)(25786009)(7736002)(6666003)(446003)(11346002)(956004)(59450400001)(5660300001)(76176011)(186003)(36756003)(86362001)(16526019)(81166006)(26005)(4326008)(386003)(81156014)(7416002)(106356001)(53416004)(72206003)(97736004)(316002)(47776003)(478600001)(105586002)(51416003)(68736007)(6116002)(3846002)(16586007)(2906002)(6486002)(1076002)(44832011)(7696005)(66066001)(52116002)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:MW2PR12MB2476; H:bmoger-ubuntu.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MW2PR12MB2476; 23:CSz7GgSn0PaQPhOEuK9ggCpB3eQUAz5bFkuuHFLLw?= =?us-ascii?Q?fXsN3F97IsM5z90qul/mkcHf60O1MOdhOpz9n1qY1CBYJAhV5Jr9QjR/1LNG?= =?us-ascii?Q?qU3bGa4cKWA9tQGmlAPRFh4QBHTkcn/JoH2AssHxyBSvWz75C0I3aL4Up1Tx?= =?us-ascii?Q?bxerfkiCjpjbbRpy83Sud0uppYYx7/QXSGkfqfuaXyedJrQL/g1y0BGWryOj?= =?us-ascii?Q?9q6MGVawY7Pt9ICgQ0+72PfjMjzDuT9cj0cobUQYNiCCFydibN+3hE7ncv8z?= =?us-ascii?Q?/tG8H6p/tJq3LTT1WY3IqVFr41sZslFBAe5iAtXmWbjJfmVAbrjiMligMWHP?= =?us-ascii?Q?JTWvuuTJ38Bv4tXSIO+IL7j72N/XzOQ+4zN9+voqvgRwrnzv9F5pcqYT7yXF?= =?us-ascii?Q?F9LHi3u+FxJjMDroATEQSU9FncwBmaE4sJdMFwJvVkb/uFRRmjNaTAX+k/6Y?= =?us-ascii?Q?1+rELOQLmgo4qDGrP/nSytOqzD+G/7H3byNaAR2Nxx0ccjuxRcRklGSwOMaL?= =?us-ascii?Q?clqHYgSLC25JuE3JvK8k0EkGmxupR7tts/GImDCsaCyFyQrR8y4+W6wiyyYk?= =?us-ascii?Q?RmqPAczE6+/yZCz3wZHMwmExgoj/9iPPirOzgcjdk0jAbDS1dmpyJwEZYPIj?= =?us-ascii?Q?5LF9rxrXAkzsDuf3RdyBLDmz+EN+Vk4QGtxGXN7tpx05XXbkf6KwPEnw+gyP?= =?us-ascii?Q?bUK9sIf4meLrP2vwJgzm91j7CntpKMMLjgbv/VhPh9w0siLQPLX4KVygRSOM?= =?us-ascii?Q?qJbtv7xVAo7Q97Fgpb4VBAgbdqmCQkpzvlkGMKKHy5K9Jo6CrWeklUbDW53/?= =?us-ascii?Q?uuNZ3sZ/KirzHS6+17hZ9uc0uzchNGJe34lZLMozwASYsA6iGi0UNf3jzS94?= =?us-ascii?Q?qIQ8VM2eXoN7T4UR46sDoFZl5Y9+ambt9UDWNMmbejrHThmshnNSWB9ykj7S?= =?us-ascii?Q?K/vPni3eyUNG/s8OzH5/H9qL3YBiYxh3XqKR4+UA61tM5ktQ77AjUR2MKhHL?= =?us-ascii?Q?JMhHsMjBLLc0iSb2+3dx8jHodezpTjkTYAc/ryO7AaZa/YnMdZoBnimFDAJu?= =?us-ascii?Q?PkX9acAd1/AXGDFx3OD0sRwIInOn2MNJEzy6FjQa4aEXlPW5ZH9BucQf/yST?= =?us-ascii?Q?r/kfpfF0S1qmNVtctHzdQDwKw0hgdm1D8oZXb1gWOrpzddwZRaHY+pLB/MXo?= =?us-ascii?Q?Qfneyh14pdTzTa7aiJN0RuJwlUmVp5emy3CcZMpulj7M0Vt8MDNleVNTIOvw?= =?us-ascii?Q?vkMq8e3cvKGSvWEuni1RZlylfyjkSobV+n+KNnz0Sgk+o4Ukdo5yAZAR5ivD?= =?us-ascii?Q?KmTH6XUqcOfUCYuHLIXNCw=3D?= X-Microsoft-Antispam-Message-Info: eFCoM5Yc1NqMM0ciXSDv7lOUEeWnZGDlWUHGvFN/vS428F7f7nk0da7zyqS7BmvEHRxYx5mDnAGvyaUCF2TnJQd4tVCjRK+2RUGtl9SuJM8Exz6h/VFJw1WidhgTQ12kMDqAG6ieAB1litsP+oZOeazMbB3HIyAskWaiLRSaMvkZ3EuxAQsGGe5rq+ytt7TX X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2476; 6:JcrdGybphUCS/2RFZMHkpUMynQghwhbVGUowkbtfJ/hjbvhs8EpkXG6G0NQA3pfz0jnb7etyf4zAY5+Lp6x3uGxBdy4nJaRp/FJEs+oWHHI/Pbm6BUN9aUGOZ8LNFX1h932etMi70VRTyBylxHJH8izwHGV/ixB1b+lDY1qFbuT2Zo2+0qU+MHUT1zYmqM5xfzAltHzqRE5vVwAShoepYojdatoYB46JkR1zXa0kJpQ2ng9ts9lOkdZ7bcdgpFPnUYYZRmi4hi5WfBUCXNj/9kIKFPGEk9np9Ahb9Vbw92J9uyRbyah3eEdUZxsb6S/T9bngmbVtSUi3ttVeHaZBpEE21Q7AdmhSQGssVskaecb1V9n7XPMtSDhrJEq7d9cwqDzdjAKQs6o6cMBczdUHHotmM0H+6RWMWgJ+wGsgdue2e70HAzTcvM49Ekjp63BY87cziQ0XTaLqvmDHf6+BtA==; 5:MiDIe/E9DgOT/yL84co/jgX4d98RhqkC/rSYLOwA5/7Ms/90s7LdIn7nJ4thehaKAqoXNmhzp2Wh8BGm1e5EcjlBkm7um8qLls9I4P2KSDxzi8S2GdmJ6k1ZVynF7evEvFcD8nCaUjeJruxYao4dtB8e9Ae+a85JEAm08BgmAic=; 24:iSvA31lWZ+9ELOy2hgiRLThM/6376LhbABVh+S4+oEqYRMVgTlAml3l5qotBA8nNTJUiZ60tUSe4yVDyDF1AHWHnZCXwONwGwOyPhcx9w74= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2476; 7:UaCg6RSx0817/gvWx5uHJsbuwhY6N9LMu6UZLxjggo3SRd79plweCjvghWjlKEQqDaMbLkeNS6/0BG6/p9bKxNynGBQu55XeY6cmeN4KEAR4cCkA9RuuphUFI0M39icrgNmBj4fE2I5G0NwIO67IX+9pT/QU0U39UrTYVFfephQVVpck89Sm9zrYLvNGqxvXC73aM4BIcKaF1NsAzmDcQeUX/vyyT6a7S7qBWoSHnrOW6v2gLFkByrOY7K4n4ROc; 20:jaek0BKC8R5v3Y2Eb/LhtV7EvhgqH0Mq8ftj2BprnlL4E7LeJYEbsPKCQdvmYWrm3Pwv1xfG8gAqW4yJfykEDjHNItduBbV1fJEzo5zZShUVwKT4APpdTEFYvds0U1UhVlcoxbtIF1vI5EazAf4s5X9qFHX4xDx/GjvBafnwbV1Nr7HkT6AC3VWczD6Y2P8jSrA61KIkmm3hPbo96VzY0CqhDwUZ1iL+Of1G071vkppe2IhESEin+pMZ4AMe8NEB X-MS-Office365-Filtering-Correlation-Id: f04f89a2-6006-4058-fda1-08d5b9b9a9ce X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2018 16:42:20.2733 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f04f89a2-6006-4058-fda1-08d5b9b9a9ce X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2476 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.37.61 Subject: [Qemu-devel] [PATCH v9 6/7] i386: Enable TOPOEXT feature on AMD EPYC CPU X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Enable TOPOEXT feature on EPYC CPU. This is required to support hyperthreading on VM guests. Also extend xlevel to 0x8000001E. Disable TOPOEXT feature for legacy (2.12 or older) machine types. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae Reviewed-by: Eduardo Habkost --- include/hw/i386/pc.h | 4 ++++ target/i386/cpu.c | 11 +++++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index df15deefca..c01adc92ba 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -310,6 +310,10 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_= t *); .driver =3D TYPE_X86_CPU,\ .property =3D "legacy-cache",\ .value =3D "on",\ + },{\ + .driver =3D "EPYC-" TYPE_X86_CPU,\ + .property =3D "topoext",\ + .value =3D "off",\ }, =20 #define PC_COMPAT_2_11 \ diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 18a7872b7d..de2749ae81 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -2424,7 +2424,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { .features[FEAT_8000_0001_ECX] =3D CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH | CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM | - CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM, + CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM | + CPUID_EXT3_TOPOEXT, .features[FEAT_7_0_EBX] =3D CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_AV= X2 | CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_RDSEED= | @@ -2469,7 +2470,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { .features[FEAT_8000_0001_ECX] =3D CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH | CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM | - CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM, + CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM | + CPUID_EXT3_TOPOEXT, .features[FEAT_8000_0008_EBX] =3D CPUID_8000_0008_EBX_IBPB, .features[FEAT_7_0_EBX] =3D @@ -4540,6 +4542,11 @@ static void x86_cpu_expand_features(X86CPU *cpu, Err= or **errp) x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000000A); } =20 + /* TOPOEXT feature requires 0x8000001E */ + if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) { + x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000001E); + } + /* SEV requires CPUID[0x8000001F] */ if (sev_enabled()) { x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000001F); --=20 2.17.0