From nobody Wed Oct 29 22:58:35 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525889716426158.69585420781277; Wed, 9 May 2018 11:15:16 -0700 (PDT) Received: from localhost ([::1]:58250 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGTcR-00017B-Fp for importer@patchew.org; Wed, 09 May 2018 14:15:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGTJN-0005D4-At for qemu-devel@nongnu.org; Wed, 09 May 2018 13:55:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGTJJ-0005pY-BW for qemu-devel@nongnu.org; Wed, 09 May 2018 13:55:33 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:44702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGTJI-0005o3-QN for qemu-devel@nongnu.org; Wed, 09 May 2018 13:55:29 -0400 Received: by mail-pf0-x241.google.com with SMTP id q22so25999824pff.11 for ; Wed, 09 May 2018 10:55:28 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id l90sm60332813pfb.149.2018.05.09.10.55.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 10:55:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tHmg5eLHi+EzkAo0eEENkBnSNWaSOcxMvFpNbUagEVg=; b=CBtsmAqpJ4zMb6ksiU4giWAvqAygqd6gxzvsEbOPLuHOWWp6YMvQs3tea/8peYS/9b QDPGYcE/mplrX74kQVu+g3LJMU64PzveHo1WQdVu0Z+cW6050nmo4gbO2QiFlpq0/rtw DNTQ9hwKcvq6lwK3mDzR7IYJmh7lLyeZjk2AI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tHmg5eLHi+EzkAo0eEENkBnSNWaSOcxMvFpNbUagEVg=; b=iEVncZjPQG+oaIBtjGxj3F2mRkRLtq4bnzPLYxC7RWT34Yeto4p/Nhaey210irbjuN uHuxFNSMxBRposYx1u6BPVHJZe+h7cwX1aSw6BclwQLU3xIcJjKXjKMeIjQaPNYwpb6o 2tXTrDmpTqPVSve0cj8u82zf/CV98/S+0kzfmsUhRkaVIBEArgWjSerNGWBpTCF3GN/l xwhhQbEBbJpYUp+ldRRaoS14HP4JEdXGys5z3+F7YAT5EY3/ho7cQnjunYJmlUyIMs57 T6BReZAn7VPLoBl2S9Xvwt3HBzvqMG+ReMBBmLIGzzE9Pqfy8C8T/gXNZn9xHznzDK+j N0Eg== X-Gm-Message-State: ALQs6tAyM21MthvOHC2yg7GDiBgB+kB9fHDXNzXP0AlQYh8+anufmZ4s pLK+FUpcdPzmLtx/zLZBOnKHsJU0rqE= X-Google-Smtp-Source: AB8JxZoeHbtb9VEqQclgDQeDAZ/fQLeGoucKUSjYUgY9NBJX6UpTBige6xV/ex3DrNmi/GiXtXJ8qQ== X-Received: by 2002:a63:6110:: with SMTP id v16-v6mr36261482pgb.292.1525888527003; Wed, 09 May 2018 10:55:27 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 9 May 2018 10:54:45 -0700 Message-Id: <20180509175458.15642-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509175458.15642-1-richard.henderson@linaro.org> References: <20180509175458.15642-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PULL 15/28] target/sparc: convert to TranslatorOps X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sagar Karandikar , David Hildenbrand , Palmer Dabbelt , Mark Cave-Ayland , Max Filippov , Michael Clark , "Edgar E. Iglesias" , Guan Xuetao , Yongbok Kim , Alexander Graf , "Emilio G. Cota" , Richard Henderson , Artyom Tarasenko , Eduardo Habkost , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Stafford Horne , David Gibson , Peter Crosthwaite , Bastian Koppelmann , Cornelia Huck , Michael Walle , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Emilio G. Cota" Notes: - Moved the cross-page check from the end of translate_insn to init_disas_context. Reviewed-by: Richard Henderson Tested-by: Mark Cave-Ayland Cc: Mark Cave-Ayland Cc: Artyom Tarasenko Signed-off-by: Emilio G. Cota Signed-off-by: Richard Henderson --- target/sparc/translate.c | 178 +++++++++++++++++++-------------------- 1 file changed, 88 insertions(+), 90 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 889c43976d..40b2eaad39 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -5737,99 +5737,91 @@ static void disas_sparc_insn(DisasContext * dc, uns= igned int insn) } } =20 -void gen_intermediate_code(CPUState *cs, TranslationBlock * tb) +static void sparc_tr_init_disas_context(DisasContextBase *dcbase, CPUState= *cs) { + DisasContext *dc =3D container_of(dcbase, DisasContext, base); CPUSPARCState *env =3D cs->env_ptr; - DisasContext dc1, *dc =3D &dc1; - int max_insns; - unsigned int insn; - - memset(dc, 0, sizeof(DisasContext)); - dc->base.tb =3D tb; - dc->base.pc_first =3D tb->pc; - dc->base.pc_next =3D tb->pc; - dc->base.is_jmp =3D DISAS_NEXT; - dc->base.num_insns =3D 0; - dc->base.singlestep_enabled =3D cs->singlestep_enabled; + int bound; =20 dc->pc =3D dc->base.pc_first; - dc->npc =3D (target_ulong) tb->cs_base; + dc->npc =3D (target_ulong)dc->base.tb->cs_base; dc->cc_op =3D CC_OP_DYNAMIC; - dc->mem_idx =3D tb->flags & TB_FLAG_MMU_MASK; + dc->mem_idx =3D dc->base.tb->flags & TB_FLAG_MMU_MASK; dc->def =3D &env->def; - dc->fpu_enabled =3D tb_fpu_enabled(tb->flags); - dc->address_mask_32bit =3D tb_am_enabled(tb->flags); + dc->fpu_enabled =3D tb_fpu_enabled(dc->base.tb->flags); + dc->address_mask_32bit =3D tb_am_enabled(dc->base.tb->flags); #ifndef CONFIG_USER_ONLY - dc->supervisor =3D (tb->flags & TB_FLAG_SUPER) !=3D 0; + dc->supervisor =3D (dc->base.tb->flags & TB_FLAG_SUPER) !=3D 0; #endif #ifdef TARGET_SPARC64 dc->fprs_dirty =3D 0; - dc->asi =3D (tb->flags >> TB_FLAG_ASI_SHIFT) & 0xff; + dc->asi =3D (dc->base.tb->flags >> TB_FLAG_ASI_SHIFT) & 0xff; #ifndef CONFIG_USER_ONLY - dc->hypervisor =3D (tb->flags & TB_FLAG_HYPER) !=3D 0; + dc->hypervisor =3D (dc->base.tb->flags & TB_FLAG_HYPER) !=3D 0; #endif #endif + /* + * if we reach a page boundary, we stop generation so that the + * PC of a TT_TFAULT exception is always in the right page + */ + bound =3D -(dc->base.pc_first | TARGET_PAGE_MASK) / 4; + dc->base.max_insns =3D MIN(dc->base.max_insns, bound); +} =20 - max_insns =3D tb_cflags(tb) & CF_COUNT_MASK; - if (max_insns =3D=3D 0) { - max_insns =3D CF_COUNT_MASK; +static void sparc_tr_tb_start(DisasContextBase *db, CPUState *cs) +{ +} + +static void sparc_tr_insn_start(DisasContextBase *dcbase, CPUState *cs) +{ + DisasContext *dc =3D container_of(dcbase, DisasContext, base); + + if (dc->npc & JUMP_PC) { + assert(dc->jump_pc[1] =3D=3D dc->pc + 4); + tcg_gen_insn_start(dc->pc, dc->jump_pc[0] | JUMP_PC); + } else { + tcg_gen_insn_start(dc->pc, dc->npc); } - if (max_insns > TCG_MAX_INSNS) { - max_insns =3D TCG_MAX_INSNS; +} + +static bool sparc_tr_breakpoint_check(DisasContextBase *dcbase, CPUState *= cs, + const CPUBreakpoint *bp) +{ + DisasContext *dc =3D container_of(dcbase, DisasContext, base); + + if (dc->pc !=3D dc->base.pc_first) { + save_state(dc); } - if (dc->base.singlestep_enabled || singlestep) { - max_insns =3D 1; + gen_helper_debug(cpu_env); + tcg_gen_exit_tb(0); + dc->base.is_jmp =3D DISAS_NORETURN; + /* update pc_next so that the current instruction is included in tb->s= ize */ + dc->base.pc_next +=3D 4; + return true; +} + +static void sparc_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) +{ + DisasContext *dc =3D container_of(dcbase, DisasContext, base); + CPUSPARCState *env =3D cs->env_ptr; + unsigned int insn; + + insn =3D cpu_ldl_code(env, dc->pc); + dc->base.pc_next +=3D 4; + disas_sparc_insn(dc, insn); + + if (dc->base.is_jmp =3D=3D DISAS_NORETURN) { + return; } - - gen_tb_start(tb); - do { - if (dc->npc & JUMP_PC) { - assert(dc->jump_pc[1] =3D=3D dc->pc + 4); - tcg_gen_insn_start(dc->pc, dc->jump_pc[0] | JUMP_PC); - } else { - tcg_gen_insn_start(dc->pc, dc->npc); - } - dc->base.num_insns++; - - if (unlikely(cpu_breakpoint_test(cs, dc->base.pc_next, BP_ANY))) { - if (dc->pc !=3D dc->base.pc_first) { - save_state(dc); - } - gen_helper_debug(cpu_env); - tcg_gen_exit_tb(0); - dc->base.is_jmp =3D DISAS_NORETURN; - dc->base.pc_next +=3D 4; - goto exit_gen_loop; - } - - if (dc->base.num_insns =3D=3D max_insns && (tb_cflags(tb) & CF_LAS= T_IO)) { - gen_io_start(); - } - - insn =3D cpu_ldl_code(env, dc->pc); - dc->base.pc_next +=3D 4; - - disas_sparc_insn(dc, insn); - - if (dc->base.is_jmp =3D=3D DISAS_NORETURN) { - break; - } - /* if the next PC is different, we abort now */ - if (dc->pc !=3D dc->base.pc_next) { - break; - } - /* if we reach a page boundary, we stop generation so that the - PC of a TT_TFAULT exception is always in the right page */ - if ((dc->pc & (TARGET_PAGE_SIZE - 1)) =3D=3D 0) - break; - } while (!tcg_op_buf_full() && - (dc->pc - dc->base.pc_first) < (TARGET_PAGE_SIZE - 32) && - dc->base.num_insns < max_insns); - - exit_gen_loop: - if (tb_cflags(tb) & CF_LAST_IO) { - gen_io_end(); + if (dc->pc !=3D dc->base.pc_next) { + dc->base.is_jmp =3D DISAS_TOO_MANY; } +} + +static void sparc_tr_tb_stop(DisasContextBase *dcbase, CPUState *cs) +{ + DisasContext *dc =3D container_of(dcbase, DisasContext, base); + if (dc->base.is_jmp !=3D DISAS_NORETURN) { if (dc->pc !=3D DYNAMIC_PC && (dc->npc !=3D DYNAMIC_PC && dc->npc !=3D JUMP_PC)) { @@ -5843,23 +5835,29 @@ void gen_intermediate_code(CPUState *cs, Translatio= nBlock * tb) tcg_gen_exit_tb(0); } } - gen_tb_end(tb, dc->base.num_insns); +} =20 - tb->size =3D dc->base.pc_next - dc->base.pc_first; - tb->icount =3D dc->base.num_insns; +static void sparc_tr_disas_log(const DisasContextBase *dcbase, CPUState *c= pu) +{ + qemu_log("IN: %s\n", lookup_symbol(dcbase->pc_first)); + log_target_disas(cpu, dcbase->pc_first, dcbase->tb->size); +} =20 -#ifdef DEBUG_DISAS - if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM) - && qemu_log_in_addr_range(dc->base.pc_first)) { - qemu_log_lock(); - qemu_log("--------------\n"); - qemu_log("IN: %s\n", lookup_symbol(dc->base.pc_first)); - log_target_disas(cs, dc->base.pc_first, - dc->base.pc_next - dc->base.pc_first); - qemu_log("\n"); - qemu_log_unlock(); - } -#endif +static const TranslatorOps sparc_tr_ops =3D { + .init_disas_context =3D sparc_tr_init_disas_context, + .tb_start =3D sparc_tr_tb_start, + .insn_start =3D sparc_tr_insn_start, + .breakpoint_check =3D sparc_tr_breakpoint_check, + .translate_insn =3D sparc_tr_translate_insn, + .tb_stop =3D sparc_tr_tb_stop, + .disas_log =3D sparc_tr_disas_log, +}; + +void gen_intermediate_code(CPUState *cs, TranslationBlock *tb) +{ + DisasContext dc =3D {}; + + translator_loop(&sparc_tr_ops, &dc.base, cs, tb); } =20 void sparc_tcg_init(void) --=20 2.17.0