From nobody Wed Oct 29 22:59:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525838161600625.9401401236908; Tue, 8 May 2018 20:56:01 -0700 (PDT) Received: from localhost ([::1]:54313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGGCu-00045z-N9 for importer@patchew.org; Tue, 08 May 2018 23:56:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGG4f-0004X9-K7 for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGG4e-0002s3-TO for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:29 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:46597) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fGG4e-0002rb-OW for qemu-devel@nongnu.org; Tue, 08 May 2018 23:47:28 -0400 Received: by mail-qt0-x241.google.com with SMTP id m16-v6so43923535qtg.13 for ; Tue, 08 May 2018 20:47:28 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id w12-v6sm14497002qtb.80.2018.05.08.20.47.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 20:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7AwOIfizm689LrWy4uTeuWZjlBlaGqrjj9Vj9vU6nIg=; b=cKCYVYZ3wFHdq5HpBigTUiej7j6aKbtfMqXivtTKF4wIecxtX15cfXKfWnawem1+rM 9Skq/Z/R8OsCX4rL/sMNbgkAWlHHh2FMGijBALxbJG0xmceYLctifp/Y4ol8pU9Mj7pr 0h9RVrFkZV+zjCZVRDbVXDizELze3T9ANQYGKCj2T3dAMJ03YGN90O5XrEcWW9orhzHz snbLf80gOT5BlhxUf8VCDHJVQdNFGs+D2dtF8zXlpFA5/+7rWgSppBp0fSFDjdtGQkdT DBM+CsvRA+BYjYEmeNUYC+cEg3AcHlLMN+PYErfRK1894fwt9kJfwTNaWG1j/qxj5pDx 3I/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=7AwOIfizm689LrWy4uTeuWZjlBlaGqrjj9Vj9vU6nIg=; b=V/lEXATBzIwCaflm7PYD5gWO7hnqqkavYCab2byggAC44nm7Q/BDrLs2jahw2/wk53 7FHSwk67cei0SmEw6um0CbqEg3+MKedPxrhyklc25WbaD4FJJp+YQs1/sp6R6VqIFIKm IDS5mPWVVS8bZlJHIzBVgzG8R5VtrOSGiWtoaRC7oDjkQ3SaWucXVMMMic55mDUQK8T+ a36ngTB2IVVHalZ7aZIgeI/lpV/YPuvijzvEWYYaAfPzrgVTXWto0lIWz+VHoB/OcPlI nOFGGmohBeKt6P9Fn7QSJFS6AvvVcePraNp216UMnS8BgM7Dcm+dNnWCHawvjfM1oHEh UHTg== X-Gm-Message-State: ALKqPwfEkSMTVOfjExdIFukVTMnhz+/e3eY8p5IrKi0/1+ZN4bvtBl/B nllriDEpYaN85b/fTStFYGc= X-Google-Smtp-Source: AB8JxZokuEGfJevB64bOHJOrwBLpoQ8L0D6L04LDWtqMA0KhP5ac4nALnIRYnkyrsuM/SQLMMzEl8g== X-Received: by 2002:ac8:2f22:: with SMTP id j31-v6mr661840qta.366.1525837648100; Tue, 08 May 2018 20:47:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , "Edgar E . Iglesias" Date: Wed, 9 May 2018 00:46:51 -0300 Message-Id: <20180509034658.26455-8-f4bug@amsat.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180509034658.26455-1-f4bug@amsat.org> References: <20180509034658.26455-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v2 07/14] sdcard: Invert the sd_req_crc_is_valid() logic X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Let's return TRUE when the CRC is valid. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/sd/sd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index d8dad94fc4..6fc8daa5b8 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -467,13 +467,13 @@ static void sd_set_sdstatus(SDState *sd) memset(sd->sd_status, 0, 64); } =20 -static int sd_req_crc_validate(SDRequest *req) +static bool sd_req_crc_is_valid(SDRequest *req) { uint8_t buffer[5]; buffer[0] =3D 0x40 | req->cmd; stl_be_p(&buffer[1], req->arg); - return 0; - return sd_frame48_calc_checksum(buffer) !=3D req->crc; /* TODO */ + return true; + return sd_frame48_calc_checksum(buffer) =3D=3D req->crc; /* TODO */ } =20 static void sd_response_r1_make(SDState *sd, uint8_t *response) @@ -1631,7 +1631,7 @@ int sd_do_command(SDState *sd, SDRequest *req, return 0; } =20 - if (sd_req_crc_validate(req)) { + if (!sd_req_crc_is_valid(req)) { sd->card_status |=3D COM_CRC_ERROR; rtype =3D sd_illegal; goto send_response; --=20 2.17.0